[GitHub] [arrow] kiszk commented on pull request #7507: ARROW-8797: [C++] Read RecordBatch in a different endian
kiszk commented on pull request #7507: URL: https://github.com/apache/arrow/pull/7507#issuecomment-780605746 @pitrou I appreciate a lot of your valuable feedbacks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #7507: ARROW-8797: [C++] Read RecordBatch in a different endian
kiszk commented on pull request #7507: URL: https://github.com/apache/arrow/pull/7507#issuecomment-780387899 @pitrou I addressed your comments. Could you take a look again? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #7507: ARROW-8797: [C++] Read RecordBatch in a different endian
kiszk commented on pull request #7507: URL: https://github.com/apache/arrow/pull/7507#issuecomment-778937798 @pitrou Sorry for being late to address your comments. I addressed all of your comments. Now, it is ready for your review again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #7507: ARROW-8797: [C++] Read RecordBatch in a different endian
kiszk commented on pull request #7507: URL: https://github.com/apache/arrow/pull/7507#issuecomment-775141706 Thank you. Ping you later. I have to add test cases for review while I addressed all comments in the source files. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #7507: ARROW-8797: [C++] Read RecordBatch in a different endian
kiszk commented on pull request #7507: URL: https://github.com/apache/arrow/pull/7507#issuecomment-774403485 > You mean even the little-endian cases fail on Java? Yes, now failures may occur on Java. I will work for this kind on Java after getting the consensus in ML. (Strangely, I cannot put the comment to [this comment](https://github.com/apache/arrow/pull/7507#discussion_r562063359)) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #7507: ARROW-8797: [C++] Read RecordBatch in a different endian
kiszk commented on pull request #7507: URL: https://github.com/apache/arrow/pull/7507#issuecomment-755108332 @pitrou gentle ping This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #7507: ARROW-8797: [C++] Read RecordBatch in a different endian
kiszk commented on pull request #7507: URL: https://github.com/apache/arrow/pull/7507#issuecomment-749068143 @pitrou Sure, it is fine with me. Happy holiday and new year! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #7507: ARROW-8797: [C++] Read RecordBatch in a different endian
kiszk commented on pull request #7507: URL: https://github.com/apache/arrow/pull/7507#issuecomment-748572198 @wesm @pitrou Sorry for being late. Could you please review this? I addressed all of the comments except [this](https://github.com/apache/arrow/pull/7507#discussion_r513725869) that will be addressed by another PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #7507: ARROW-8797: [C++] Read RecordBatch in a different endian
kiszk commented on pull request #7507: URL: https://github.com/apache/arrow/pull/7507#issuecomment-740923764 Addressed comments except the following two items - be addressing https://github.com/apache/arrow/pull/7507#discussion_r513711536 - postpone https://github.com/apache/arrow/pull/7507#discussion_r513725869 to another PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #7507: ARROW-8797: [C++] Read RecordBatch in a different endian
kiszk commented on pull request #7507: URL: https://github.com/apache/arrow/pull/7507#issuecomment-740138806 I am still working for this on my end since I have failures during addressing [this comment](https://github.com/apache/arrow/pull/7507#discussion_r513711536). Tomorrow, I will push the working version that has addressed other comments. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #7507: ARROW-8797: [C++] Read RecordBatch in a different endian
kiszk commented on pull request #7507: URL: https://github.com/apache/arrow/pull/7507#issuecomment-725211378 Thank you, I will address style issues. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #7507: ARROW-8797: [C++] Read RecordBatch in a different endian
kiszk commented on pull request #7507: URL: https://github.com/apache/arrow/pull/7507#issuecomment-717385965 @pitou Thank you for letting us the status. It is fine with me. Enjoy your vacation This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #7507: ARROW-8797: [C++] Read RecordBatch in a different endian
kiszk commented on pull request #7507: URL: https://github.com/apache/arrow/pull/7507#issuecomment-717381980 @pitrou @wesm Could you please review this to support ipc between different endian clients? [The document](https://github.com/apache/arrow/pull/8374) has been merged. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #7507: ARROW-8797: [C++] Read RecordBatch in a different endian
kiszk commented on pull request #7507: URL: https://github.com/apache/arrow/pull/7507#issuecomment-671751774 @kou I addressed your two comments. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #7507: ARROW-8797: [C++] Read RecordBatch in a different endian
kiszk commented on pull request #7507: URL: https://github.com/apache/arrow/pull/7507#issuecomment-667471857 It is ready for review now. @wesm @pitrou @kou Would it be possible to review it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #7507: ARROW-8797: [C++] Read RecordBatch in a different endian
kiszk commented on pull request #7507: URL: https://github.com/apache/arrow/pull/7507#issuecomment-663947048 After merging this PR https://github.com/apache/arrow-testing/pull/41, I will update the `integration_arrow.sh` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #7507: ARROW-8797: [C++] Read RecordBatch in a different endian
kiszk commented on pull request #7507: URL: https://github.com/apache/arrow/pull/7507#issuecomment-660690067 This commit can succeed to run an integration test with primitive types like this. ``` ../../../build/debug/arrow-json-integration-test --integration --json int32_primitive.json --arrow int32_primitive_le.arrow --mode=VALIDATE ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
