[GitHub] [arrow] kou commented on pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow

2020-08-06 Thread GitBox 


kou commented on pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#issuecomment-669764587


   Thanks for testing this!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] kou commented on pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow

2020-08-03 Thread GitBox 


kou commented on pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#issuecomment-667836959


   @github-actions crossbow submit centos-* wheel-win-*
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] kou commented on pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow

2020-08-02 Thread GitBox 


kou commented on pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#issuecomment-667805956


   @github-actions crossbow submit -g linux wheel-win-*



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] kou commented on pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow

2020-08-02 Thread GitBox 


kou commented on pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#issuecomment-667793688


   @github-actions crossbow submit -g example -g linux



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] kou commented on pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow

2020-08-02 Thread GitBox 


kou commented on pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#issuecomment-667789090


   @tobim Most of changes are done. I'm working on the last check. Could you 
confirm the current code and the updated PR description? If the last check is 
done and addressed your feedback, I'll merge this.
   
   Here are summary of my changes 
https://github.com/apache/arrow/compare/76b4b022179f94bdb5b77086acf253b6a7bcbbe9...3aed2131e18a7f9db00cd446fc887d78e777686a
 :
   
 * Export `ARROW_LIBRARY_PATH_SUFFIXES` and `ARROW_INCLUDE_PATH_SUFFIXES` 
to `ArrowConfig.cmake` instead of copying definitions of `LIB_PATH_SUFFIXES` 
and `INCLUDE_PATH_SUFFIXES`.
 * Rename `ARROW_USE_SHARED_SYSTEM_LIBS` to `ARROW_DEPENDENCY_USE_SHARED` 
because we already have `ARROW_DEPENDENCY_SOURCE` option that is the default 
value of `*_SOURCE`.
 * Don't use `ARROW_DEPENDENCY_USE_SHARED` as the default value of 
`ARROW_THRIFT_USE_SHARED_DEFAULT` on Windows because it seems that Thrift's DLL 
support isn't well for now.
 * Use more strict library names for LZ4, ZStandard, Snappy, Thrift and 
utf8proc. I confirmed library names of them on WIndows by provided binaries and 
build configuration files of them.
 * Use only package names (`ARROW_SYSTEM_DEPENDENCIES`) instead of 
`find_dependency(...)` (`ARROW_FIND_DEPENDENCY_LIST`) to provide 
`find_dependency()` list to `ArrowConfig.cmake` because it'll be simpler.
 * Use Docker Compose instead of raw Docker in 
`cpp/examples/minimal_build/` to manage multiple build configurations.
   * I split one `Dockerfile` that contains `*-dev` packages to 
`Dockerfile` with/without `*-dev` packages to show our build system uses 
bundled libraries for nonexistent dependencies by default.
   
   The AppVeyor failure is unrelated: 
https://issues.apache.org/jira/browse/ARROW-9621



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] kou commented on pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow

2020-08-02 Thread GitBox 


kou commented on pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#issuecomment-66693


   @github-actions crossbow submit -g nightly



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] kou commented on pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow

2020-07-29 Thread GitBox 


kou commented on pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#issuecomment-665350733


   Thanks.
   I can push the branch.
   
   I'm still working on this. Please wait for a while.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org