[GitHub] [arrow] kou commented on pull request #8049: ARROW-9851: [C++] Disable AVX512 runtime paths with Valgrind

2020-08-28 Thread GitBox 


kou commented on pull request #8049:
URL: https://github.com/apache/arrow/pull/8049#issuecomment-683163747


   OK.
   I merge this.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] kou commented on pull request #8049: ARROW-9851: [C++] Disable AVX512 runtime paths with Valgrind

2020-08-26 Thread GitBox 


kou commented on pull request #8049:
URL: https://github.com/apache/arrow/pull/8049#issuecomment-681096064


   I agree with you including upper case.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] kou commented on pull request #8049: ARROW-9851: [C++] Disable AVX512 runtime paths with Valgrind

2020-08-25 Thread GitBox 


kou commented on pull request #8049:
URL: https://github.com/apache/arrow/pull/8049#issuecomment-680501869


   > ARROW_USER_SIMD_LEVEL is a ENV variants, will this change pass AVX2 to 
ARROW_USER_SIMD_LEVEL env?
   
   Yes. But the patch was wrong. We need to use lower case for 
`ARROW_USER_SIMD_LEVEL`:
   
   ```diff
   diff --git a/docker-compose.yml b/docker-compose.yml
   index 86cffad81..626292358 100644
   --- a/docker-compose.yml
   +++ b/docker-compose.yml
   @@ -199,6 +199,7 @@ services:
  ARROW_JEMALLOC: "OFF"
  ARROW_S3: "OFF"
  ARROW_TEST_MEMCHECK: "ON"
   +  ARROW_USER_SIMD_LEVEL: "avx2" # AVX512 not supported by Valgrind 
(ARROW-9851)
  ARROW_USE_LD_GOLD: "ON"
  BUILD_WARNING_LEVEL: "PRODUCTION"
volumes: *conda-volumes
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] kou commented on pull request #8049: ARROW-9851: [C++] Disable AVX512 runtime paths with Valgrind

2020-08-25 Thread GitBox 


kou commented on pull request #8049:
URL: https://github.com/apache/arrow/pull/8049#issuecomment-680423797


   OK. Then I think that the environment variable approach is better because we 
already have `ARROW_USER_SIMD_LEVEL` support (I didn't know!). The following 
patch will work:
   
   ```diff
   diff --git a/docker-compose.yml b/docker-compose.yml
   index 86cffad81..55da4b60b 100644
   --- a/docker-compose.yml
   +++ b/docker-compose.yml
   @@ -199,6 +199,7 @@ services:
  ARROW_JEMALLOC: "OFF"
  ARROW_S3: "OFF"
  ARROW_TEST_MEMCHECK: "ON"
   +  ARROW_USER_SIMD_LEVEL: "AVX2" # AVX512 not supported by Valgrind 
(ARROW-9851)
  ARROW_USE_LD_GOLD: "ON"
  BUILD_WARNING_LEVEL: "PRODUCTION"
volumes: *conda-volumes
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] kou commented on pull request #8049: ARROW-9851: [C++] Disable AVX512 runtime paths with Valgrind

2020-08-25 Thread GitBox 


kou commented on pull request #8049:
URL: https://github.com/apache/arrow/pull/8049#issuecomment-680382309


   > Another potential approach is the ARROW_USER_SIMD_LEVEL flag during 
runtime, something like "ARROW_USER_SIMD_LEVEL=avx2 make unittest", I'm not 
familiar with CI system thus don't know if it's easy to hook 
ARROW_USER_SIMD_LEVEL flag.
   
   We can change environment variables only for test in CI.
   
   But I don't know whether Valgrind can work with binary that has AVX512 
instructions or not...



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] kou commented on pull request #8049: ARROW-9851: [C++] Disable AVX512 runtime paths with Valgrind

2020-08-25 Thread GitBox 


kou commented on pull request #8049:
URL: https://github.com/apache/arrow/pull/8049#issuecomment-680377715


   @github-actions crossbow submit test-conda-cpp-valgrind



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org