[GitHub] [arrow] kszucs edited a comment on pull request #7516: ARROW-9201: [Archery] More user-friendly console output for benchmark diffs, add repetitions argument, don't build unit tests

2020-06-22 Thread GitBox 


kszucs edited a comment on pull request #7516:
URL: https://github.com/apache/arrow/pull/7516#issuecomment-647798092


   Using pandas is not a problem, but the results cannot be improved much other 
than sorting the table.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] kszucs edited a comment on pull request #7516: ARROW-9201: [Archery] More user-friendly console output for benchmark diffs, add repetitions argument, don't build unit tests

2020-06-22 Thread GitBox 


kszucs edited a comment on pull request #7516:
URL: https://github.com/apache/arrow/pull/7516#issuecomment-647677894


   > @kszucs can you assist me with adapting ursabot for these changes?
   
   Sure.
   
   > I think we can use pandas's `DataFrame.to_html` to create a colorized 
table for GitHub, too 
https://pandas.pydata.org/pandas-docs/stable/user_guide/style.html
   
   I'm afraid this is not going to work, because we can't embed any CSS into 
the comment, this is why we generate the ursabot responses as diffs.
   
   > 
   > Changes that would be good to have in `ursabot benchmark`:
   > 
   > * Pass through `--cc` and `--cxx` options
   > * Pass through `--repetitions`
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org