[GitHub] [arrow] liyafan82 commented on pull request #6425: ARROW-6111: [Java] Support LargeVarChar and LargeBinary types

2020-05-27 Thread GitBox 


liyafan82 commented on pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#issuecomment-635050822


   @BryanCutler @siddharthteotia @emkornfield I am aware that this PR is large, 
and consumes lots of effort. So thanks a lot for your effort and good comments!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] liyafan82 commented on pull request #6425: ARROW-6111: [Java] Support LargeVarChar and LargeBinary types

2020-05-27 Thread GitBox 


liyafan82 commented on pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#issuecomment-634447500


   > Great job getting integration tests passing @liyafan82 ! I took a quick 
look and LGTM, will do a more thorough pass hopefully tomorrow before merging.
   
   @BryanCutler Please take your time. Thanks a lot for your effort. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] liyafan82 commented on pull request #6425: ARROW-6111: [Java] Support LargeVarChar and LargeBinary types

2020-05-26 Thread GitBox 


liyafan82 commented on pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#issuecomment-633883684


   @BryanCutler The integration tests pass now. Please take another look when 
you have time. Thank you.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] liyafan82 commented on pull request #6425: ARROW-6111: [Java] Support LargeVarChar and LargeBinary types

2020-05-22 Thread GitBox 


liyafan82 commented on pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#issuecomment-632982040


   > Thanks @liyafan82 , looks like they didn't pass on this first try. Any 
idea what was causing the error?
   > 
   > ```
   > Error accessing files
   > Current token (VALUE_STRING) not numeric, can not use numeric value 
accessors
   >  at [Source: (File); line: 65, column: 14]
   > 12:46:37.776 [main] ERROR org.apache.arrow.tools.Integration - Error 
accessing files
   > com.fasterxml.jackson.core.JsonParseException: Current token 
(VALUE_STRING) not numeric, can not use numeric value accessors
   >  at [Source: (File); line: 65, column: 14]
   >at 
com.fasterxml.jackson.core.JsonParser._constructError(JsonParser.java:1804)
   >at 
com.fasterxml.jackson.core.base.ParserMinimalBase._reportError(ParserMinimalBase.java:698)
   >at 
com.fasterxml.jackson.core.base.ParserBase._parseNumericValue(ParserBase.java:781)
   >at 
com.fasterxml.jackson.core.base.ParserBase._parseIntValue(ParserBase.java:799)
   >at 
com.fasterxml.jackson.core.base.ParserBase.getIntValue(ParserBase.java:645)
   >at 
org.apache.arrow.vector.ipc.JsonFileReader$BufferHelper$5.read(JsonFileReader.java:306)
   > ```
   
   Thank you @BryanCutler . I am investigating. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] liyafan82 commented on pull request #6425: ARROW-6111: [Java] Support LargeVarChar and LargeBinary types

2020-05-22 Thread GitBox 


liyafan82 commented on pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#issuecomment-632603791


   @BryanCutler @emkornfield Sorry for my late response. 
   I have removed the skip. Let's see if the integration tests can pass this 
time. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] liyafan82 commented on pull request #6425: ARROW-6111: [Java] Support LargeVarChar and LargeBinary types

2020-05-05 Thread GitBox 


liyafan82 commented on pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#issuecomment-624426890


   @nealrichardson and @BryanCutler Thanks for your good suggestion.
   I have removed the skip in `datagen.py`, but the tests failed. The reason is 
that we do not support `LargeList` type yet:
   
   ```
   2020-05-06T03:03:50.3032543Z 
com.fasterxml.jackson.databind.exc.InvalidTypeIdException: Could not resolve 
type id 'largelist' as a subtype of [simple type, class 
org.apache.arrow.vector.types.pojo.ArrowType]: known type ids = [binary, bool, 
date, decimal, duration, fixedsizebinary, fixedsizelist, floatingpoint, int, 
interval, largebinary, largeutf8, list, map, null, struct, time, timestamp, 
union, utf8] (for POJO property 'type')
   2020-05-06T03:03:50.3033308Z  at [Source: (File); line: 7, column: 19] 
(through reference chain: 
org.apache.arrow.vector.types.pojo.Schema["fields"]->java.util.ArrayList[0]->org.apache.arrow.vector.types.pojo.Field["type"])
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org