[GitHub] [arrow] liyafan82 commented on pull request #9151: ARROW-11173: [Java] Add map type in complex reader / writer
liyafan82 commented on pull request #9151: URL: https://github.com/apache/arrow/pull/9151#issuecomment-786525254 Had another pass. Mostly look good to me. I am also a little concerned about @BryanCutler 's comment (https://github.com/apache/arrow/pull/9151/files#r570608317) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] liyafan82 commented on pull request #9151: ARROW-11173: [Java] Add map type in complex reader / writer
liyafan82 commented on pull request #9151: URL: https://github.com/apache/arrow/pull/9151#issuecomment-764632071 @nbruno Thanks for the PR. For the Java implementation, the Map type is implemented as a List of Struct. So we should already have supported the Map type? What is the motivation of the new implementation? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] liyafan82 commented on pull request #9151: ARROW-11173: [Java] Add map type in complex reader / writer
liyafan82 commented on pull request #9151: URL: https://github.com/apache/arrow/pull/9151#issuecomment-764632071 @nbruno Thanks for the PR. For the Java implementation, the Map type is implemented as a List of Struct. So we should already have supported the Map type? What is the motivation of the new implementation? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
