[GitHub] [arrow] mrkn commented on pull request #7044: ARROW-6485: [Format][C++] Support the format of a COO sparse matrix that has separated row and column indices

2020-07-06 Thread GitBox


mrkn commented on pull request #7044:
URL: https://github.com/apache/arrow/pull/7044#issuecomment-654582143


   >> If we go for a new type - could I propose a name SparseCOOMatrix (as 
opposed to n-dimensional SparseCOOTensor). It could perhaps be shortened to 
COOM?
   >
   > The implementation in this pull-request can handle more than 2-dimension.
   
   Oh, I forgot to change the title of this pull-request. Sorry.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [arrow] mrkn commented on pull request #7044: ARROW-6485: [Format][C++] Support the format of a COO sparse matrix that has separated row and column indices

2020-07-06 Thread GitBox


mrkn commented on pull request #7044:
URL: https://github.com/apache/arrow/pull/7044#issuecomment-654581941


   > Hey @mrkn - sorry I didn't have capacity to reply for a while.
   
   No problem. Thank you for your cooperation!
   
   > If I remember correctly only SciPy has this architecture of COO index 
having two vectors instead of one 2D matrix.
   
   Not only scipy, but also 
[SuiteSparse](https://github.com/DrTimothyAldenDavis/SuiteSparse) employs the 
split format.
   
   > Question: could we handle this as a special case of COO tensor rather than 
a new type? Could we serialize `(row, col)` data as a single row major tensor 
of COO type and only deserialize it into the SciPy layout if desired? (I'm 
asking because I'm not sure if such approach is feasible)
   > 
   
   Although we can handle the split-format as an internal variation of 
SparseCOOIndex, we still need to introduce the new flatbuffer type.
   
   > If we go for a new type - could I propose a name SparseCOOMatrix (as 
opposed to n-dimensional SparseCOOTensor). It could perhaps be shortened to 
`COOM`?
   
   The implementation in this pull-request can handle more than 2-dimension.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org