[GitHub] [arrow] nealrichardson commented on a change in pull request #7287: ARROW-8771: [C++] Add boost/process library to build support

[GitBox]

nealrichardson commented on a change in pull request #7287:
URL: https://github.com/apache/arrow/pull/7287#discussion_r441176530



##
File path: cpp/build-support/trim-boost.sh
##
@@ -32,12 +32,12 @@ set -eu
 : 
${BOOST_URL:=https://dl.bintray.com/boostorg/release/${BOOST_VERSION}/source/${BOOST_FILE}.tar.gz}
 
 # Arrow tests require these
-BOOST_LIBS="system.hpp filesystem.hpp"
+BOOST_LIBS="process.hpp filesystem.hpp"

Review comment:
   I wasn't sure if it was safe to remove system.hpp because it is named 
explicitly in cmake and don't have time to track this down right now, so 
leaving a note to future self.
   
   ```suggestion
   # TODO: is system still required? We declare 
`--with-libraries=filesystem,regex,system`
   # in cmake, but there is no #include  in our source anymore
   BOOST_LIBS="system.hpp process.hpp filesystem.hpp"
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] nealrichardson commented on a change in pull request #7287: ARROW-8771: [C++] Add boost/process library to build support

[GitBox]

nealrichardson commented on a change in pull request #7287:
URL: https://github.com/apache/arrow/pull/7287#discussion_r431923571



##
File path: cpp/build-support/trim-boost.sh
##
@@ -41,6 +41,8 @@ BOOST_LIBS="$BOOST_LIBS regex.hpp"
 BOOST_LIBS="$BOOST_LIBS multiprecision/cpp_int.hpp"
 # These are for Thrift when Thrift_SOURCE=BUNDLED
 BOOST_LIBS="$BOOST_LIBS algorithm/string.hpp locale.hpp noncopyable.hpp 
numeric/conversion/cast.hpp scope_exit.hpp scoped_array.hpp shared_array.hpp 
tokenizer.hpp version.hpp"
+#These are for flight
+BOOST_LIBS="$BOOST_LIBS process.hpp process asio fusion"

Review comment:
   `bcp` should figure that out and pull whatever dependencies are needed 
into the trimmed boost bundle we build, so if `process.hpp` is all that Flight 
references, let's just include that.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] nealrichardson commented on a change in pull request #7287: ARROW-8771: [C++] Add boost/process library to build support

[GitBox]

nealrichardson commented on a change in pull request #7287:
URL: https://github.com/apache/arrow/pull/7287#discussion_r431282877



##
File path: cpp/build-support/trim-boost.sh
##
@@ -41,6 +41,8 @@ BOOST_LIBS="$BOOST_LIBS regex.hpp"
 BOOST_LIBS="$BOOST_LIBS multiprecision/cpp_int.hpp"
 # These are for Thrift when Thrift_SOURCE=BUNDLED
 BOOST_LIBS="$BOOST_LIBS algorithm/string.hpp locale.hpp noncopyable.hpp 
numeric/conversion/cast.hpp scope_exit.hpp scoped_array.hpp shared_array.hpp 
tokenizer.hpp version.hpp"
+#These are for flight
+BOOST_LIBS="$BOOST_LIBS process.hpp process asio fusion"

Review comment:
   I thought you only needed process.hpp? Why also `process asio fusion`?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org