[GitHub] [arrow] nealrichardson commented on pull request #7741: ARROW-9449: [R] Strip arrow.so
nealrichardson commented on pull request #7741: URL: https://github.com/apache/arrow/pull/7741#issuecomment-658392235 @github-actions crossbow submit test-r-rstudio-r-base-3.6-opensuse42 test-r-rocker-r-base-latest This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #7741: ARROW-9449: [R] Strip arrow.so
nealrichardson commented on pull request #7741: URL: https://github.com/apache/arrow/pull/7741#issuecomment-658392032 The two crossbow failures (other than conda-r, which we're ignoring) appear to be flakes, but I'll re-run them to be extra sure. Re-review appreciated on the latest change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #7741: ARROW-9449: [R] Strip arrow.so
nealrichardson commented on pull request #7741: URL: https://github.com/apache/arrow/pull/7741#issuecomment-658332593 @github-actions crossbow submit -g r This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #7741: ARROW-9449: [R] Strip arrow.so
nealrichardson commented on pull request #7741: URL: https://github.com/apache/arrow/pull/7741#issuecomment-658310822 On one of the linux images I've been testing locally, as well as on my mac, the R makevars added in that commit are setting `CXXFLAGS="-g -O2"`. Given that, it probably makes sense not to pass those flags to the libarrow build. But I still think we should strip because I can't control the fact that R is including that when it compiles the R bindings--that is, I could edit the makevars on my own system, but the package installation can't override whatever makevars R has on other people's systems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #7741: ARROW-9449: [R] Strip arrow.so
nealrichardson commented on pull request #7741: URL: https://github.com/apache/arrow/pull/7741#issuecomment-657915188 Something caused a major (3x) increase in the size of the libs from one day to the next. Could have been the bundled dependency patch or could have been one of several others, it was a busy day. I could bisect if we care to find out, but for the moment this seemed to be a good enough fix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #7741: ARROW-9449: [R] Strip arrow.so
nealrichardson commented on pull request #7741: URL: https://github.com/apache/arrow/pull/7741#issuecomment-657900315 Cmake reports that it is a release build. You can see that in the logs. Maybe the change to the new bundled dependency library is no longer passing that to the external projects? Either way, there's value in stripping even just the R bindings themselves. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #7741: ARROW-9449: [R] Strip arrow.so
nealrichardson commented on pull request #7741: URL: https://github.com/apache/arrow/pull/7741#issuecomment-657876030 Apparently the macOS version of `strip` takes different args: https://travis-ci.org/github/ursa-labs/crossbow/builds/707793921#L1112 So we'll have to switch based on uname and/or make sure that this doesn't fail the build. Will pick up on this tomorrow. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #7741: ARROW-9449: [R] Strip arrow.so
nealrichardson commented on pull request #7741: URL: https://github.com/apache/arrow/pull/7741#issuecomment-657815754 This is an order of magnitude improvement. On the AMD64 Ubuntu 18.04 R 4.0 builds, which use an Arrow C++ shared library, arrow.so (so just the R bindings) is down from 24.3mb to 3.3mb. On the 4.0 centos7 build, which bundles static libs, it's down from 144.5mb (about 3x larger in the last couple of days) to 17.4mb. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #7741: ARROW-9449: [R] Strip arrow.so
nealrichardson commented on pull request #7741: URL: https://github.com/apache/arrow/pull/7741#issuecomment-657806099 @github-actions crossbow submit *autobrew* This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
