[GitHub] [arrow] pitrou commented on a change in pull request #7755: ARROW-9390: [C++][Doc] Review compute function names

2020-07-14 Thread GitBox 


pitrou commented on a change in pull request #7755:
URL: https://github.com/apache/arrow/pull/7755#discussion_r454553900



##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -944,7 +944,7 @@ void RegisterScalarStringAscii(FunctionRegistry* registry) {
   MakeUnaryStringBatchKernel("ascii_upper", registry);
   MakeUnaryStringBatchKernel("ascii_lower", registry);
 
-  AddUnaryStringPredicate("binary_isascii", registry);
+  AddUnaryStringPredicate("string_isascii", registry);

Review comment:
   Also `ascii_is_alnum`, etc. ;-)





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] pitrou commented on a change in pull request #7755: ARROW-9390: [C++][Doc] Review compute function names

2020-07-14 Thread GitBox 


pitrou commented on a change in pull request #7755:
URL: https://github.com/apache/arrow/pull/7755#discussion_r454550954



##
File path: cpp/src/arrow/compute/kernels/scalar_string_benchmark.cc
##
@@ -61,9 +61,9 @@ static void IsAlphaNumericAscii(benchmark::State& state) {
   UnaryStringBenchmark(state, "ascii_isalnum");
 }
 
-static void BinaryContainsExact(benchmark::State& state) {
-  BinaryContainsExactOptions options("abac");
-  UnaryStringBenchmark(state, "binary_contains_exact", );
+static void MatchSubstring(benchmark::State& state) {
+  MatchSubstringOptions options("abac");
+  UnaryStringBenchmark(state, "match_substring", );

Review comment:
   I don't think so. Personally, I find prefixes a bit pointless or even 
distracting.
   (or, here, plain misleading, since "binary_contains_exact" didn't work on 
binary arrays, only string arrays...)
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] pitrou commented on a change in pull request #7755: ARROW-9390: [C++][Doc] Review compute function names

2020-07-14 Thread GitBox 


pitrou commented on a change in pull request #7755:
URL: https://github.com/apache/arrow/pull/7755#discussion_r454551146



##
File path: cpp/src/arrow/compute/kernels/scalar_string_benchmark.cc
##
@@ -61,9 +61,9 @@ static void IsAlphaNumericAscii(benchmark::State& state) {
   UnaryStringBenchmark(state, "ascii_isalnum");
 }
 
-static void BinaryContainsExact(benchmark::State& state) {
-  BinaryContainsExactOptions options("abac");
-  UnaryStringBenchmark(state, "binary_contains_exact", );
+static void MatchSubstring(benchmark::State& state) {
+  MatchSubstringOptions options("abac");
+  UnaryStringBenchmark(state, "match_substring", );

Review comment:
   Perhaps someone else wants to think about a convention?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] pitrou commented on a change in pull request #7755: ARROW-9390: [C++][Doc] Review compute function names

2020-07-14 Thread GitBox 


pitrou commented on a change in pull request #7755:
URL: https://github.com/apache/arrow/pull/7755#discussion_r454549799



##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -944,7 +944,7 @@ void RegisterScalarStringAscii(FunctionRegistry* registry) {
   MakeUnaryStringBatchKernel("ascii_upper", registry);
   MakeUnaryStringBatchKernel("ascii_lower", registry);
 
-  AddUnaryStringPredicate("binary_isascii", registry);
+  AddUnaryStringPredicate("string_isascii", registry);

Review comment:
   That's a good point. Should we make a followup PR?
   (if it's me, it's only tomorrow)





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org