[GitHub] [arrow] pitrou commented on a change in pull request #7929: ARROW-9602: [R] Improve cmake detection in Linux build

[GitBox]

pitrou commented on a change in pull request #7929:
URL: https://github.com/apache/arrow/pull/7929#discussion_r468419449



##
File path: r/tools/linuxlibs.R
##
@@ -315,8 +315,13 @@ build_libarrow <- function(src_dir, dst_dir) {
 }
 
 ensure_cmake <- function() {
-  cmake <- Sys.which("cmake")
-  if (!nzchar(cmake) || cmake_version() < 3.2) {
+  cmake <- find_cmake(c(
+Sys.getenv("CMAKE"),
+Sys.which("cmake"),
+Sys.which("cmake3")
+  ))
+
+  if (is.null(cmake)) {
 # If not found, download it
 cat(" cmake\n")
 CMAKE_VERSION <- Sys.getenv("CMAKE_VERSION", "3.16.2")

Review comment:
   You probably want to bump that version: latest is either 3.18.1, 3.17.4 
or 3.16.8.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] pitrou commented on a change in pull request #7929: ARROW-9602: [R] Improve cmake detection in Linux build

[GitBox]

pitrou commented on a change in pull request #7929:
URL: https://github.com/apache/arrow/pull/7929#discussion_r468418886



##
File path: r/tools/linuxlibs.R
##
@@ -315,8 +315,13 @@ build_libarrow <- function(src_dir, dst_dir) {
 }
 
 ensure_cmake <- function() {
-  cmake <- Sys.which("cmake")
-  if (!nzchar(cmake) || cmake_version() < 3.2) {
+  cmake <- find_cmake(c(
+Sys.getenv("CMAKE"),
+Sys.which("cmake"),
+Sys.which("cmake3")

Review comment:
   Does `cmake3` actually exist in the wild?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org