[GitHub] [arrow] pitrou commented on pull request #8229: ARROW-9579: [C++] Provide the plugin API to support customized compression codec for parquet
pitrou commented on pull request #8229: URL: https://github.com/apache/arrow/pull/8229#issuecomment-887311848 Link to ML discussion: https://lists.apache.org/thread.html/r88c56e47cdd69eda23477c67c8e4ad5e66a3ccb144087082d427ffbf%40%3Cdev.arrow.apache.org%3E -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #8229: ARROW-9579: [C++] Provide the plugin API to support customized compression codec for parquet
pitrou commented on pull request #8229: URL: https://github.com/apache/arrow/pull/8229#issuecomment-887311279 I'm going to close this PR as stale, and because the approach here is too heavy-weight as already discussed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #8229: ARROW-9579: [C++] Provide the plugin API to support customized compression codec for parquet
pitrou commented on pull request #8229: URL: https://github.com/apache/arrow/pull/8229#issuecomment-696176912 Hmm, reading the mailing-list discussion again, I don't think we had agreed on a design. The first question for me is what the end-user API should be. * should the user calling the Parquet reader ask explicitly for a compression override (e.g. "instead of using standard GZip, use HW-accelerated GZip") * should instead the compression override be configured using a global setting? * or should the override even be transparent? (how?) From a first look, I see this PR proposes a plugin API, which does not seem necessary to solve the problem at hand. Arrow is a library and I'm not sure it's our duty to implement a specific extension-loading mechanism (though I could be convinced otherwise :-)). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #8229: ARROW-9579: [C++] Provide the plugin API to support customized compression codec for parquet
pitrou commented on pull request #8229: URL: https://github.com/apache/arrow/pull/8229#issuecomment-696176912 Hmm, reading the mailing-list discussion again, I don't think we had agreed on a design. The first question for me is what the end-user API should be. * should the user calling the Parquet reader ask explicitly for a compression override (e.g. "instead of using standard GZip, use HW-accelerated GZip") * should instead the compression override be configured using a global setting? * or should the override even be transparent? (how?) From a first look, I see this PR proposes a plugin API, which does not seem necessary to solve the problem at hand. Arrow is a library and I'm not sure it's our duty to implement a specific extension-loading mechanism (though I could be convinced otherwise :-)). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
