[GitHub] [arrow] revit13 commented on pull request #8159: ARROW-9104: [C++] Parquet encryption tests should write files to a temporary directory instead of the testing submodule's directory

2020-09-10 Thread GitBox 


revit13 commented on pull request #8159:
URL: https://github.com/apache/arrow/pull/8159#issuecomment-690501845


   @pitrou  Please ignore my previous comment. It seems that the branch is 
merged ok. Thanks again. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] revit13 commented on pull request #8159: ARROW-9104: [C++] Parquet encryption tests should write files to a temporary directory instead of the testing submodule's directory

2020-09-10 Thread GitBox 


revit13 commented on pull request #8159:
URL: https://github.com/apache/arrow/pull/8159#issuecomment-690469456


   @pitrou Thanks again for the review. I would like to merge the changes but 
this pull request seems to be closed. I am not sure how to resolve this.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] revit13 commented on pull request #8159: "ARROW-9104: [C++] Parquet encryption tests should write files to a temporary directory instead of the testing submodule's directory"

2020-09-10 Thread GitBox 


revit13 commented on pull request #8159:
URL: https://github.com/apache/arrow/pull/8159#issuecomment-690157916


   @pitrou Thanks for your feedback. I changed the code to use TemporaryDir as 
you suggested. I appreciate it if you could review the new version of the code. 
 (The CI failures so far looks unrelated to the patch)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org