[GitHub] [arrow] rymurr commented on a change in pull request #7768: ARROW-9475: [Java] Clean up usages of BaseAllocator, use BufferAllocator in…
rymurr commented on a change in pull request #7768: URL: https://github.com/apache/arrow/pull/7768#discussion_r468539432 ## File path: java/memory/memory-core/src/main/java/org/apache/arrow/memory/BufferAllocator.java ## @@ -126,6 +134,30 @@ BufferAllocator newChildAllocator( */ long getHeadroom(); + /** + * Forcibly allocate bytes. Returns whether the allocation fit within limits. + * + * @param size to increase + * @return Whether the allocation fit within limits. + */ + boolean forceAllocate(long size); Review comment: :+1: sorry, missed that This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] rymurr commented on a change in pull request #7768: ARROW-9475: [Java] Clean up usages of BaseAllocator, use BufferAllocator in…
rymurr commented on a change in pull request #7768: URL: https://github.com/apache/arrow/pull/7768#discussion_r454964570 ## File path: java/memory/memory-core/src/main/java/org/apache/arrow/memory/BufferAllocator.java ## @@ -126,6 +134,30 @@ BufferAllocator newChildAllocator( */ long getHeadroom(); + /** + * Forcibly allocate bytes. Returns whether the allocation fit within limits. + * + * @param size to increase + * @return Whether the allocation fit within limits. + */ + boolean forceAllocate(long size); Review comment: I didn't see where this or releaseBytes are used in code. What is the purpose of releaseBytes and of makign forceAllocate public This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
