vertexclique commented on a change in pull request #8636:
URL: https://github.com/apache/arrow/pull/8636#discussion_r521339244
##########
File path: rust/arrow/src/compute/kernels/filter.rs
##########
@@ -112,7 +112,7 @@ impl<'a> CopyNullBit for NullBitSetter<'a> {
}
fn null_buffer(&mut self) -> Buffer {
- self.target_buffer.resize(self.target_index).unwrap();
+ self.target_buffer.resize(self.target_index);
Review comment:
These are most probably generating clippy warnings.
##########
File path: rust/arrow/src/buffer.rs
##########
@@ -676,9 +676,9 @@ impl MutableBuffer {
/// `new_len` will be zeroed out.
///
/// If `new_len` is less than `len`, the buffer will be truncated.
- pub fn resize(&mut self, new_len: usize) -> Result<()> {
+ pub fn resize(&mut self, new_len: usize) -> () {
Review comment:
```suggestion
pub fn resize(&mut self, new_len: usize) {
```
It is the same in other positions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
