[GitHub] [arrow] wesm commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain

2020-06-24 Thread GitBox


wesm commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-649098754


   Once the utf8_lower/utf8_upper patch lands I am going to make utf8proc not 
mandatory. See ARROW-9220.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [arrow] wesm commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain

2020-06-22 Thread GitBox


wesm commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-647763853


   @xhochy I'm fine with merging this -- it's a non-mandatory dependency right 
(sorry have not reviewed the patch yet and the PR description does not say)?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [arrow] wesm commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain

2020-06-17 Thread GitBox


wesm commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-645370067


   Appears that unilib is a no go. I'm not a fan of one-developer projects 
anyway 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org