[GitHub] [arrow-datafusion] jgoday commented on issue #420: Support for `!=` predicate in pruning predicates

2021-06-14 Thread GitBox


jgoday commented on issue #420:
URL: 
https://github.com/apache/arrow-datafusion/issues/420#issuecomment-859926283


   @alamb  I think that I express myself incorrectly :)
   Created #544 PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [arrow-datafusion] jgoday commented on issue #420: Support for `!=` predicate in pruning predicates

2021-06-10 Thread GitBox


jgoday commented on issue #420:
URL: 
https://github.com/apache/arrow-datafusion/issues/420#issuecomment-85878


   @alamb  Can I try to solve this issue ?
   
   If I understand it correctly, for the non equal predicate the expression 
should be pruned if the literal value does not fall between the min and max 
values, Am I right ?
   (I have already tried to implement it here 
(https://github.com/jgoday/arrow-datafusion/commit/3bb55a4464d23e2a4eb319aac1b51361f31c7485),
 I can make a PR if you approve it)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [arrow-datafusion] jgoday commented on issue #420: Support for `!=` predicate in pruning predicates

2021-06-10 Thread GitBox


jgoday commented on issue #420:
URL: 
https://github.com/apache/arrow-datafusion/issues/420#issuecomment-858776910


   Can I try to solve this issue ?
   
   If I understand it correctly, for the non equal predicate the expression 
should be pruned if the literal value does not fall between the min and max 
values, Am I right ?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org