Re: [I] [Feature Request]: Support for Apache Flink 1.18 in Beam Runners [beam]
m0hit-aggarwal commented on issue #30789: URL: https://github.com/apache/beam/issues/30789#issuecomment-2036191766 +1 for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ignore -- end of options [beam]
github-actions[bot] commented on PR #30845: URL: https://github.com/apache/beam/pull/30845#issuecomment-2036092297 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [yaml] disable javascript mapping for python >=3.12 [beam]
Polber commented on code in PR #30843: URL: https://github.com/apache/beam/pull/30843#discussion_r1550773763 ## sdks/python/setup.py: ## @@ -368,7 +372,6 @@ def get_portability_package_data(): 'grpcio>=1.33.1,!=1.48.0,<2', 'hdfs>=2.1.0,<3.0.0', 'httplib2>=0.8,<0.23.0', - 'js2py>=0.74,<1', Review Comment: Thanks for the heads up - refactored to use environmental marker. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] ignore -- end of options [beam]
Polber opened a new pull request, #30845: URL: https://github.com/apache/beam/pull/30845 Ignore the `--` flag used to signify end of options in bash. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #` instead. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Implement LockFreeHistogram and use it for PerWorkerHistograms [beam]
m-trieu commented on code in PR #30769:
URL: https://github.com/apache/beam/pull/30769#discussion_r1550659948
##
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/LockFreeHistogramTest.java:
##
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.runners.dataflow.worker;
+
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.equalTo;
+
+import java.util.Optional;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import org.apache.beam.sdk.metrics.MetricName;
+import org.apache.beam.sdk.util.HistogramData;
+import org.apache.beam.sdk.values.KV;
+import
org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.primitives.ImmutableLongArray;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
+
+/** Tests for {@link LockFreeHistogram}. */
+@RunWith(JUnit4.class)
+public class LockFreeHistogramTest {
+
+ @Test
+ public void testUpdate_OverflowValues() {
+HistogramData.BucketType bucketType = HistogramData.LinearBuckets.of(0,
10, 3);
+LockFreeHistogram histogram =
+new LockFreeHistogram(KV.of(MetricName.named("name", "namespace"),
bucketType));
+histogram.update(35, 40, 45);
+Optional snapshot =
histogram.getSnapshotAndReset();
+
+LockFreeHistogram.OutlierStatistic expectedOverflow =
+LockFreeHistogram.OutlierStatistic.create(120.0, 3L);
+LockFreeHistogram.OutlierStatistic expectedUnderflow =
LockFreeHistogram.OutlierStatistic.EMPTY;
+ImmutableLongArray expectedBuckets = ImmutableLongArray.of(0L, 0L, 0L);
+LockFreeHistogram.Snapshot expectedSnapshot =
+LockFreeHistogram.Snapshot.create(
+expectedUnderflow, expectedOverflow, expectedBuckets, bucketType);
+
+assertThat(snapshot.isPresent(), equalTo(true));
+assertThat(snapshot.get(), equalTo(expectedSnapshot));
+assertThat(snapshot.get().underflowStatistic().mean(), equalTo(0.0));
+assertThat(snapshot.get().overflowStatistic(), equalTo(expectedOverflow));
+ }
+
+ @Test
+ public void testUpdate_UnderflowValues() {
+HistogramData.BucketType bucketType = HistogramData.LinearBuckets.of(100,
10, 3);
+LockFreeHistogram histogram =
+new LockFreeHistogram(KV.of(MetricName.named("name", "namespace"),
bucketType));
+histogram.update(35, 40, 45);
+Optional snapshot =
histogram.getSnapshotAndReset();
+
+LockFreeHistogram.OutlierStatistic expectedUnderflow =
+LockFreeHistogram.OutlierStatistic.create(120.0, 3L);
+LockFreeHistogram.OutlierStatistic expectedOverflow =
LockFreeHistogram.OutlierStatistic.EMPTY;
+ImmutableLongArray expectedBuckets = ImmutableLongArray.of(0L, 0L, 0L);
+LockFreeHistogram.Snapshot expectedSnapshot =
+LockFreeHistogram.Snapshot.create(
+expectedUnderflow, expectedOverflow, expectedBuckets, bucketType);
+
+assertThat(snapshot.isPresent(), equalTo(true));
+assertThat(snapshot.get(), equalTo(expectedSnapshot));
+assertThat(snapshot.get().underflowStatistic(),
equalTo(expectedUnderflow));
+ }
+
+ @Test
+ public void testUpdate_InBoundsValues() {
+HistogramData.BucketType bucketType = HistogramData.LinearBuckets.of(0,
10, 3);
+LockFreeHistogram histogram =
+new LockFreeHistogram(KV.of(MetricName.named("name", "namespace"),
bucketType));
+histogram.update(5, 15, 25);
+Optional snapshot =
histogram.getSnapshotAndReset();
+
+LockFreeHistogram.OutlierStatistic expectedOverflow =
LockFreeHistogram.OutlierStatistic.EMPTY;
+LockFreeHistogram.OutlierStatistic expectedUnderflow =
LockFreeHistogram.OutlierStatistic.EMPTY;
+ImmutableLongArray expectedBuckets = ImmutableLongArray.of(1L, 1L, 1L);
+LockFreeHistogram.Snapshot expectedSnapshot =
+LockFreeHistogram.Snapshot.create(
+expectedUnderflow, expectedOverflow, expectedBuckets, bucketType);
+
+assertThat(snapshot.isPresent(), equalTo(true));
+assertThat(snapshot.get(), equalTo(expectedSnapshot));
+ }
+
+ @Test
+ public void
Re: [PR] [yaml] add --providers and --providers_file flags [beam]
Polber commented on PR #30835:
URL: https://github.com/apache/beam/pull/30835#issuecomment-2035797734
@robertwb That is a good idea. I went ahead and pushed changes to support
something like:
```
pipeline:
...
providers: !include providers.yaml
```
However, I tested out a similar syntax with jinja, and using a custom
template loader, it is possible to do something like:
```
pipeline:
...
providers: {% include 'providers.yaml' %}
```
In both cases, the framework will accept paths from the local filesystem or
from GCS
(using `apache_beam.io.filesystems.FileSystems`)
---
Since YAML templates will most likely use jinja, gauging current dev list
interaction, I am going to table this for now with the intent to add this
feature with the templatization work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Proposed edits for Beam YAML overview [beam]
github-actions[bot] commented on PR #30842: URL: https://github.com/apache/beam/pull/30842#issuecomment-2035683097 R: @melap for final approval -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [yaml] disable javascript mapping for python >=3.12 [beam]
tvalentyn commented on code in PR #30843: URL: https://github.com/apache/beam/pull/30843#discussion_r1550554929 ## sdks/python/setup.py: ## @@ -368,7 +372,6 @@ def get_portability_package_data(): 'grpcio>=1.33.1,!=1.48.0,<2', 'hdfs>=2.1.0,<3.0.0', 'httplib2>=0.8,<0.23.0', - 'js2py>=0.74,<1', Review Comment: Also let's reference the issue in JS2Py's tracker ## sdks/python/setup.py: ## @@ -368,7 +372,6 @@ def get_portability_package_data(): 'grpcio>=1.33.1,!=1.48.0,<2', 'hdfs>=2.1.0,<3.0.0', 'httplib2>=0.8,<0.23.0', - 'js2py>=0.74,<1', Review Comment: we can simplify it via an environmental marker: https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#platform-specific-dependencies -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [yaml] disable javascript mapping for python >=3.12 [beam]
github-actions[bot] commented on PR #30843: URL: https://github.com/apache/beam/pull/30843#issuecomment-2035658923 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Proposed edits for Beam YAML overview [beam]
rszper commented on code in PR #30842: URL: https://github.com/apache/beam/pull/30842#discussion_r1550546970 ## website/www/site/content/en/documentation/sdks/yaml.md: ## @@ -23,80 +23,132 @@ title: "Apache Beam YAML API" # Beam YAML API -While Beam provides powerful APIs for authoring sophisticated data -processing pipelines, it often still has too high a barrier for -getting started and authoring simple pipelines. Even setting up the -environment, installing the dependencies, and setting up the project -can be an overwhelming amount of boilerplate for some (though -https://beam.apache.org/blog/beam-starter-projects/ has gone a long -way in making this easier). - -Here we provide a simple declarative syntax for describing pipelines -that does not require coding experience or learning how to use an -SDKany text editor will do. -Some installation may be required to actually *execute* a pipeline, but -we envision various services (such as Dataflow) to accept yaml pipelines -directly obviating the need for even that in the future. -We also anticipate the ability to generate code directly from these -higher-level yaml descriptions, should one want to graduate to a full -Beam SDK (and possibly the other direction as well as far as possible). - -Though we intend this syntax to be easily authored (and read) directly by -humans, this may also prove a useful intermediate representation for -tools to use as well, either as output (e.g. a pipeline authoring GUI) -or consumption (e.g. a lineage analysis tool) and expect it to be more -easily manipulated and semantically meaningful than the Beam protos -themselves (which concern themselves more with execution). - -It should be noted that everything here is still under development, but any -features already included are considered stable. Feedback is welcome at -d...@apache.beam.org. - -## Running pipelines - -The Beam yaml parser is currently included as part of the Apache Beam Python SDK. -This can be installed (e.g. within a virtual environment) as +Beam YAML is a declarative syntax for describing Apache Beam pipelines by using +YAML files. You can use Beam YAML to author and run a Beam pipeline without +writing any code. + +## Overview + +Beam provides a powerful model for creating sophisticated data processing +pipelines. However, getting started with Beam programming can be challenging +because it requires writing code in one of the supported Beam SDK languages. +You need to understand the APIs, set up a project, manage dependencies, and +perform other programming tasks. + +Beam YAML makes it easier to get started with creating Beam pipelines. Instead Review Comment: If possible, I would find a way to make this the first paragraph in the overview so that we start by listing the benefits of Beam YAML instead of the challenges of normal Beam. That might require some rewriting, though, so just a suggestion. Feel free to ignore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [yaml] disable javascript mapping for python >=3.12 [beam]
Polber commented on PR #30843: URL: https://github.com/apache/beam/pull/30843#issuecomment-2035656569 R: @robertwb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [yaml] disable javascript mapping for python >=3.12 [beam]
Polber commented on PR #30843: URL: https://github.com/apache/beam/pull/30843#issuecomment-2035656431 R: @tvalentyn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [yaml] disable javascript mapping for python >=3.12 [beam]
Polber opened a new pull request, #30843: URL: https://github.com/apache/beam/pull/30843 js2py is not supported in Python 3.12, so to prevent future issues arising from Beam Python 3.12 support, this js2py import is being excluded for Beam installs starting with Python 3.12 and the feature will throw error if the package does not exist. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #` instead. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Failing Test]: JS2PY not supporting Python 3.12 [beam]
Polber commented on issue #30829: URL: https://github.com/apache/beam/issues/30829#issuecomment-2035656102 That makes sense to me. I added that logic in: https://github.com/apache/beam/pull/30843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Proposed edits for Beam YAML overview [beam]
github-actions[bot] commented on PR #30842: URL: https://github.com/apache/beam/pull/30842#issuecomment-2035636272 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @rszper for label website. Available commands: - `stop reviewer notifications` - opt out of the automated review tooling - `remind me after tests pass` - tag the comment author after tests pass - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers) The PR bot will only process comments in the main thread (not review comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [yaml] add --providers and --providers_file flags [beam]
robertwb commented on PR #30835: URL: https://github.com/apache/beam/pull/30835#issuecomment-2035551764 Rather than passing these via a side channel, could we reference the eternal provider definitions file in the yaml itself? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Proposed edits for Beam YAML overview [beam]
VeronicaWasson opened a new pull request, #30842: URL: https://github.com/apache/beam/pull/30842 Makes the following changes - Organize into several main sections - Make the "Getting Started" section more procedural. - Use a self-contained pipeline for Getting Started. (No input data files required) - Add explanatory text to motivate the example YAMLs - General style edits Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #` instead. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Feature Request]: Support for Apache Flink 1.18 in Beam Runners [beam]
tandelDipak commented on issue #30789: URL: https://github.com/apache/beam/issues/30789#issuecomment-2035503924 + for this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Python] Add a couple quality-of-life improvemenets to `testing.util.assert_that` [beam]
hjtran commented on PR #30771:
URL: https://github.com/apache/beam/pull/30771#issuecomment-2035477245
Gah, I have no idea where this failure couldve come from:
```
run()
File
"/runner/_work/beam/beam/sdks/python/test-suites/tox/py38/build/srcs/sdks/python/target/.tox-py38-tft-113/py38-tft-113/lib/python3.8/site-packages/hypothesis/entry_points.py",
line 35, in run
hook = entry.load()
File
"/runner/_work/beam/beam/sdks/python/test-suites/tox/py38/build/srcs/sdks/python/target/.tox-py38-tft-113/py38-tft-113/lib/python3.8/site-packages/setuptools/_vendor/importlib_metadata/__init__.py",
line 208, in load
module = import_module(match.group('module'))
File
"/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/importlib/__init__.py",
line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
ModuleNotFoundError: No module named 'pydantic._hypothesis_plugin'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] [Bug]: Beam Sql is ignoring aliases fields in some situations which causes to huge data loss [beam]
brachipa commented on issue #30498: URL: https://github.com/apache/beam/issues/30498#issuecomment-2035444619 It looks more like a bug, I tried to debug it and all the time I see the alias until it dropped at some unknown point. Which I couldn't identify. In the examples above, same query, behaves differently, depends on the columns exist in the schema. Regarding the workaround, I wonder what will be the impact on the cpu utilization, we have huge scale and many different queries Also, this workaround applied on this specific query, and we have many different queries provided by different teams, It doesn't scale to examine each query case and try find workaround for any query for any change. ( Even working query can break by some minor change) I hope this can be addressed and fixed. I will be happy to help. But need some hints where to be focused since I couldn't find it myself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug]: KafkaIO should assign partitions uniformly. [beam]
damnMeddlingKid closed issue #30834: [Bug]: KafkaIO should assign partitions uniformly. URL: https://github.com/apache/beam/issues/30834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Failing Test]: JS2PY not supporting Python 3.12 [beam]
tvalentyn commented on issue #30829: URL: https://github.com/apache/beam/issues/30829#issuecomment-2035173381 > I see no reason in disabling the feature for the time being Ok. we could not install the dependency for certain Python versions by adding a version guard, and change the YAML functionality to support Javascript UDF if the necessary libraries are imported. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] White space Fix log and error messages [beam]
Abacn merged PR #30804: URL: https://github.com/apache/beam/pull/30804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] White space Fix log and error messages [beam]
Abacn commented on PR #30804: URL: https://github.com/apache/beam/pull/30804#issuecomment-2035135775 assign set of reviewers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] White space Fix log and error messages [beam]
github-actions[bot] commented on PR #30804: URL: https://github.com/apache/beam/pull/30804#issuecomment-2035138084 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @kennknowles for label java. R: @ahmedabu98 for label io. R: @svetakvsundhar for label healthcare. Available commands: - `stop reviewer notifications` - opt out of the automated review tooling - `remind me after tests pass` - tag the comment author after tests pass - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers) The PR bot will only process comments in the main thread (not review comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add back Avro 1.8.2 to test [beam]
Abacn merged PR #30833: URL: https://github.com/apache/beam/pull/30833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump pillow from 10.2.0 to 10.3.0 in /sdks/python/apache_beam/examples/ml-orchestration/kfp/components/train [beam]
github-actions[bot] commented on PR #30840: URL: https://github.com/apache/beam/pull/30840#issuecomment-2035132133 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @liferoad for label python. Available commands: - `stop reviewer notifications` - opt out of the automated review tooling - `remind me after tests pass` - tag the comment author after tests pass - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers) The PR bot will only process comments in the main thread (not review comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump pillow from 10.2.0 to 10.3.0 in /sdks/python/apache_beam/examples/ml-orchestration/kfp/components/preprocessing [beam]
github-actions[bot] commented on PR #30841: URL: https://github.com/apache/beam/pull/30841#issuecomment-2035132037 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add patch release docs [beam]
damccorm merged PR #30838: URL: https://github.com/apache/beam/pull/30838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Patch release website changes [beam]
github-actions[bot] commented on PR #30839: URL: https://github.com/apache/beam/pull/30839#issuecomment-2035077090 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @kennknowles for label website. Available commands: - `stop reviewer notifications` - opt out of the automated review tooling - `remind me after tests pass` - tag the comment author after tests pass - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers) The PR bot will only process comments in the main thread (not review comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump pillow from 10.2.0 to 10.3.0 in /sdks/python/apache_beam/examples/ml-orchestration/kfp/components/preprocessing [beam]
dependabot[bot] opened a new pull request, #30841: URL: https://github.com/apache/beam/pull/30841 Bumps [pillow](https://github.com/python-pillow/Pillow) from 10.2.0 to 10.3.0. Release notes Sourced from https://github.com/python-pillow/Pillow/releases;>pillow's releases. 10.3.0 https://pillow.readthedocs.io/en/stable/releasenotes/10.3.0.html;>https://pillow.readthedocs.io/en/stable/releasenotes/10.3.0.html Changes CVE-2024-28219: Use strncpy to avoid buffer overflow https://redirect.github.com/python-pillow/Pillow/issues/7928;>#7928 [https://github.com/hugovk;>@hugovk] Use functools.lru_cache for hopper() https://redirect.github.com/python-pillow/Pillow/issues/7912;>#7912 [https://github.com/hugovk;>@hugovk] Raise ValueError if seeking to greater than offset-sized integer in TIFF https://redirect.github.com/python-pillow/Pillow/issues/7883;>#7883 [https://github.com/radarhere;>@radarhere] Improve speed of loading QOI images https://redirect.github.com/python-pillow/Pillow/issues/7925;>#7925 [https://github.com/radarhere;>@radarhere] Added RGB to I;16N conversion https://redirect.github.com/python-pillow/Pillow/issues/7920;>#7920 [https://github.com/radarhere;>@radarhere] Add --report argument to main.py to omit supported formats https://redirect.github.com/python-pillow/Pillow/issues/7818;>#7818 [https://github.com/nulano;>@nulano] Added RGB to I;16, I;16L and I;16B conversion https://redirect.github.com/python-pillow/Pillow/issues/7918;>#7918 [https://github.com/radarhere;>@radarhere] Fix editable installation with custom build backend and configuration options https://redirect.github.com/python-pillow/Pillow/issues/7658;>#7658 [https://github.com/nulano;>@nulano] Fix putdata() for I;16N on big-endian https://redirect.github.com/python-pillow/Pillow/issues/7209;>#7209 [https://github.com/Yay295;>@Yay295] Determine MPO size from markers, not EXIF data https://redirect.github.com/python-pillow/Pillow/issues/7884;>#7884 [https://github.com/radarhere;>@radarhere] Improved conversion from RGB to RGBa, LA and La https://redirect.github.com/python-pillow/Pillow/issues/7888;>#7888 [https://github.com/radarhere;>@radarhere] Support FITS images with GZIP_1 compression https://redirect.github.com/python-pillow/Pillow/issues/7894;>#7894 [https://github.com/radarhere;>@radarhere] Use I;16 mode for 9-bit JPEG 2000 images https://redirect.github.com/python-pillow/Pillow/issues/7900;>#7900 [https://github.com/scaramallion;>@scaramallion] Raise ValueError if kmeans is negative https://redirect.github.com/python-pillow/Pillow/issues/7891;>#7891 [https://github.com/radarhere;>@radarhere] Remove TIFF tag OSUBFILETYPE when saving using libtiff https://redirect.github.com/python-pillow/Pillow/issues/7893;>#7893 [https://github.com/radarhere;>@radarhere] Raise ValueError for negative values when loading P1-P3 PPM images https://redirect.github.com/python-pillow/Pillow/issues/7882;>#7882 [https://github.com/radarhere;>@radarhere] Added reading of JPEG2000 palettes https://redirect.github.com/python-pillow/Pillow/issues/7870;>#7870 [https://github.com/radarhere;>@radarhere] Added alpha_quality argument when saving WebP images https://redirect.github.com/python-pillow/Pillow/issues/7872;>#7872 [https://github.com/radarhere;>@radarhere] Fixed joined corners for ImageDraw rounded_rectangle() non-integer dimensions https://redirect.github.com/python-pillow/Pillow/issues/7881;>#7881 [https://github.com/radarhere;>@radarhere] Removed Python and NumPy pinning on Cygwin https://redirect.github.com/python-pillow/Pillow/issues/7880;>#7880 [https://github.com/radarhere;>@radarhere] Update UnidentifiedImageError and version imports https://redirect.github.com/python-pillow/Pillow/issues/7644;>#7644 [https://github.com/radarhere;>@radarhere] Stop reading EPS image at EOF marker https://redirect.github.com/python-pillow/Pillow/issues/7753;>#7753 [https://github.com/radarhere;>@radarhere] PSD layer co-ordinates may be negative https://redirect.github.com/python-pillow/Pillow/issues/7706;>#7706 [https://github.com/radarhere;>@radarhere] Use subprocess with CREATE_NO_WINDOW flag in ImageShow WindowsViewer https://redirect.github.com/python-pillow/Pillow/issues/7791;>#7791 [https://github.com/radarhere;>@radarhere] When saving GIF frame that restores to background color, do not fill identical pixels https://redirect.github.com/python-pillow/Pillow/issues/7788;>#7788 [https://github.com/radarhere;>@radarhere] Fixed reading PNG iCCP compression method https://redirect.github.com/python-pillow/Pillow/issues/7823;>#7823 [https://github.com/radarhere;>@radarhere] Allow writing IFDRational to UNDEFINED tag https://redirect.github.com/python-pillow/Pillow/issues/7840;>#7840 [https://github.com/radarhere;>@radarhere] Fix logged tag name when loading Exif data
[PR] Bump pillow from 10.2.0 to 10.3.0 in /sdks/python/apache_beam/examples/ml-orchestration/kfp/components/train [beam]
dependabot[bot] opened a new pull request, #30840: URL: https://github.com/apache/beam/pull/30840 Bumps [pillow](https://github.com/python-pillow/Pillow) from 10.2.0 to 10.3.0. Release notes Sourced from https://github.com/python-pillow/Pillow/releases;>pillow's releases. 10.3.0 https://pillow.readthedocs.io/en/stable/releasenotes/10.3.0.html;>https://pillow.readthedocs.io/en/stable/releasenotes/10.3.0.html Changes CVE-2024-28219: Use strncpy to avoid buffer overflow https://redirect.github.com/python-pillow/Pillow/issues/7928;>#7928 [https://github.com/hugovk;>@hugovk] Use functools.lru_cache for hopper() https://redirect.github.com/python-pillow/Pillow/issues/7912;>#7912 [https://github.com/hugovk;>@hugovk] Raise ValueError if seeking to greater than offset-sized integer in TIFF https://redirect.github.com/python-pillow/Pillow/issues/7883;>#7883 [https://github.com/radarhere;>@radarhere] Improve speed of loading QOI images https://redirect.github.com/python-pillow/Pillow/issues/7925;>#7925 [https://github.com/radarhere;>@radarhere] Added RGB to I;16N conversion https://redirect.github.com/python-pillow/Pillow/issues/7920;>#7920 [https://github.com/radarhere;>@radarhere] Add --report argument to main.py to omit supported formats https://redirect.github.com/python-pillow/Pillow/issues/7818;>#7818 [https://github.com/nulano;>@nulano] Added RGB to I;16, I;16L and I;16B conversion https://redirect.github.com/python-pillow/Pillow/issues/7918;>#7918 [https://github.com/radarhere;>@radarhere] Fix editable installation with custom build backend and configuration options https://redirect.github.com/python-pillow/Pillow/issues/7658;>#7658 [https://github.com/nulano;>@nulano] Fix putdata() for I;16N on big-endian https://redirect.github.com/python-pillow/Pillow/issues/7209;>#7209 [https://github.com/Yay295;>@Yay295] Determine MPO size from markers, not EXIF data https://redirect.github.com/python-pillow/Pillow/issues/7884;>#7884 [https://github.com/radarhere;>@radarhere] Improved conversion from RGB to RGBa, LA and La https://redirect.github.com/python-pillow/Pillow/issues/7888;>#7888 [https://github.com/radarhere;>@radarhere] Support FITS images with GZIP_1 compression https://redirect.github.com/python-pillow/Pillow/issues/7894;>#7894 [https://github.com/radarhere;>@radarhere] Use I;16 mode for 9-bit JPEG 2000 images https://redirect.github.com/python-pillow/Pillow/issues/7900;>#7900 [https://github.com/scaramallion;>@scaramallion] Raise ValueError if kmeans is negative https://redirect.github.com/python-pillow/Pillow/issues/7891;>#7891 [https://github.com/radarhere;>@radarhere] Remove TIFF tag OSUBFILETYPE when saving using libtiff https://redirect.github.com/python-pillow/Pillow/issues/7893;>#7893 [https://github.com/radarhere;>@radarhere] Raise ValueError for negative values when loading P1-P3 PPM images https://redirect.github.com/python-pillow/Pillow/issues/7882;>#7882 [https://github.com/radarhere;>@radarhere] Added reading of JPEG2000 palettes https://redirect.github.com/python-pillow/Pillow/issues/7870;>#7870 [https://github.com/radarhere;>@radarhere] Added alpha_quality argument when saving WebP images https://redirect.github.com/python-pillow/Pillow/issues/7872;>#7872 [https://github.com/radarhere;>@radarhere] Fixed joined corners for ImageDraw rounded_rectangle() non-integer dimensions https://redirect.github.com/python-pillow/Pillow/issues/7881;>#7881 [https://github.com/radarhere;>@radarhere] Removed Python and NumPy pinning on Cygwin https://redirect.github.com/python-pillow/Pillow/issues/7880;>#7880 [https://github.com/radarhere;>@radarhere] Update UnidentifiedImageError and version imports https://redirect.github.com/python-pillow/Pillow/issues/7644;>#7644 [https://github.com/radarhere;>@radarhere] Stop reading EPS image at EOF marker https://redirect.github.com/python-pillow/Pillow/issues/7753;>#7753 [https://github.com/radarhere;>@radarhere] PSD layer co-ordinates may be negative https://redirect.github.com/python-pillow/Pillow/issues/7706;>#7706 [https://github.com/radarhere;>@radarhere] Use subprocess with CREATE_NO_WINDOW flag in ImageShow WindowsViewer https://redirect.github.com/python-pillow/Pillow/issues/7791;>#7791 [https://github.com/radarhere;>@radarhere] When saving GIF frame that restores to background color, do not fill identical pixels https://redirect.github.com/python-pillow/Pillow/issues/7788;>#7788 [https://github.com/radarhere;>@radarhere] Fixed reading PNG iCCP compression method https://redirect.github.com/python-pillow/Pillow/issues/7823;>#7823 [https://github.com/radarhere;>@radarhere] Allow writing IFDRational to UNDEFINED tag https://redirect.github.com/python-pillow/Pillow/issues/7840;>#7840 [https://github.com/radarhere;>@radarhere] Fix logged tag name when loading Exif data
Re: [PR] Add /job/cancel endpoint to prism web server. [beam]
damondouglas commented on PR #30825: URL: https://github.com/apache/beam/pull/30825#issuecomment-2035024805 assign to next reviewer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Patch release website changes [beam]
damccorm opened a new pull request, #30839: URL: https://github.com/apache/beam/pull/30839 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #` instead. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add patch release docs [beam]
github-actions[bot] commented on PR #30838: URL: https://github.com/apache/beam/pull/30838#issuecomment-2034957562 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add patch release docs [beam]
damccorm commented on PR #30838: URL: https://github.com/apache/beam/pull/30838#issuecomment-2034952985 R: @liferoad @Abacn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add patch release docs [beam]
damccorm opened a new pull request, #30838: URL: https://github.com/apache/beam/pull/30838 Add documentation on performing a patch release Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #` instead. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Python] Add a couple quality-of-life improvemenets to `testing.util.assert_that` [beam]
github-actions[bot] commented on PR #30771: URL: https://github.com/apache/beam/pull/30771#issuecomment-2034942761 R: @jrmccluskey for final approval -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Implement ordered list state for FnApi. [beam]
Abacn commented on PR #30317: URL: https://github.com/apache/beam/pull/30317#issuecomment-2034822148 waiting on author -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Python] Add a couple quality-of-life improvemenets to `testing.util.assert_that` [beam]
hjtran commented on PR #30771: URL: https://github.com/apache/beam/pull/30771#issuecomment-2034614236 The last commit failed with some weird pydantic/hypothesis errors that seem unrelated to these changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] added custom watermark for kinesis reader [beam]
github-actions[bot] commented on PR #28763: URL: https://github.com/apache/beam/pull/28763#issuecomment-2034415989 Reminder, please take a look at this pr: @robertwb @damondouglas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Implement ordered list state for FnApi. [beam]
github-actions[bot] commented on PR #30317: URL: https://github.com/apache/beam/pull/30317#issuecomment-2034415747 Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`: R: @Abacn for label java. Available commands: - `stop reviewer notifications` - opt out of the automated review tooling - `remind me after tests pass` - tag the comment author after tests pass - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] replace clock.milliseconds with stopwatch [beam]
github-actions[bot] commented on PR #30678: URL: https://github.com/apache/beam/pull/30678#issuecomment-2034415691 Reminder, please take a look at this pr: @damccorm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Call `DateTime(long)` instead of `DateTime(Object)`. [beam]
github-actions[bot] commented on PR #30758: URL: https://github.com/apache/beam/pull/30758#issuecomment-2034415673 Reminder, please take a look at this pr: @shunping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Flink] Speed up file write in batch mode by using larger bundle size [beam]
github-actions[bot] commented on PR #30802: URL: https://github.com/apache/beam/pull/30802#issuecomment-2034336637 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @chamikaramj added as fallback since no labels match configuration Available commands: - `stop reviewer notifications` - opt out of the automated review tooling - `remind me after tests pass` - tag the comment author after tests pass - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers) The PR bot will only process comments in the main thread (not review comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug]: Messages are not ACK on Pubsub starting Beam 2.52.0 on Flink Runner in detached mode [beam]
jto commented on issue #29902: URL: https://github.com/apache/beam/issues/29902#issuecomment-2033986698 Hey there! Apologies for not looking into this earlier. I was on parental leave and had a lot to catch up when I got back. I think this issue and https://github.com/apache/beam/issues/30539 are duplicates. Taking a look now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Feature Request]: Support for Apache Flink 1.18 in Beam Runners [beam]
BohdanBilonoh commented on issue #30789: URL: https://github.com/apache/beam/issues/30789#issuecomment-2033916133 +1 for this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
