[GitHub] [beam] Hannah-Jiang commented on a change in pull request #11584: [BEAM-9136]support isRelease tag for docker build command & update release guide
Hannah-Jiang commented on a change in pull request #11584:
URL: https://github.com/apache/beam/pull/11584#discussion_r418766264
##
File path: website/src/contribute/release-guide.md
##
@@ -688,8 +688,20 @@ Verify that files are
[present](https://dist.apache.org/repos/dist/dev/beam).
* Build Python images and push to DockerHub.
```
-./gradlew :sdks:python:container:buildAll -Pdocker-tag=${RELEASE}_rc{RC_NUM}
+./gradlew :sdks:python:container:buildAll -Pdocker-pull-licenses
-Pdocker-tag=${RELEASE}_rc{RC_NUM}
+```
+
+Verify that third party licenses are included by logging in to the images. For
Python SDK images, there should be around 80 ~ 100 dependencies.
+Please note that dependencies for the SDKs with different Python versions
vary.
+Need to verify all Python images by replacing `${ver}` in the following
command to `python2.7, python3.5, python3.6, python3.7`.
Review comment:
@ibzib , this part should be verified BEFORE pushing Python images. I'm
not sure when this PR can be merged because of website issues, so explicitly
pinging you here.
##
File path: website/src/contribute/release-guide.md
##
@@ -699,7 +711,18 @@ done
* Build Java images and push to DockerHub.
```
-./gradlew :sdks:java:container:dockerPush -Pdocker-pull-licenses
-Pdocker-tag=${RELEASE}_rc{RC_NUM}
+./gradlew :sdks:java:container:docker -Pdocker-pull-licenses
-Pdocker-tag=${RELEASE}_rc{RC_NUM}
+```
+
+Verify that third party licenses are included by logging in to the images. For
Java SDK images, there should be around 1400 dependencies.
+```
+docker run -it --entrypoint=/bin/bash
apache/beam_java_sdk:${RELEASE}_rc{RC_NUM}
+ls -al /opt/apache/beam/third_party_licenses/ | wc -l
+```
+
+After verifying the third party licenses are included correctly, push the
images to DockerHub.
+```
Review comment:
@ibzib , this part changed slightly. Please note the change from
`dockerPush` to `docker` at L714.
After creating the Java image, we should verify it BEFORE pushing to
DockerHub. I'm not sure when this PR can be merged because of website issues,
so explicitly pinging you here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [beam] Hannah-Jiang commented on a change in pull request #11584: [BEAM-9136]support isRelease tag for docker build command & update release guide
Hannah-Jiang commented on a change in pull request #11584:
URL: https://github.com/apache/beam/pull/11584#discussion_r418278914
##
File path: sdks/python/container/py2/build.gradle
##
@@ -66,7 +66,8 @@ docker {
project.rootProject["docker-tag"] : project.sdk_version)
files "../Dockerfile", "./build"
buildArgs(['py_version': "2.7",
- 'pull_licenses':
project.rootProject.hasProperty(["docker-pull-licenses"])])
+ 'pull_licenses':
project.rootProject.hasProperty(["docker-pull-licenses"]) ||
+ project.rootProject.hasProperty(["isRelease"])])
Review comment:
Currently, the `isRelease` tag needs to be passed with commands.
Ideally, this tag should be set by checking branch name.
Detecting `isRelease` for docker image build is not that helpful for now,
but could be used when we support auto setting `isRelease` tag.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [beam] Hannah-Jiang commented on a change in pull request #11584: [BEAM-9136]support isRelease tag for docker build command & update release guide
Hannah-Jiang commented on a change in pull request #11584:
URL: https://github.com/apache/beam/pull/11584#discussion_r418278914
##
File path: sdks/python/container/py2/build.gradle
##
@@ -66,7 +66,8 @@ docker {
project.rootProject["docker-tag"] : project.sdk_version)
files "../Dockerfile", "./build"
buildArgs(['py_version': "2.7",
- 'pull_licenses':
project.rootProject.hasProperty(["docker-pull-licenses"])])
+ 'pull_licenses':
project.rootProject.hasProperty(["docker-pull-licenses"]) ||
+ project.rootProject.hasProperty(["isRelease"])])
Review comment:
Currently, the `isRelease` tag needs to be passed with commands.
Ideally, this tag should be set by checking branch name.
Adding this support to docker images are not that helpful for now, but could
be used when we support auto setting `isRelease` tag.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
