[GitHub] [beam] Hannah-Jiang commented on pull request #11551: Cherrypick to release-2.21.0

2020-05-01 Thread GitBox


Hannah-Jiang commented on pull request #11551:
URL: https://github.com/apache/beam/pull/11551#issuecomment-622595455


   > @Hannah-Jiang I'm not sure what, if anything really needs to be 
cherry-picked here. Java licenses were already cherry-picked in #11421, and the 
remainder of the changes are just usability improvements if I understand 
correctly. As long as licenses are present in the release images, I think we 
should be fine. WDYT?
   
   Yes, this is a great idea. That PR functions well and this cherry pick is 
mainly for improvement. I tried to create images from release branch, and they 
look good. Please feel free to skip this PR.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [beam] Hannah-Jiang commented on pull request #11551: Cherrypick to release-2.21.0

2020-04-30 Thread GitBox


Hannah-Jiang commented on pull request #11551:
URL: https://github.com/apache/beam/pull/11551#issuecomment-622171222


   The Python Precommit failed with Dataflow tests. If I remember it correctly, 
new SDK workers should be created to pass tests against release branch.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org