[GitHub] [beam] aaltay commented on pull request #12304: [BEAM-10499] Adds a descriptive toString to SamzaRunner KeyedTimerData

2020-08-03 Thread GitBox 


aaltay commented on pull request #12304:
URL: https://github.com/apache/beam/pull/12304#issuecomment-668292310


   Merging. @kennknowles @xinyuiscool - if you have additional comments please 
fix it with a new pr.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] aaltay commented on pull request #12304: [BEAM-10499] Adds a descriptive toString to SamzaRunner KeyedTimerData

2020-07-30 Thread GitBox 


aaltay commented on pull request #12304:
URL: https://github.com/apache/beam/pull/12304#issuecomment-666768573


   Change LGTM. Could you rebase?
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org