[GitHub] [beam] chamikaramj commented on pull request #12880: [BEAM-10933] Adjust GBK and Flatten types before creating the pipeline proto

2020-09-21 Thread GitBox 


chamikaramj commented on pull request #12880:
URL: https://github.com/apache/beam/pull/12880#issuecomment-696230350







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] chamikaramj commented on pull request #12880: [BEAM-10933] Adjust GBK and Flatten types before creating the pipeline proto

2020-09-21 Thread GitBox 


chamikaramj commented on pull request #12880:
URL: https://github.com/apache/beam/pull/12880#issuecomment-696251401


   Moved the Flatten change back and added a comment about Runner v2. PTAL.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] chamikaramj commented on pull request #12880: [BEAM-10933] Adjust GBK and Flatten types before creating the pipeline proto

2020-09-21 Thread GitBox 


chamikaramj commented on pull request #12880:
URL: https://github.com/apache/beam/pull/12880#issuecomment-696230350


   I see. I just moved Flatten update out of caution. I was not hitting this in 
any tests.
   
   GBK update seems to be needed though. I was hitting this in 
test_gbk_side_input (where we were failing while try to determine the coder for 
native shuffle reader). 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org