ibzib commented on a change in pull request #11593:
URL: https://github.com/apache/beam/pull/11593#discussion_r418781167
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -345,7 +345,7 @@ def visit_transform(self, transform_node):
for ix, side_input in enumerate(transform_node.side_inputs):
access_pattern = side_input._side_input_data().access_pattern
if access_pattern == common_urns.side_inputs.ITERABLE.urn:
- if use_unified_worker:
+ if use_unified_worker or not use_fn_api:
Review comment:
So `side_input.pvalue.element_type = typehints.Any` is a side effect and
`new_side_input = _DataflowIterableSideInput(side_input)` has no effect?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
