[GitHub] [beam] ibzib commented on a change in pull request #12576: [BEAM-10671] Add environment configuration fields as first-class pipeline options.

[GitBox]

ibzib commented on a change in pull request #12576:
URL: https://github.com/apache/beam/pull/12576#discussion_r491073811



##
File path: sdks/python/apache_beam/options/pipeline_options_validator_test.py
##
@@ -613,31 +615,29 @@ def test_environment_options(self):
 {
 'options': [
 '--environment_type=pRoCeSs',
-'--env_process_command=foo',
+'--environment_options=process_command=foo',
 '--environment_config=foo'
 ],
 'errors': ['environment_config']
 },
 {
 'options': [
 '--environment_type=pRoCeSs',
-'--env_process_command=foo',
-'--env_process_variables=foo=bar',
-'--env_docker_container_image=foo',
-'--env_external_service_address=foo'
+'--environment_options=process_command=foo',
+'--environment_options=process_variables=foo=bar',
+'--environment_options=docker_container_image=foo',
+'--environment_options=external_service_address=foo'

Review comment:
   I want to keep the prefix as a hint for users. This way it is 
immediately obvious which environment type each option corresponds to. 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] ibzib commented on a change in pull request #12576: [BEAM-10671] Add environment configuration fields as first-class pipeline options.

[GitBox]

ibzib commented on a change in pull request #12576:
URL: https://github.com/apache/beam/pull/12576#discussion_r488839465



##
File path: sdks/python/apache_beam/options/pipeline_options.py
##
@@ -1044,7 +1044,12 @@ def _add_argparse_args(cls, parser):
 'form {"os": "", "arch": "", "command": '
 '"", "env":{"": '
 '""} }. All fields in the json are optional except '
-'command.'))
+'command.\n\nPlease consider using the following '
+'options instead, depending on the environment type:\n'
+' --docker_env_container_image\n'
+' --process_env_command\n'
+' --process_env_variables\n'
+' --external_env_service_address'))

Review comment:
   Done.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org