[GitHub] [beam] ibzib commented on pull request #11492: [BEAM-9801] Pass in fire timestamp to timer callback
ibzib commented on pull request #11492: URL: https://github.com/apache/beam/pull/11492#issuecomment-622576973 Flakes are BEAM-9767 and BEAM-8912. I'm going to merge this so we can go ahead with the release. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [beam] ibzib commented on pull request #11492: [BEAM-9801] Pass in fire timestamp to timer callback
ibzib commented on pull request #11492: URL: https://github.com/apache/beam/pull/11492#issuecomment-622081746 > I still need to take a look at the failing test in https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Commit/4434/ Do you mean that it's related to this PR, or it's not, or you don't know? I'm inclined to say the failure isn't related to these changes, since no tests visibly fail (Python prints `OK (skipped=16)`), like my comment [here](https://issues.apache.org/jira/browse/BEAM-8912?focusedCommentId=16990196=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16990196). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [beam] ibzib commented on pull request #11492: [BEAM-9801] Pass in fire timestamp to timer callback
ibzib commented on pull request #11492: URL: https://github.com/apache/beam/pull/11492#issuecomment-621557824 Python Flink PVR failures are tracked here: [BEAM-8912](https://issues.apache.org/jira/browse/BEAM-8912) On the other hand, the 304 failures in the precommit definitely seem like a legit issue. @mxm PTAL This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [beam] ibzib commented on pull request #11492: [BEAM-9801] Pass in fire timestamp to timer callback
ibzib commented on pull request #11492: URL: https://github.com/apache/beam/pull/11492#issuecomment-620704953 It looks to me like the remaining failures are merely flakes. @boyuanzz PTAL This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
