[GitHub] [beam] iemejia commented on pull request #11715: [BEAM-9977] Implement GrowableOffsetRangeTracker

2020-05-21 Thread GitBox 


iemejia commented on pull request #11715:
URL: https://github.com/apache/beam/pull/11715#issuecomment-632434300


   Thanks for answering and for the clear explaination @boyuanzz 
   
   I would have tended towards having the additional complexity in 
`OffsetRangeTracker` just because it is the de-facto reference, but I 
understand the different preference.
   
   Nice to see this an the Kafka SDF happening, congrats!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] iemejia commented on pull request #11715: [BEAM-9977] Implement GrowableOffsetRangeTracker

2020-05-21 Thread GitBox 


iemejia commented on pull request #11715:
URL: https://github.com/apache/beam/pull/11715#issuecomment-632402839


   Now that this is merged. Can I ask a question. What is the intrinsic 
limitation that did not allow old `OffsetRangeTracker` to be refactored for 
this use case? or why we want to have both?
   
   Does this mean also that we might need `GrowableBytekeyRangeTracker` and 
basically 'dynamic' versions for every `RestrictionTracker` ?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org