[GitHub] [beam] kennknowles commented on pull request #12825: [BEAM-9399] Change DataflowWorkerLoggingHandler to report errors to t…

2020-09-14 Thread GitBox 


kennknowles commented on pull request #12825:
URL: https://github.com/apache/beam/pull/12825#issuecomment-692268316


   Had a chat and we confirmed that the worker logging setup already handles my 
concern appropriately. Please disregard all comments.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] kennknowles commented on pull request #12825: [BEAM-9399] Change DataflowWorkerLoggingHandler to report errors to t…

2020-09-14 Thread GitBox 


kennknowles commented on pull request #12825:
URL: https://github.com/apache/beam/pull/12825#issuecomment-692236055


   @lukecwik that is how I feel about System.err as well. Java disagrees and 
writes all logs to stderr unless you disconnect that. IIRC I discovered through 
some other work that it is not disconnected here.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] kennknowles commented on pull request #12825: [BEAM-9399] Change DataflowWorkerLoggingHandler to report errors to t…

2020-09-12 Thread GitBox 


kennknowles commented on pull request #12825:
URL: https://github.com/apache/beam/pull/12825#issuecomment-691258077







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] kennknowles commented on pull request #12825: [BEAM-9399] Change DataflowWorkerLoggingHandler to report errors to t…

2020-09-12 Thread GitBox 


kennknowles commented on pull request #12825:
URL: https://github.com/apache/beam/pull/12825#issuecomment-691258077







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] kennknowles commented on pull request #12825: [BEAM-9399] Change DataflowWorkerLoggingHandler to report errors to t…

2020-09-11 Thread GitBox 


kennknowles commented on pull request #12825:
URL: https://github.com/apache/beam/pull/12825#issuecomment-691258077


   I believe the trouble here is that it mixes all log levels on stderr, while 
the log reporting in the UI reports all stderr lines at the same severity. I 
cannot recall if they are all INFO or all WARN in the UI, but either way it is 
incorrect and confusing. So we need the corresponding change to make sure that 
doesn't happen. Just drive by comment because I've encountered this.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org