[GitHub] [beam] lukecwik commented on pull request #12616: [BEAM-10670] Update Jet to be opt-out for SplittableDoFn powering the Read transform.

2020-09-14 Thread GitBox 


lukecwik commented on pull request #12616:
URL: https://github.com/apache/beam/pull/12616#issuecomment-692196137


   > What kind of test coverage is there for these transform replacements on 
the Jet runner?
   
   The `@ValidatesRunner` junit category gives us coverage. The 
`@ValidatesRunner` tests within 
https://github.com/apache/beam/blob/master/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/SplittableDoFnTest.java
 are comprehensive for this feature but Jet can't support them all due to lack 
of features and or/bugs (e.g. support for bundle finalization, assuming byte[] 
is equals comparable, ...).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] lukecwik commented on pull request #12616: [BEAM-10670] Update Jet to be opt-out for SplittableDoFn powering the Read transform.

2020-09-10 Thread GitBox 


lukecwik commented on pull request #12616:
URL: https://github.com/apache/beam/pull/12616#issuecomment-690739360


   R: @tysonjh 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] lukecwik commented on pull request #12616: [BEAM-10670] Update Jet to be opt-out for SplittableDoFn powering the Read transform.

2020-09-10 Thread GitBox 


lukecwik commented on pull request #12616:
URL: https://github.com/apache/beam/pull/12616#issuecomment-690739301


   Run Jet ValidatesRunner



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org