[GitHub] [beam] lukecwik commented on pull request #12825: [BEAM-9399] Change DataflowWorkerLoggingHandler to report errors to t…
lukecwik commented on pull request #12825: URL: https://github.com/apache/beam/pull/12825#issuecomment-702944699 We can leave as is since the migration to using the Java SDK harness is upcoming and the Java SDK harness doesn't override system.out/system.err due to the long list of issues we have hit with this override to capture system.out/system.err logs in Dataflow. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #12825: [BEAM-9399] Change DataflowWorkerLoggingHandler to report errors to t…
lukecwik commented on pull request #12825: URL: https://github.com/apache/beam/pull/12825#issuecomment-702943945 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #12825: [BEAM-9399] Change DataflowWorkerLoggingHandler to report errors to t…
lukecwik commented on pull request #12825: URL: https://github.com/apache/beam/pull/12825#issuecomment-692175069 @kennknowles `system.err` is always intended to log at ERROR level. Are you saying that logging is being misconfigured somehow and logs for other severities are being sent to `system.err`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #12825: [BEAM-9399] Change DataflowWorkerLoggingHandler to report errors to t…
lukecwik commented on pull request #12825: URL: https://github.com/apache/beam/pull/12825#issuecomment-692173705 @scwhittle I see how the deadlock occurs but why introduce the synchronized(buffer) if we are swapping out the error manager? Also, wouldn't we solve the locking problem if we always held the same "flush" lock when interacting with the error manager? We could do this by sharing a single lock object across the error manager, print stream, ... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
