[GitHub] [beam] mxm commented on pull request #11492: [BEAM-9801] Pass in fire timestamp to timer callback

2020-05-01 Thread GitBox


mxm commented on pull request #11492:
URL: https://github.com/apache/beam/pull/11492#issuecomment-622488737


   Run Python2_PVR_Flink PreCommit



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [beam] mxm commented on pull request #11492: [BEAM-9801] Pass in fire timestamp to timer callback

2020-04-30 Thread GitBox


mxm commented on pull request #11492:
URL: https://github.com/apache/beam/pull/11492#issuecomment-622008605


   Down to one flaky test in 
https://builds.apache.org/job/beam_PreCommit_Python_Commit/12595/
   
   I still need to take a look at the failing test in 
https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Commit/4434/



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [beam] mxm commented on pull request #11492: [BEAM-9801] Pass in fire timestamp to timer callback

2020-04-30 Thread GitBox


mxm commented on pull request #11492:
URL: https://github.com/apache/beam/pull/11492#issuecomment-622006914


   Run Java PreCommit



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [beam] mxm commented on pull request #11492: [BEAM-9801] Pass in fire timestamp to timer callback

2020-04-28 Thread GitBox


mxm commented on pull request #11492:
URL: https://github.com/apache/beam/pull/11492#issuecomment-620842616


   Run Python PreCommit



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [beam] mxm commented on pull request #11492: [BEAM-9801] Pass in fire timestamp to timer callback

2020-04-28 Thread GitBox


mxm commented on pull request #11492:
URL: https://github.com/apache/beam/pull/11492#issuecomment-620842521


   Run Python2_PVR_Flink PreCommit



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [beam] mxm commented on pull request #11492: [BEAM-9801] Pass in fire timestamp to timer callback

2020-04-27 Thread GitBox


mxm commented on pull request #11492:
URL: https://github.com/apache/beam/pull/11492#issuecomment-620079649


   Run Python PreCommit



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [beam] mxm commented on pull request #11492: [BEAM-9801] Pass in fire timestamp to timer callback

2020-04-27 Thread GitBox


mxm commented on pull request #11492:
URL: https://github.com/apache/beam/pull/11492#issuecomment-620079375


   Run Python2_PVR_Flink PreCommit



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [beam] mxm commented on pull request #11492: [BEAM-9801] Pass in fire timestamp to timer callback

2020-04-26 Thread GitBox


mxm commented on pull request #11492:
URL: https://github.com/apache/beam/pull/11492#issuecomment-619533714


   Run Python2_PVR_Flink PreCommit



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [beam] mxm commented on pull request #11492: [BEAM-9801] Pass in fire timestamp to timer callback

2020-04-26 Thread GitBox


mxm commented on pull request #11492:
URL: https://github.com/apache/beam/pull/11492#issuecomment-619533662


   `test_pardo_timers` is now passing for batch and streaming.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [beam] mxm commented on pull request #11492: [BEAM-9801] Pass in fire timestamp to timer callback

2020-04-26 Thread GitBox


mxm commented on pull request #11492:
URL: https://github.com/apache/beam/pull/11492#issuecomment-619533578


   Run Python PreCommit



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [beam] mxm commented on pull request #11492: [BEAM-9801] Pass in fire timestamp to timer callback

2020-04-26 Thread GitBox


mxm commented on pull request #11492:
URL: https://github.com/apache/beam/pull/11492#issuecomment-619526438


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [beam] mxm commented on pull request #11492: [BEAM-9801] Pass in fire timestamp to timer callback

2020-04-25 Thread GitBox


mxm commented on pull request #11492:
URL: https://github.com/apache/beam/pull/11492#issuecomment-619370440


   The issue was that the portable batch mode didn't support timers being set 
by other timers yet. Streaming mode worked fine and so should the batch mode 
now. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [beam] mxm commented on pull request #11492: [BEAM-9801] Pass in fire timestamp to timer callback

2020-04-24 Thread GitBox


mxm commented on pull request #11492:
URL: https://github.com/apache/beam/pull/11492#issuecomment-618976360


   Test failure with batch SDF execution in 
https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Phrase/154/
   ```
   * What went wrong:
   Execution failed for task 
':sdks:python:test-suites:portable:py2:flinkCompatibilityMatrixBatchLOOPBACK'.
   > Process 'command 'sh'' finished with non-zero exit value 1
   ```
   
   Looks unrelated to this change since the cron is also failing: 
https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/803/console



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [beam] mxm commented on pull request #11492: [BEAM-9801] Pass in fire timestamp to timer callback

2020-04-24 Thread GitBox


mxm commented on pull request #11492:
URL: https://github.com/apache/beam/pull/11492#issuecomment-618953097


   Run Python2_PVR_Flink PreCommit



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [beam] mxm commented on pull request #11492: [BEAM-9801] Pass in fire timestamp to timer callback

2020-04-24 Thread GitBox


mxm commented on pull request #11492:
URL: https://github.com/apache/beam/pull/11492#issuecomment-618939929


   Run Python2_PVR_Flink PreCommit



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [beam] mxm commented on pull request #11492: [BEAM-9801] Pass in fire timestamp to timer callback

2020-04-24 Thread GitBox


mxm commented on pull request #11492:
URL: https://github.com/apache/beam/pull/11492#issuecomment-618882229


   The Flink Python tests are blocked on #11362.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org