[GitHub] [beam] robertwb commented on pull request #12841: [BEAM-10894] Basic CSV reading and writing.

2020-09-18 Thread GitBox 


robertwb commented on pull request #12841:
URL: https://github.com/apache/beam/pull/12841#issuecomment-695036835


   Thanks. I'll merge once I verify all tests are still passing after the merge.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] robertwb commented on pull request #12841: [BEAM-10894] Basic CSV reading and writing.

2020-09-17 Thread GitBox 


robertwb commented on pull request #12841:
URL: https://github.com/apache/beam/pull/12841#issuecomment-694320048


   Updated to use the new fileio framework. (As an aside, I noticed that it's 
still marked experimental, should that be dropped.)
   
   PTAL



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] robertwb commented on pull request #12841: [BEAM-10894] Basic CSV reading and writing.

2020-09-16 Thread GitBox 


robertwb commented on pull request #12841:
URL: https://github.com/apache/beam/pull/12841#issuecomment-693735128


   Thanks for the feedback, I'll revise based on ReadableFile and WriteToFiles 
(if they're flexible enough). 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] robertwb commented on pull request #12841: [BEAM-10894] Basic CSV reading and writing.

2020-09-14 Thread GitBox 


robertwb commented on pull request #12841:
URL: https://github.com/apache/beam/pull/12841#issuecomment-692174531


   R: @chamikaramj 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org