Re: [PR] [yaml] disable javascript mapping for python >=3.12 [beam]
tvalentyn merged PR #30843: URL: https://github.com/apache/beam/pull/30843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [yaml] disable javascript mapping for python >=3.12 [beam]
Polber commented on code in PR #30843: URL: https://github.com/apache/beam/pull/30843#discussion_r1552245985 ## sdks/python/setup.py: ## @@ -368,7 +368,7 @@ def get_portability_package_data(): 'grpcio>=1.33.1,!=1.48.0,<2', 'hdfs>=2.1.0,<3.0.0', 'httplib2>=0.8,<0.23.0', - 'js2py>=0.74,<1', + 'js2py>=0.74,<1; python_version<"3.12"', Review Comment: Oh sorry I totally misunderstood what you were asking, thanks for adding that! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [yaml] disable javascript mapping for python >=3.12 [beam]
tvalentyn commented on code in PR #30843: URL: https://github.com/apache/beam/pull/30843#discussion_r1552087003 ## sdks/python/setup.py: ## @@ -368,7 +368,7 @@ def get_portability_package_data(): 'grpcio>=1.33.1,!=1.48.0,<2', 'hdfs>=2.1.0,<3.0.0', 'httplib2>=0.8,<0.23.0', - 'js2py>=0.74,<1', + 'js2py>=0.74,<1; python_version<"3.12"', Review Comment: ```suggestion # https://github.com/PiotrDabkowski/Js2Py/issues/317 'js2py>=0.74,<1; python_version<"3.12"', ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [yaml] disable javascript mapping for python >=3.12 [beam]
Polber commented on code in PR #30843: URL: https://github.com/apache/beam/pull/30843#discussion_r1550773763 ## sdks/python/setup.py: ## @@ -368,7 +372,6 @@ def get_portability_package_data(): 'grpcio>=1.33.1,!=1.48.0,<2', 'hdfs>=2.1.0,<3.0.0', 'httplib2>=0.8,<0.23.0', - 'js2py>=0.74,<1', Review Comment: Thanks for the heads up - refactored to use environmental marker. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [yaml] disable javascript mapping for python >=3.12 [beam]
tvalentyn commented on code in PR #30843: URL: https://github.com/apache/beam/pull/30843#discussion_r1550554929 ## sdks/python/setup.py: ## @@ -368,7 +372,6 @@ def get_portability_package_data(): 'grpcio>=1.33.1,!=1.48.0,<2', 'hdfs>=2.1.0,<3.0.0', 'httplib2>=0.8,<0.23.0', - 'js2py>=0.74,<1', Review Comment: Also let's reference the issue in JS2Py's tracker ## sdks/python/setup.py: ## @@ -368,7 +372,6 @@ def get_portability_package_data(): 'grpcio>=1.33.1,!=1.48.0,<2', 'hdfs>=2.1.0,<3.0.0', 'httplib2>=0.8,<0.23.0', - 'js2py>=0.74,<1', Review Comment: we can simplify it via an environmental marker: https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#platform-specific-dependencies -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [yaml] disable javascript mapping for python >=3.12 [beam]
github-actions[bot] commented on PR #30843: URL: https://github.com/apache/beam/pull/30843#issuecomment-2035658923 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [yaml] disable javascript mapping for python >=3.12 [beam]
Polber commented on PR #30843: URL: https://github.com/apache/beam/pull/30843#issuecomment-2035656569 R: @robertwb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [yaml] disable javascript mapping for python >=3.12 [beam]
Polber commented on PR #30843: URL: https://github.com/apache/beam/pull/30843#issuecomment-2035656431 R: @tvalentyn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
