Re: [Github-comments] [geany/geany] Ctags sync, part 1 (#1160)

2016-09-08 Thread Colomban Wendling 
Otherwise, should be mergeable indeed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1160#issuecomment-245718148

Re: [Github-comments] [geany/geany] Ctags sync, part 1 (#1160)

2016-09-08 Thread Colomban Wendling 
```
../../ctags/main/lregex.c:656:13: warning: no previous prototype for 
'printRegexKinds' [-Wmissing-prototypes]
 extern void printRegexKinds (const langType language CTAGS_ATTR_UNUSED, 
boolean indent CTAGS_ATTR_UNUSED)
 ^~~
../../ctags/main/read.c:605:14: warning: no previous prototype for 
'readLineFromBypass' [-Wmissing-prototypes]
 extern char *readLineFromBypass (
  ^~
```
Suggests unused or missing their header inclusion.

```
../../ctags/main/main.c:125:13: warning: 'printTotals' defined but not used 
[-Wunused-function]
 static void printTotals (const clock_t *const timeStamps)
 ^~~
```
No biggie either, but maybe worth noting.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1160#issuecomment-245717654

Re: [Github-comments] [geany/geany] Ctags sync, part 1 (#1160)

2016-09-08 Thread Colomban Wendling 
```
../../ctags/parsers/c.c: In function 'processToken':
../../ctags/parsers/c.c:2033:3: warning: case value '4294967295' not in 
enumerated type 'keywordId {aka enum eKeywordId}' [-Wswitch]
   case KEYWORD_NONE:  processName (st);   break;
   ^~~~
```
How scared should we be?  that's a typical signed/unsigned issue, but hum.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1160#issuecomment-245716579

Re: [Github-comments] [geany/geany] Ctags sync, part 1 (#1160)

2016-09-08 Thread Jiří Techet 
@b4n Is there anything that prevents this getting merged? I'd like to continue 
syncing uctags and don't want it to diverge too much in the meantime.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1160#issuecomment-245710811

Re: [Github-comments] [geany/geany] Document data (#1203)

2016-09-08 Thread Thomas Martitz 
Using scintillawidget for this is just hacky and we shouldnt recommend or even 
suggest this :-/

For the change, I don't think it's truly necessary but OK with me if you like 
the added convenience.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1203#issuecomment-245686309

Re: [Github-comments] [geany/geany] Gracefully handle proxies registering invalid extensions (#1212)

2016-09-08 Thread Thomas Martitz 
@codebrainz Can you make the change if you don't feel strong either? The 
documentation is clear so we don't have to be forgiving.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1212#issuecomment-245685550

Re: [Github-comments] [geany/geany] New tagmanager query module (#1187)

2016-09-08 Thread Thomas Martitz 
@b4n @codebrainz Please merge this or is there anything left to do?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1187#issuecomment-245684893