Re: [Github-comments] [geany/geany] Make build_get/set_(current_)menu_item functions symmetrical (#1225)

[Matthew Brush]

> You never want to set the current build command, thats the point, why do you 
> want to set a command in an unknown source?

If you want to set the build command which is currently active, otherwise you 
have to figure out if a project is open, for example, and then set that build 
command rather than just setting whatever one is in effect at the moment.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1225#issuecomment-246255978

Re: [Github-comments] [geany/geany] Make build_get/set_(current_)menu_item functions symmetrical (#1225)

[elextr]

You never want to set the current build command, thats the point, why do
you want to set a command in an unknown source?

"Current" is a state, not a thing, it may be different after the next user
input.  You then don't know what you set.

On 12 September 2016 at 15:47, Matthew Brush 
wrote:

> That set_current functionality should not be added is the main point.
>
> It's the only way to set the current build command, that's the rationale :)
>
> An alternative would be a function like build_get_current_source() to get
> the current build source and then use that the set it.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> , or mute
> the thread
> 
> .
>


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1225#issuecomment-246255517

Re: [Github-comments] [geany/geany] Make build_get/set_(current_)menu_item functions symmetrical (#1225)

[Matthew Brush]

> That set_current functionality should not be added is the main point.

It's the only way to set the current build command, that's the rationale :)

An alternative would be a function like `build_get_current_source()` to get the 
current build source and then use that the set it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1225#issuecomment-246255156

Re: [Github-comments] [geany/geany] Make build_get/set_(current_)menu_item functions symmetrical (#1225)

[elextr]

The complexity (or not) isn't the main point.  That `set_current` functionality 
should not be added is the main point.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1225#issuecomment-246253805

Re: [Github-comments] [geany/geany] Make build_get/set_(current_)menu_item functions symmetrical (#1225)

[Matthew Brush]

> Looks unnecessarily complex.

Believe it or not, the code is actually simplified since it removes an unused 
function and refactors an existing function to be in terms of another function 
instead of duplicating code. But yeah, the diff looks complex at a glance due 
to the way diffs work.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1225#issuecomment-246249313

Re: [Github-comments] [geany/geany] Geany 1.28 "Find in files" doesn't work in Windows 7 64bit OS (#1229)

[elextr]

The messages are from the `grep` command shown in blue at the top of the 
window.  Try running it at the command line after `cd`ing to the directory 
indicated.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1229#issuecomment-246232478

[Github-comments] [geany/geany] Geany 1.28 "Find in files" doesn't work in Windows 7 64bit OS (#1229)

[VS]

Please check screenshot(attached
![screenshot - sep 12 2016 8 11 
am](https://cloud.githubusercontent.com/assets/332841/18423289/78951344-78c1-11e6-8af5-bf7bfe32c28b.png)
) and let me know what could be issue responsible for this behaviour.

Ask me if still not clear.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1229

Re: [Github-comments] [geany/geany] Make build_get/set_(current_)menu_item functions symmetrical (#1225)

[elextr]

Looks unnecessarily complex.  Shouldn't need all the changes to the internals.

Get any command is a good idea, yes.  To do that I suggest you modify 
`build_get_menu_item()` which is not in the API and not used in Geany.  Just 
add the field parameter, and the switch statement from 
`build_get_current_menu_item()` then add API_SYMBOL and fix the doxygen and 
there ya go, local changes only.

I'm not sure about `set_current`.  Sure its symmetric, but its modifying a menu 
item from an unknown source, which could include the defaults.  I don't think 
thats all that sensible, but I'm open to discussion if you can give a 
reasonable use-case, but at the moment I think the plugin should know what its 
modifying.

And don't forget you have to put the original values back in the plugin 
shutdown code, its hard to do that when you don't know what was modified.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1225#issuecomment-246219258

Re: [Github-comments] [geany/geany] scrollbar steppers missing running as root (#1226)

[elextr]

What version of GTK is Geany using? (menu->help->debug messages near the top).  
If its gtk2 then the css is not going to have an effect, you will need to do it 
with gtkrc.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1226#issuecomment-246216131

Re: [Github-comments] [geany/geany] Fix: Improve documentation on duplication (#1228)

[elextr]

> @@ -3357,6 +3357,10 @@ Delete to line startCtrl-Shift-BackSpace   
>Deletes from the begin
>current caret 
> position.
>  
>  Duplicate line or selection Ctrl-DDuplicates the 
> current line or selection.
> +   If the selection 
> spans more than one line,
> +   this duplicates the 
> lines containing selections.
> +   If the selection 
> spans only a single line, then only
> +   the selection is 
> duplicated.
>  

Thanks, but I'm not  sure, seems to be even more confusing to me. Why talk 
about the selection being multiple lines? If its the selection, its the 
selection.

I am not sure whats confusing about the existing description, but suggest 
"Duplicate the selection. If no selection duplicate the current line." if 
further clarification is needed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1228/files/0b7ede926df095c82432be0ec071bddb32e3ff59#r78306320

[Github-comments] [geany/geany] Fix: Improve documentation on duplication (#1228)

[Michael Gruben]

Previously, the documentation on the duplication did not clearly delineate the 
behavior of the `duplication` keystroke.
Specifically, it was possible to interpret this keystroke as performing 
selection-only `duplication`.
However, `duplication` only duplicates the selection on the same line, or the 
multiple lines which are selected.

Accordingly, add additional statements clarifying the behavior of `duplication`.

This is intended to fix [issue 
#1075](https://github.com/geany/geany/issues/1075)
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/1228

-- Commit Summary --

  * Fix: Improve documentation on duplication

-- File Changes --

M doc/geany.txt (4)

-- Patch Links --

https://github.com/geany/geany/pull/1228.patch
https://github.com/geany/geany/pull/1228.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1228

Re: [Github-comments] [geany/geany] Fix some typos in French translation (#1227)

[Landrok]

> @@ -2202,7 +2202,7 @@ msgid ""
>  "Space separated list of file patterns used for the find in files dialog (e."
>  "g. *.c *.h)"
>  msgstr ""
> -"Liste de motifs de fichier, séparés par une espace, à utiliser dans le "
> +"Liste de motifs de fichier, séparés par un espace, à utiliser dans le "

Quite ambiguous, `un` refers to the space we see whereas `une` refers to the 
physical chain which will be inserted. I learned one more thing today.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1227/files/d05ab09df751f25ec06226a94ad05e68cbe3d0ad#r78300259

Re: [Github-comments] [geany/geany] Fix some typos in French translation (#1227)

[Landrok]

> @@ -4412,7 +4412,7 @@ msgid ""
>  msgstr ""
>  "Tester la correspondance des expressions régulières sur tout le tampon d'un 
> "
>  "coup plutôt que ligne à ligne, ce qui permet aux correspondances de "
> -"recouvrir plusieurs lignes.  Dans ce mode les caractères de fin de ligne "
> +"recouvrir plusieurs lignes.  Dans ce mode, les caractères de fin de ligne "

_"Le complément circonstanciel est obligatoirement suivi d’une virgule."_ could 
have been my argument, but, to be honest, it was just in reference to the 
English sentence L4409 :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1227/files/d05ab09df751f25ec06226a94ad05e68cbe3d0ad#r78300171

Re: [Github-comments] [geany/geany] Fix some typos in French translation (#1227)

[Colomban Wendling]

Apart a small remark, LGTM

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1227#issuecomment-246194486

Re: [Github-comments] [geany/geany] Fix some typos in French translation (#1227)

[Colomban Wendling]

> @@ -4412,7 +4412,7 @@ msgid ""
>  msgstr ""
>  "Tester la correspondance des expressions régulières sur tout le tampon d'un 
> "
>  "coup plutôt que ligne à ligne, ce qui permet aux correspondances de "
> -"recouvrir plusieurs lignes.  Dans ce mode les caractères de fin de ligne "
> +"recouvrir plusieurs lignes.  Dans ce mode, les caractères de fin de ligne "

meh, I don't like unnecessary commas.  but well, if you like.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1227/files/d05ab09df751f25ec06226a94ad05e68cbe3d0ad#r78299560

Re: [Github-comments] [geany/geany] Fix some typos in French translation (#1227)

[Colomban Wendling]

> @@ -2202,7 +2202,7 @@ msgid ""
>  "Space separated list of file patterns used for the find in files dialog (e."
>  "g. *.c *.h)"
>  msgstr ""
> -"Liste de motifs de fichier, séparés par une espace, à utiliser dans le "
> +"Liste de motifs de fichier, séparés par un espace, à utiliser dans le "

`une` is technically correct, but OK, `un` is more common nowadays even to 
refer to the character itself

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1227/files/d05ab09df751f25ec06226a94ad05e68cbe3d0ad#r78299547

[Github-comments] [geany/geany] Fix some typos in French translation (#1227)

[Landrok]

You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/1227

-- Commit Summary --

  * Fix some typos in French translation

-- File Changes --

M po/fr.po (52)

-- Patch Links --

https://github.com/geany/geany/pull/1227.patch
https://github.com/geany/geany/pull/1227.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1227

[Github-comments] [geany/geany] scrollbar steppers missing running as root (#1226)

[nilands55s]

I hate the overlay scrollbars as I find I have to hunt for them, so they are 
disabled. To over come the missing items that used to come with 
fallback/flashback Gnome desktop I use 2 sections of code to bring back 
functionality.
'gtk-widgets.css' 
usually in the Theme section of the current theme
`/*
 * scrollbar *
 */
.scrollbar,
.scrollbar.vertical {
-GtkScrollbar-has-backward-stepper: 1;
-GtkScrollbar-has-forward-stepper: 1;
-GtkRange-slider-width: 16;
-GtkRange-stepper-size: 16;
-GtkRange-stepper-spacing: 0;
-GtkRange-trough-border: 0;
-GtkScrollbar-min-slider-length: 30;

border-radius: 20px;

border-image: none;
}

.scrollbar.trough,
.scrollbar.trough.vertical {
border-color: shade (@bg_color, 0.8);
}

.scrollbar.slider,
.scrollbar.slider:hover,
.scrollbar.button,
.scrollbar.slider.vertical,
.scrollbar.slider.vertical:hover,
.scrollbar.button.vertical {
border-width: 1px;
border-style: solid;
border-color: shade (@bg_color, 0.86);
background-image: -gtk-gradient (linear, left top, right top,
 from (shade (#BDE3F0, 1.08)),
 color-stop (0.5, #BDE3F0),
 to (shade (#BDE3F0, 0.94)));
box-shadow: inset 1px 0 shade (@bg_color, 1.1),
inset -1px 0 shade (@bg_color, 1.01),
inset 0 1px shade (@bg_color, 1.1),
inset 0 -1px shade (@bg_color, 1.1);
}

.scrollbar.slider.horizontal,
.scrollbar.slider.horizontal:hover,
.scrollbar.button.horizontal {
background-image: -gtk-gradient (linear, left top, left bottom,
 from (shade (#BDE3F0, 1.08)),
 color-stop (0.5, #BDE3F0),
 to (shade (#BDE3F0, 0.94)));
box-shadow: inset 1px 0 shade (@bg_color, 1.1),
inset -1px 0 shade (@bg_color, 1.1),
inset 0 1px shade (@bg_color, 1.1),
inset 0 -1px shade (@bg_color, 1.01);
}

/* overlay scrollbar */
OsThumb {
color: shade (@fg_color, 1.6);
}`

and 'gtk.css' 
in the .config/gtk-3.0 section and /gtk-2.0 section
`/**
* Scrollbars *
**/
.scrollbar {
  -GtkScrollbar-has-backward-stepper: 1;
  -GtkScrollbar-has-forward-stepper: 1;
  -GtkRange-slider-width: 16;
  -GtkRange-stepper-size: 16;
  -GtkRange-stepper-spacing: 0;
  -GtkRange-trough-border: 0;
  -GtkScrollbar-min-slider-length: 30;
}`

Perhaps I do not know where to put these for Geany?
Thanks James Niland

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1226

[Github-comments] [geany/geany] Make build_get/set_(current_)menu_item functions symmetrical (#1225)

[Matthew Brush]

So plugins can set the current command rather than only get it, as well as get 
a specific command rather than only set it.

__Note:__ This needs real code review since I had a hard time following the 
code in `build.c`, I'm not 100% confident I implemented this correctly. Will be 
testing with a real plugin soon.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/1225

-- Commit Summary --

  * Make build_get/set_(current_)menu_item functions symmetrical

-- File Changes --

M src/build.c (175)
M src/build.h (8)
M src/plugindata.h (2)

-- Patch Links --

https://github.com/geany/geany/pull/1225.patch
https://github.com/geany/geany/pull/1225.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1225

Re: [Github-comments] [geany/geany] Add utils_get_real_path() and use it (#1224)

[Matthew Brush]

@codebrainz pushed 1 commit.

0370112  Mark tm_get_real_path with G_DEPRECATED_FOR


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/pull/1224/files/d8a5212bd93843d813c6cfcfe56b7e8abd039aac..0370112fc13f0c8b52ed627d06ff6baa1778bec1

[Github-comments] [geany/geany] Add utils_get_real_path() and use it (#1224)

[Matthew Brush]

This is a wrapper around `tm_get_real_path()` but is in a more suitable 
namespace/module.

I think it makes more sense like this. I typically dislike adding 
general-purpose functions to the API, but since Glib doesn't provide any 
equivalent, it really is useful.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/1224

-- Commit Summary --

  * Add utils_get_real_path() and use it

-- File Changes --

M src/app.h (2)
M src/document.c (8)
M src/libmain.c (2)
M src/plugindata.h (2)
M src/tagmanager/tm_source_file.c (2)
M src/utils.c (29)
M src/utils.h (1)

-- Patch Links --

https://github.com/geany/geany/pull/1224.patch
https://github.com/geany/geany/pull/1224.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1224

Re: [Github-comments] [geany/geany] Add "project-before-close" signal to API (#1223)

[Matthew Brush]

Ammended commit to change API 229 to 230 since 
094737533609dff5a2ff101f97e8c156bcca4979.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1223#issuecomment-246174611

Re: [Github-comments] [geany/geany] Add new API function to open a project file (#1222)

[Matthew Brush]

Ammended commit to change API 229 to 230 since 
094737533609dff5a2ff101f97e8c156bcca4979.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1222#issuecomment-246174379

Re: [Github-comments] [geany/geany] Improve template command error message (#1166)

[Enrico Tröger]

Merged #1166.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1166#event-785147411

Re: [Github-comments] [geany/geany-plugins] Addons: Implement deselect with single click (#481)

[Enrico Tröger]

Merged #481.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/481#event-785147250