Re: [Github-comments] [geany/geany] Bash - Shell Script Colorizer is Broken (#1549)

2017-07-21 Thread AdamDanischewski
Thanks, when the next release is out it should be easy to quickly test and then 
we can close this. In the meantime if anyone is frustrated about this a 
workaround is to temporarily comment out the problematic array element 
assignments - that will put the highlighting back to normal and you can develop 
the remainder of the code then uncomment the array assignments when you are 
ready to start executing. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1549#issuecomment-317087596

Re: [Github-comments] [geany/geany] Geany Locking up when typing or copying of text (#1540)

2017-07-21 Thread AdamDanischewski
Have you tried segmenting the file? Copy it someplace and cut it in half, are 
both sides broken? If so keep cutting it in half again until you find a half 
not broken then focus on the smallest broken half continuing to narrow it down 
to the problem area.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1540#issuecomment-317086480

Re: [Github-comments] [geany/geany] Launching bash script with a keybinding (#1541)

2017-07-21 Thread fjvico
@elextr Adding a 'cat "$1"' to the script and calling the custom command seems 
to do the job. Only thing is that it selects the current line, what is not a 
desired effect.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1541#issuecomment-317056456

Re: [Github-comments] [geany/geany] Geany Locking up when typing or copying of text (#1540)

2017-07-21 Thread elextr
> It also appear some chars have corrupted to some extent £ has turned into 
> "£" as an example.

That sounds like you may have pasted stuff with different encodings.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1540#issuecomment-316972432

Re: [Github-comments] [geany/geany] Geany Locking up when typing or copying of text (#1540)

2017-07-21 Thread hdaz000700
after doing cat file | tr -d '\000' > new_file 
diff file new_file

diff shows nothing and the md5sums are the same.

reason there are so many non ascii characters
There are lots of information things like ALT Characters 
http://www.tedmontgomery.com/tutorial/altchrc-a.html <<< been in the same file 
for years now >>> 

lots of newer console output are using things like  "●" docker, systemd, pip 
etc 

It also appear some chars have corrupted to some extent £ has turned into "£" 
as an example.

Cheers
Daz



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1540#issuecomment-316969139

Re: [Github-comments] [geany/geany] Keybinding to remember location in history (#1114)

2017-07-21 Thread Vasiliy Faronov
Updated this PR in case anybody wants to give it a go. It’s quite simple and 
has already been reviewed once by @b4n (and comments addressed).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1114#issuecomment-316960428

Re: [Github-comments] [geany/geany] Push current position to navqueue before navigating back (#1537)

2017-07-21 Thread Vasiliy Faronov
Thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1537#issuecomment-316957430

Re: [Github-comments] [geany/geany] Bash - Shell Script Colorizer is Broken (#1549)

2017-07-21 Thread LarsGit223
:thumbsup: Great!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1549#issuecomment-316945291

Re: [Github-comments] [geany/geany] Bash - Shell Script Colorizer is Broken (#1549)

2017-07-21 Thread elextr
@LarsGit223 thanks for testing #1503, it should be included in the next Geany 
release, so hopefully this will be fixed then.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1549#issuecomment-316944664

Re: [Github-comments] [geany/geany] Bash - Shell Script Colorizer is Broken (#1549)

2017-07-21 Thread LarsGit223
I cloned, compiled, installed and tested with b4n's branch 
scintilla/update-375. With that version this problem is solved. So I can 
confirm that PR #1503 would fix this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1549#issuecomment-316944003

Re: [Github-comments] [geany/geany] Push current position to navqueue before navigating back (#1537)

2017-07-21 Thread Thomas Martitz
I'm actually very happy this was merged relatively quickly despite the enormous 
discussion that arose.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1537#issuecomment-316928874

Re: [Github-comments] [geany/geany] Push current position to navqueue before navigating back (#1537)

2017-07-21 Thread elextr
Even handed, everybody is unhappy :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1537#issuecomment-316928591

Re: [Github-comments] [geany/geany] Better snippets (#1470)

2017-07-21 Thread Thomas Martitz
\o/

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1470#issuecomment-316927995

Re: [Github-comments] [geany/geany] Push current position to navqueue before navigating back (#1537)

2017-07-21 Thread Matthew Brush
> Good (although it wasn't my favorite version of the patch)

I don't think it was anyone's favourite version of the patch :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1537#issuecomment-316927558

Re: [Github-comments] [geany/geany] TypeScript syntax highlighting (#1450)

2017-07-21 Thread elextr
No typescriptists willing to test?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1450#issuecomment-316921362

Re: [Github-comments] [geany/geany] Added an option to save/reload either window position or size, but optionally not both. (#1456)

2017-07-21 Thread elextr
LGBI, not yet tested.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1456#issuecomment-316921058

Re: [Github-comments] [geany/geany] Better snippets (#1470)

2017-07-21 Thread elextr
Merged #1470.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1470#event-1173353996

Re: [Github-comments] [geany/geany] Better snippets (#1470)

2017-07-21 Thread elextr
LGBI, and tested by @vfaronov, thanks, merged.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1470#issuecomment-316918337

Re: [Github-comments] [geany/geany] Push current position to navqueue before navigating back (#1537)

2017-07-21 Thread Thomas Martitz
Good (although it wasn't my favorite version of the patch)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1537#issuecomment-316916352

Re: [Github-comments] [geany/geany] Create correct path for filetype config files (#1482)

2017-07-21 Thread elextr
Ok, the overloading issue is separated to #1552, LGBI

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1482#issuecomment-316915168

[Github-comments] [geany/geany] Filetype file editing overrides filetype changes with new versions of Geany (#1552)

2017-07-21 Thread elextr
When `Tools->Configuration Files ...` is used to edit a config file it is 
copied in its entirety to the buffer, so when it is saved it overrides all the 
settings in the system filetype file, not just the ones that the user changes.  
So system filetype files distributed with new versions of Geany will be ignored.

Suggest when the file is loaded into the buffer it be prefixed by `# ` to make 
all contents comments, so the user only need uncomment those they edit and so 
only those entries will override new system files.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1552

Re: [Github-comments] [geany/geany] Scintilla/update 375 g++ (#1504)

2017-07-21 Thread elextr
Closed #1504.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1504#event-1173329598

Re: [Github-comments] [geany/geany] Scintilla/update 375 g++ (#1504)

2017-07-21 Thread elextr
An attempt to fix #1503 now obsoleted by the fix there, closed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1504#issuecomment-316913657

Re: [Github-comments] [geany/geany] Add missing string and comment styles for various lexers (#1502)

2017-07-21 Thread elextr
@b4n, thats a very different PR to this since it means all users of 
`is_string_style()` need to add extra tests for `is_regex_style()`.

Whilst I agree (see above) thats probably the "correct" solution, adding 
regexen to string styles is a hack for now when resources to do the right thing 
are not available.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1502#issuecomment-316913144

Re: [Github-comments] [geany/geany] Add Missing PHP Keywords (#1547)

2017-07-21 Thread elextr
Merged #1547.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1547#event-1173319477

Re: [Github-comments] [geany/geany] Add Missing PHP Keywords (#1547)

2017-07-21 Thread elextr
Approved by two devs as ok to merge.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1547#issuecomment-316911722

Re: [Github-comments] [geany/geany] Push current position to navqueue before navigating back (#1537)

2017-07-21 Thread elextr
Despite the discussion about how Geany should approach error handling, the 
change is small simple and appears safe, so merged.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1537#issuecomment-316911455

Re: [Github-comments] [geany/geany] Push current position to navqueue before navigating back (#1537)

2017-07-21 Thread elextr
Merged #1537.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1537#event-1173316543