Re: [Github-comments] [geany/geany] Multiple carets, selections, insertion points and paste (#1141)
> I had also tried Ctrl-click in SciTE and that worked as expected. What exactly is expected, I can't get Scite to do anything interesting on crtl+click. The version in my distro is kind of old (3.6.0) and maybe it was added after that. How do you know it didn't work? IIUC multiple selections have a separate styling from the main selection, and since Geany doesn't set that style they may not be visible? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1141#issuecomment-343834647
Re: [Github-comments] [geany/geany] Multiple carets, selections, insertion points and paste (#1141)
I had assumed that it was built in to Scintilla since [that docs page I mentioned before](http://www.scintilla.org/ScintillaDoc.html#MultipleSelectionAndVirtualSpace) [1] seems to be about Scintilla only and it explicitly mentions `Ctrl` in conjunction with the mouse. I had also tried `Ctrl-click` in SciTE and that worked as expected. After a cursory `grep` through the latest Scintilla and SciTE, I didn't find `Ctrl-click` logic in either of them. There's some kind of autogenerated interface in SciTE which makes things like this hard to search for there, though. I did stumble across the logic for the selection adding behaviour bound to `Ctrl-D` in Sublime Text. Altogether that suggests to me that the `Ctrl-click` behaviour is probably in SciTE, not built-in`to Scintilla. So I've now tried calling `SCI_ADDSELECTION` on `Ctrl-click`, in the same place I removed the code from, but it still doesn't seem to do anything. I've confirmed it makes it to the right part of the big switch statement in the local copy of Scintilla though. [Here's the diff](https://gist.github.com/Ryan1729/2244914f0ac7856fed42f8379fb4cd36). [1] Regarding the link, I meant to do something [`like this`](http://www.scintilla.org/ScintillaDoc.html#MultipleSelectionAndVirtualSpace). I've put the backticks inside the square brackets this time. I knew there was a way that it worked. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1141#issuecomment-343828519
Re: [Github-comments] [geany/geany] Multiple carets, selections, insertion points and paste (#1141)
@Ryan1729 good on you for trying. One thought on why it does nothing is that something has to do the selection, are you sure Scintilla has a default binding for `ctrl+click` that does multiple selection? If not you need to add it, or add it to Geany in place of the code you deleted. > Per comments above I expected some parts not to play nicely with multiple > selections I would expect _everything_ to simply ignore multiple selections, and just read the main selection and operate on that. And thats where the "significant change" part above comes in. The `enable-multiselection` branch is not in the Geany repository, or any PR (AFAICT) so it a private one at best in that persons github repository. PS removed the backticks around your link so it would work, markup is ignored inside backticks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1141#issuecomment-343780286
Re: [Github-comments] [geany/geany] Multiple carets, selections, insertion points and paste (#1141)
This feature is just about the only thing holding me back from switching away from another editor for everything, so I thought I would take a stab at it. I cloned master and added a wrapper for `[SCI_SETMULTIPLESELECTION](http://www.scintilla.org/ScintillaDoc.html#MultipleSelectionAndVirtualSpace)` in `sciwrappers.c` and unconditionally called it in `create_new_sci`, (presumably the final version should be behind a checkbox or something.) But that didn't appear to do anything, (specifically I tried Ctrl-clicking to place multiple cursors.) Just by searching "geany ctrl click" I found [this discussion thread](https://lists.geany.org/pipermail/users/2012-May/008026.html) that mentions that Ctrl-clicking is hardcoded to goto-tag and find-matching-brace depending where you click. So I found [the part of the code that does that](https://github.com/geany/geany/blob/dd58ab6f49e8b382d9278c3ebc533f08b8aec84e/src/editor.c#L316-L327) and removed it. But Ctrl-clicking still doesn't work. Per comments above I expected some parts not to play nicely with multiple selections, but I hoped what I did would be enough to get it working some of the time! I managed to make the small changes I did by just `grep`ping trough the code and checking that functions were called when I thought they were being called. Does anyone else with more knowledge of the codebase have any ideas what else might cause Ctrl-clicking not to work? FWIW, [further on](https://lists.geany.org/pipermail/users/2012-May/008041.html) in that discussion I linked to, an `enable-multiselection` branch was mentioned. Now I don't know the history of this project, but that discussion is from 2012. Is there any chance that branch would be even slightly relevant to the current codebase, assuming the author still has it and can be contacted? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1141#issuecomment-343777950
[Github-comments] [geany/geany] Reword two phrases in German translation (#1686)
Including typo fixes. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/1686 -- Commit Summary -- * Reword two phrases in German translation -- File Changes -- M po/de.po (4) -- Patch Links -- https://github.com/geany/geany/pull/1686.patch https://github.com/geany/geany/pull/1686.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1686
