Re: [Github-comments] [geany/geany] Use GResource to load GtkBuilder XML UI file (#1703)

2018-01-12 Thread Colomban Wendling
b4n commented on this pull request.



> + --target=$@ \
+   --sourcedir=$(srcdir) \
+   --generate-source \
+   --c-name="geany" \
+   --manual-register \
+   --internal \
+   $(srcdir)/geany.gresource.xml
+resources.h: $(resource_dependencies)
+   $(AM_V_GEN)$(GLIB_COMPILE_RESOURCES) \
+   --target=$@ \
+   --sourcedir=$(srcdir) \
+   --generate-header \
+   --c-name="geany" \
+   --manual-register \
+   --internal \
+   $(srcdir)/geany.gresource.xml

I'm not sure, but many tools aren't smart enough so I'd at least check.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1703#discussion_r161364595

Re: [Github-comments] [geany/geany] Remove requirement to fail build on aggregate return (#1740)

2018-01-12 Thread Matthew Brush
Merged #1740.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1740#event-1422855689

Re: [Github-comments] [geany/geany] Allow to choose the VTE cursor shape (#170)

2018-01-12 Thread elextr
Closed since nobody cared enough to comment in 4 years, can always be reopened 
if needed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/170#issuecomment-357398120

Re: [Github-comments] [geany/geany] Allow to choose the VTE cursor shape (#170)

2018-01-12 Thread elextr
Closed #170.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/170#event-1422788959

Re: [Github-comments] [geany/geany] Fix comparison between signed and unsigned integers (dbd0573)

2018-01-12 Thread Matthew Brush
The function name is different, but it [appears to already be fixed 
upstream](https://github.com/universal-ctags/ctags/blob/master/main/parse.c#L1607)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/commit/dbd0573dd6a5175ec9b536c4053bb66caac0f665#commitcomment-26827217

Re: [Github-comments] [geany/geany] added Literate Haskell filetype (#163)

2018-01-12 Thread elextr
Closing because nobody has supported or queried adding this language.  If it 
can be shown that it has a significant user population feel free to show that 
and fix the conflicts and re-open.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/163#issuecomment-357395297

Re: [Github-comments] [geany/geany] Adding *.iss file under Conf (InnoSetup files) (#167)

2018-01-12 Thread elextr
Closing due to no action in 4 years

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/167#issuecomment-357394581

Re: [Github-comments] [geany/geany] Adding *.iss file under Conf (InnoSetup files) (#167)

2018-01-12 Thread elextr
Closed #167.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/167#event-1422767897

Re: [Github-comments] [geany/geany] Remove requirement to fail build on aggregate return (#1740)

2018-01-12 Thread Colomban Wendling
OK.

@elextr 4 is not a real reason, GP is voluntarily forgiving on non-critical 
things because it's more of an aggregate itself () then a single project.

@codebrainz warnings are mostly useless in CI builds unless the CI can report 
them directly, nobody actually read a successful build's log.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1740#issuecomment-357394540

Re: [Github-comments] [geany/geany] warning support (#1649)

2018-01-12 Thread Matthew Brush
This will close/fix #447 when merged.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1649#issuecomment-357394261

Re: [Github-comments] [geany/geany] Different colors for warnings and errors (#864)

2018-01-12 Thread Matthew Brush
Closed #864.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/864#event-1422763726

Re: [Github-comments] [geany/geany] Different colors for warnings and errors (#864)

2018-01-12 Thread Matthew Brush
Closing because of dupe of #447 and continued in PR #1649 (thanks!)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/864#issuecomment-357393815

Re: [Github-comments] [geany/geany] Add AutoIt syntax highlighting (#1017)

2018-01-12 Thread Matthew Brush
@Skif-off sorry for the delay, short on people-power lately.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1017#issuecomment-357393232

Re: [Github-comments] [geany/geany] Add AutoIt (*.au3) Lexer to Geany (#967)

2018-01-12 Thread Matthew Brush
Closing as this is continued in #1017 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/967#issuecomment-357393131

Re: [Github-comments] [geany/geany] Add AutoIt (*.au3) Lexer to Geany (#967)

2018-01-12 Thread Matthew Brush
Closed #967.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/967#event-1422760680

Re: [Github-comments] [geany/geany] Changing color scheme of comiler and symbols setting (#1006)

2018-01-12 Thread Matthew Brush
Closed #1006.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1006#event-1422758528

Re: [Github-comments] [geany/geany] Changing color scheme of comiler and symbols setting (#1006)

2018-01-12 Thread Matthew Brush
Closing as this is supported using GTK+ theming.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1006#issuecomment-357392741

Re: [Github-comments] [geany/geany] plugin/bindings: Add vala bindings (vapi) to allow for plugins written i... (#130)

2018-01-12 Thread elextr
@kugel- is this overtaken by your peasy work?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/130#issuecomment-357392681

Re: [Github-comments] [geany/geany] Colors (#1604)

2018-01-12 Thread Matthew Brush
Closed #1604.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1604#event-1422757697

Re: [Github-comments] [geany/geany] Colors (#1604)

2018-01-12 Thread Matthew Brush
Closing since this is already possible using GTK+ theming.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1604#issuecomment-357392590

Re: [Github-comments] [geany/geany] scrollbar steppers missing running as root (#1226)

2018-01-12 Thread Matthew Brush
Closing due to lack of follow-up and not being a Geany issue.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1226#issuecomment-357392186

Re: [Github-comments] [geany/geany] scrollbar steppers missing running as root (#1226)

2018-01-12 Thread Matthew Brush
Closed #1226.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1226#event-1422754876

Re: [Github-comments] [geany/geany] Apply Theme to Side Bar (#1344)

2018-01-12 Thread Matthew Brush
Closed #1344.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1344#event-1422753463

Re: [Github-comments] [geany/geany] Apply Theme to Side Bar (#1344)

2018-01-12 Thread Matthew Brush
Closing since this is already supported, albeit not exactly as requested.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1344#issuecomment-357391896

Re: [Github-comments] [geany/geany] Do not hardcode foreground colors in message window (#1376)

2018-01-12 Thread Matthew Brush
Closed #1376.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1376#event-1422751260

Re: [Github-comments] [geany/geany] Do not hardcode foreground colors in message window (#1376)

2018-01-12 Thread Matthew Brush
Supported in 6b973bc70b6118c1d904d6d21626843b5e70beaa

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1376#issuecomment-357391455

Re: [Github-comments] [geany/geany] [Feature Request] -- Graphics for Cut/Copy/Paste (#1739)

2018-01-12 Thread Colomban Wendling
Closed #1739.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1739#event-1422748495

Re: [Github-comments] [geany/geany] Unable to change compiler window font colors with themes, gtkrc, or css. (#1737)

2018-01-12 Thread Matthew Brush
Closed #1737.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1737#event-1422748563

Re: [Github-comments] [geany/geany] [Feature Request] -- Graphics for Cut/Copy/Paste (#1739)

2018-01-12 Thread Colomban Wendling
 

---

Cut and Paste both have visible results.  Cut could be confused with delete, 
but that's about all.
Anyway, this kind of thing should likely better be integrated higher in the 
platform's clipboard handling than inside a specific app (here, Geany) as you 
probably want the same behavior in all apps.

This won't likely be implemented in Geany, but you can likely either write a 
Geany plugin or a standalone app reacting to clipboard changes.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1739#issuecomment-357390926

Re: [Github-comments] [geany/geany] Unable to change compiler window font colors with themes, gtkrc, or css. (#1737)

2018-01-12 Thread Matthew Brush
Supported in 6b973bc70b6118c1d904d6d21626843b5e70beaa

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1737#issuecomment-357390937

Re: [Github-comments] [geany/geany] Fix new GCC warnings (#1725)

2018-01-12 Thread Matthew Brush
Merged #1725.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1725#event-1422613232

Re: [Github-comments] [geany/geany] New warning with GCC 7 (#1683)

2018-01-12 Thread Matthew Brush
Closed #1683 via c61bc6784b45b50773bc0e1d1f83b09aed58ede6.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1683#event-1422613245

Re: [Github-comments] [geany/geany] Remove requirement to fail build on aggregate return (#1740)

2018-01-12 Thread Matthew Brush
:+1:, at most this should be a warning.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1740#issuecomment-357366468

[Github-comments] [geany/geany] Remove requirement to fail build on aggregate return (#1740)

2018-01-12 Thread elextr
Returning large aggregates as values is a potential performance problem, but 
preventing all aggregate returns is inappropriate because:

1. returning small aggregates that are mostly handled as complete objects as 
return values often makes code clearer.

2. Modern (well not so modern actually) ABIs allow for small aggregates to be 
returned in registers, so forcing all returns to memory is actually likely to 
be slower.

3. if code review does not notice a large aggregate return and nobody notices a 
performance issue then it doesn't matter
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/1740

-- Commit Summary --

  * Remove requirement to fail build on aggregate return

-- File Changes --

M .travis.yml (2)

-- Patch Links --

https://github.com/geany/geany/pull/1740.patch
https://github.com/geany/geany/pull/1740.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1740


Re: [Github-comments] [geany/geany] Enable popup menu on sidebar and message window notebooks (#1726) (1f71ccd)

2018-01-12 Thread Matthew Brush
Yep. Fixed in 6622574172a23993c19b3ce02e5190f252f01faf

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/commit/1f71ccd40ac4e6754d7609bec7f81773fa181146#commitcomment-26824229

Re: [Github-comments] [geany/geany] [Feature Request] -- Graphics for Cut/Copy/Paste (#1739)

2018-01-12 Thread Matthew Brush
![clippy](https://user-images.githubusercontent.com/181177/34895625-799c9244-f79b-11e7-865c-ea377f6f7b5c.jpg)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1739#issuecomment-357357493

Re: [Github-comments] [geany/geany] Size symbols and fold margins proportional to line height (#1738)

2018-01-12 Thread elextr
Ok, if Scintilla limits the symbol size so its never cut off then the worst it 
can do is appear overly large at times.  And well, your magic 0.88 is no worse 
than 16 :grin:

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1738#issuecomment-357352193

Re: [Github-comments] [geany/geany] Theme improvements (#1382)

2018-01-12 Thread elextr
I have merged this as is because:

1. It works for me and others

2. The remaining issues appear to only be stylistic in code and manual, they 
can be fixed later if "somebody" is interested enough

3. those who understand accessibility issues will understand that colour 
perception issues affect a significant proportion of the population, who have 
been unable to use dark themes due to hard coded colours whilst we bickered 
about code style

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1382#issuecomment-357350181

Re: [Github-comments] [geany/geany] Theme improvements (#1382)

2018-01-12 Thread elextr
Merged #1382.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1382#event-1422497598

Re: [Github-comments] [geany/geany] Size symbols and fold margins proportional to line height (#1738)

2018-01-12 Thread Colomban Wendling
It could, but what's your reasoning?

As said, Scintilla caps the symbol size to min(line height, margin width), so 
my reasoning is that the closest margin width is to line height, the bigger the 
symbol, yet leave some margin on top and bottom.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1738#issuecomment-357344169

[Github-comments] [geany/geany] [Feature Request] -- Graphics for Cut/Copy/Paste (#1739)

2018-01-12 Thread AdamDanischewski
I think it would help productivity and reduce stress if there were little 
graphics that kind of sauntered up when doing things that are presently met 
with invisibility. 

For instance when you copy something, you hit Ctrl-C that's fine, most people 
know that it works and are somewhat comfortable, but your brain could construct 
the idea that you hit the wrong key that causes an invisible 
quasi-imperceptible amount of stress. That stress could be removed making the 
editor much more enjoyable to work with by adding a graphic. 

For example,  a cutesy little graphic that appears to the right hand side of 
the editor border, a gradient trail of smaller versions of it self (. .o 0 O 0 
o .) while swerving back and forth before disappearing off the edge of the 
editor (with a label - for example Copy).  Something like hello-kitty meets ICQ 
would probably be pleasant, yet if you could make it a skin style that could be 
changed that would probably be ideal. 

This behavior should probably be capable of being turned off in the settings, 
yet would probably make a decent default. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1739

Re: [Github-comments] [geany/geany] Enable popup menu on sidebar and message window notebooks (#1726) (1f71ccd)

2018-01-12 Thread Matthew Brush
Maybe [this 
function](https://github.com/geany/geany/blob/1.32.0/src/vte.c#L533) needs to 
return `TRUE` for the two conditional branches?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/commit/1f71ccd40ac4e6754d7609bec7f81773fa181146#commitcomment-26811667

Re: [Github-comments] [geany/geany] Enable popup menu on sidebar and message window notebooks (#1726) (1f71ccd)

2018-01-12 Thread Matthew Brush
Hmm, must be something funky about the VTE widget.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/commit/1f71ccd40ac4e6754d7609bec7f81773fa181146#commitcomment-26811583

Re: [Github-comments] [geany/geany] Enable popup menu on sidebar and message window notebooks (#1726) (1f71ccd)

2018-01-12 Thread Thomas Martitz
This also enables the popup menu in the terminal widget, so I get two popup 
menus.

![grafik](https://user-images.githubusercontent.com/564520/34869576-9f6e2f5a-f787-11e7-9940-0cf02858523a.png)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/commit/1f71ccd40ac4e6754d7609bec7f81773fa181146#commitcomment-26811053

Re: [Github-comments] [geany/geany] Geany crashes when saving something, big data is in clipboard and Qt Creator is running (#1736)

2018-01-12 Thread elextr
Ok, so its definitely Qt Creator trying to crush the GTK opposition 
editors/IDEs by making them crash :grin:

But more realistically it seems GTK and Qt don't agree over sharing X.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1736#issuecomment-357193062