Re: [Github-comments] [geany/geany-plugins] Geany-scope blank window, inusable (#433)

2018-03-10 Thread elextr
ABI should change on semantics changes, which did change, but you are right its 
of little practical use.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/433#issuecomment-372074392

Re: [Github-comments] [geany/geany] Fix PM button desynchronization and possible crash (#1799)

2018-03-10 Thread Colomban Wendling
Especially as the actual diff is changing `FALSE` to `TRUE`, which is a -4 +3 
character diff :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1799#issuecomment-372074239

Re: [Github-comments] [geany/geany] Fix PM button desynchronization and possible crash (#1799)

2018-03-10 Thread elextr
Nice commit novel :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1799#issuecomment-372074086

Re: [Github-comments] [geany/geany-plugins] Geany-scope blank window, inusable (#433)

2018-03-10 Thread Colomban Wendling
I don't think it's a very good idea: we didn't actually break ABI, and we could 
load an older Scope and it would work.  The only thing would be preventing from 
loading Scope with an older Geany, which could be achieved by the plugin 
depending on a 1.34 API.  And there's only 1 known plugin suffering from the 
issue anyway, so I don't think a "solution" should be penalizing everybody.
Anyway, my suggestion is not really useful in practice, because all it does is 
try and preventing using an older Geany with a newer Scope, but anybody with an 
older Scope would not be stopped, and anybody with a newer Geany wouldn't need 
it… so it only can help for latest version of either Scope or Geany. Bah.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/433#issuecomment-372073923

Re: [Github-comments] [geany/geany] plugin-manager: sync buttons on "button-release-event" (#1784)

2018-03-10 Thread Colomban Wendling
OK I found the root cause of the issue, which actually is a problem on our 
side. See #1799 for details and a fix.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1784#issuecomment-372073501

[Github-comments] [geany/geany] Fix PM button desynchronization and possible crash (#1799)

2018-03-10 Thread Colomban Wendling
Fixes #1781, and replaces #1784.

See 373852c737a4181dd576c02ffe085a915b79a953 for extensive details.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/1799

-- Commit Summary --

  * Check plugin actually has a help function before invoking it
  * Fix plugin manager UI synchronization on double click

-- File Changes --

M src/plugins.c (5)

-- Patch Links --

https://github.com/geany/geany/pull/1799.patch
https://github.com/geany/geany/pull/1799.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1799


Re: [Github-comments] [geany/geany-plugins] Geany-scope blank window, inusable (#433)

2018-03-10 Thread elextr
> Maybe we should make Scope depend on Geany 1.34 to be sure it has a working 
> version?

Just bump the ABI.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/433#issuecomment-372070204

Re: [Github-comments] [geany/geany] Is it possible to color keywords and types differently? (#1798)

2018-03-10 Thread elextr
They are different here, have you chosen a colour scheme that sets them the 
same?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1798#issuecomment-372070082

[Github-comments] [geany/geany] Is it possible to color keywords and types differently? (#1798)

2018-03-10 Thread james


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1798

Re: [Github-comments] [geany/geany-plugins] Geany-scope blank window, inusable (#433)

2018-03-10 Thread Colomban Wendling
Maybe we should make Scope depend on Geany 1.34 to be sure it has a working 
version?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/433#issuecomment-372042082

Re: [Github-comments] [geany/geany-plugins] scope debug terminal colours illegible (#671)

2018-03-10 Thread LarsGit223
The context you mentioned refers to the index in the array ```colors```. I 
searched for calls to ```dc_output()``` and looked at the passed values and I 
think their meaning is something like this:

Context/color index | Meaning
 | ---
0 |  commands send to gdb
1 | ouput/responses from gdb
2 | output of received errors
3 | output of "(gdb) " prompt
4 | error output from scope itself

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/671#issuecomment-372036663

Re: [Github-comments] [geany/geany-plugins] scope debug terminal colours illegible (#671)

2018-03-10 Thread LarsGit223
I think the colors are set in ```conterm_init()```, see the following code 
section:
``` c
else
#endif  /* G_OS_UNIX */
{
static const char *const colors[NFD] = { "#00C0C0", "#C0C0C0", 
"#C0",
"#C0C0C0", "#C000C0" };
guint i;

console = get_widget("debug_context");
context_apply_config(console);
debug_context = GTK_TEXT_VIEW(console);
dc_output = context_output;
dc_output_nl = context_output_nl;
context = gtk_text_view_get_buffer(debug_context);

for (i = 0; i < NFD; i++)
{
fd_tags[i] = gtk_text_buffer_create_tag(context, NULL, 
"foreground",
colors[i], NULL);
}
g_signal_connect(console, "button-press-event",
G_CALLBACK(on_console_button_3_press),
menu_connect("console_menu", _menu_info, NULL));
}
```


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/671#issuecomment-372035992

Re: [Github-comments] [geany/geany-plugins] Geany-scope blank window, inusable (#433)

2018-03-10 Thread LarsGit223
As https://github.com/geany/geany/pull/1461 is merged now, this can be closed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/433#issuecomment-372033246

[Github-comments] [geany/geany-plugins] workbench: fix broken live-update (#722)

2018-03-10 Thread LarsGit223
This fixes the broken live-update. The feature did not work since commit 
dcc37957e917a2e8c2f3e5d483c9a832eceff1e0. The reason was that the 
sub-directories were not added to the file-table and so no file monitor was 
created for them. The live-update only worked for the main directories but not 
for their sub-directories.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/722

-- Commit Summary --

  * workbench: fix broken live-update

-- File Changes --

M workbench/src/wb_project.c (8)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/722.patch
https://github.com/geany/geany-plugins/pull/722.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/722


Re: [Github-comments] [geany/geany] Any documentation about color scheme conf files? (#1797)

2018-03-10 Thread elextr
No, its in the manual as you found :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1797#issuecomment-372025742

Re: [Github-comments] [geany/geany] Any documentation about color scheme conf files? (#1797)

2018-03-10 Thread james
Spent some time before finding this, is it in the wiki?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1797#issuecomment-372024321

Re: [Github-comments] [geany/geany] Any documentation about color scheme conf files? (#1797)

2018-03-10 Thread james
Closed #1797.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1797#event-1514600819

Re: [Github-comments] [geany/geany] Any documentation about color scheme conf files? (#1797)

2018-03-10 Thread james
https://geany.org/manual/dev/#id206

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1797#issuecomment-372024292

[Github-comments] [geany/geany] Any documentation about color scheme conf files? (#1797)

2018-03-10 Thread james
I see true/false tags here and there, what do they do? I did dome google and 
found nothing.

Any theme which explains all parameters?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1797

Re: [Github-comments] [geany/geany-plugins] treebrowser: removed HAVE_GIO checks (#720)

2018-03-10 Thread Matthew Brush
It's pointless for plugins to check for GIO since GTK+ and Geany both use and 
require the library.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/720#issuecomment-372011816