Re: [Github-comments] [geany/geany-plugins] scope: new-maintainer: LarsGit223 (#724)
Merged #724. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/724#event-1515214484
Re: [Github-comments] [geany/geany] Is it possible to color keywords and types differently? (#1798)
Oh, you mean the fundamental types. Because they are built-in to the language there is no definition of them anywhere that the symbol scanner would find, so they are not considered types, so they are included in the keyword list. So they are coloured the same as keywords. You could try putting them into the secondary keyword list and colouring that the same as types. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1798#issuecomment-372145013
Re: [Github-comments] [geany/geany] Is it possible to color keywords and types differently? (#1798)
https://github.com/geany/geany/blob/master/data/filedefs/filetypes.c What I meant is that in this file, C types like int char etc are in the same category that if for while etc. I am creating my own color scheme, but I am using the default filedefs. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1798#issuecomment-372132526
Re: [Github-comments] [geany/geany-plugins] treebrowser: removed needless Gtk version checks (#723)
codebrainz commented on this pull request.
> @@ -138,11 +138,7 @@ PLUGIN_SET_TRANSLATABLE_INFO(
static GList*
_gtk_cell_layout_get_cells(GtkTreeViewColumn *column)
{
-#if GTK_CHECK_VERSION(2, 12, 0)
Why not remove this whole function? It looks like it was only added for
backwards compatibility pre-2.12, and has a confusing name.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/723#pullrequestreview-102884524
Re: [Github-comments] [geany/geany-plugins] Remove references to Gtk internals (#504)
I think this can be closed. I checked all Gtk function calls and found them all with a search on the GNOME developer center page. I think this functions are confusing maybe: ``` gtk_tree_store_iter_clear_nodes _gtk_cell_layout_get_cells ``` These will not be found in the Gtk API because they are part of ```treebrowser.c```. IMHO there are no references to Gtk internals but some bad naming. Or did I oversee something? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/504#issuecomment-372113977
Re: [Github-comments] [geany/geany-plugins] scope: new-maintainer: LarsGit223 (#724)
@LarsGit223 pushed 1 commit. 8ef29b2 scope: updated maintainers file -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/724/files/bb19049620a7daf6578f75d5e83a5bfe1f5ce209..8ef29b232a6b714f2c5b326ed7adaf95a2b09388
Re: [Github-comments] [geany/geany-plugins] workbench: fix broken live-update (#722)
Merged #722. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/722#event-1515023890
Re: [Github-comments] [geany/geany-plugins] scope: new-maintainer: LarsGit223 (#724)
Can you please add update for MAINTAINERS-file? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/724#issuecomment-372112055
Re: [Github-comments] [geany/geany-plugins] treebrowser: removed needless Gtk version checks (#723)
Merged #723. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/723#event-1515019753
[Github-comments] [geany/geany-plugins] scope: new-maintainer: LarsGit223 (#724)
As mentioned earlier I use the scope plugin from time to time and I would be willing to become the maintainer. I'll try my best to keep it alive. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/724 -- Commit Summary -- * scope: new-maintainer: LarsGit223 -- File Changes -- M scope/src/scope.c (6) -- Patch Links -- https://github.com/geany/geany-plugins/pull/724.patch https://github.com/geany/geany-plugins/pull/724.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/724
[Github-comments] [geany/geany-plugins] treebrowser: removed needless Gtk version checks (#723)
Geany depends on Gtk version 2.24 so all version checks for a lower version than 2.24 are needless. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/723 -- Commit Summary -- * treebrowser: removed needless Gtk version checks -- File Changes -- M treebrowser/src/treebrowser.c (25) -- Patch Links -- https://github.com/geany/geany-plugins/pull/723.patch https://github.com/geany/geany-plugins/pull/723.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/723
Re: [Github-comments] [geany/geany] Fix PM button desynchronization and possible crash (#1799)
I did a quick negative and positive test by only changing the ```FALSE``` to ```TRUE```. I can confirm that it fixes the problem for me. Thanks :thumbsup: Today I also noticed that without the fix sometimes even the plugin below the row I am clicking/double-clicking in gets toggled. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1799#issuecomment-372100992
Re: [Github-comments] [geany/geany] plugin-manager: sync buttons on "button-release-event" (#1784)
Ok, thanks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1784#issuecomment-372100797
Re: [Github-comments] [geany/geany] plugin-manager: sync buttons on "button-release-event" (#1784)
Closed #1784. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1784#event-1514966210
