[Github-comments] [geany/geany] Changed the scintilla default from SC_MULTIPASTE_ONCE to SC_MULTIPAST… (#2325)

2019-09-26 Thread AdamDanischewski
Changed the scintilla default in (geany root/scintilla/src/Editor.cxx 
Line 167) from SC_MULTIPASTE_ONCE to SC_MULTIPASTE_EACH - fixes the paste only 
one line when a vertical selection is selected. 
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/2325

-- Commit Summary --

  * Changed the scintilla default from SC_MULTIPASTE_ONCE to SC_MULTIPASTE_EACH 
- fixes the paste only one line when a vertical selection is selected.

-- File Changes --

M scintilla/src/Editor.cxx (2)

-- Patch Links --

https://github.com/geany/geany/pull/2325.patch
https://github.com/geany/geany/pull/2325.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2325


Re: [Github-comments] [geany/geany] Enhancement - Vertical Editing Sequential Numbering (#2317)

2019-09-26 Thread elextr
> Ok @elextr you talked me into looking into the code finally.

Heh, I wasn't actually trying to do that, but while you are there, "just" a 
menu item and keybinding to go. :grin:

I was actually trying to suggest to be patient until the Scintilla 4 upgrade, 
the "it needs c++17" excuse is getting thinner by the day, will have to happen 
soon :smile:

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2317#issuecomment-535741514

Re: [Github-comments] [geany/geany] Enhancement - Vertical Editing Sequential Numbering (#2317)

2019-09-26 Thread AdamDanischewski
Ok @elextr you talked me into looking into the code finally. I've got it 
working with the current Scintilla.
### line 167 geany/scintilla/src/Editor.cxx:   
**from** `multiPasteMode = SC_MULTIPASTE_ONCE;`
**to** `multiPasteMode = SC_MULTIPASTE_EACH;`
![vertical_paste_fix](https://user-images.githubusercontent.com/10157303/65728722-cdd5e800-e089-11e9-8d12-cbe4c6934a94.gif)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2317#issuecomment-535706906

Re: [Github-comments] [geany/geany] Enhancement - Vertical Editing Sequential Numbering (#2317)

2019-09-26 Thread elextr
Note, beware that most of the Scintilla multiple selection documents section is 
only for Scintilla 4, which Geany does not use, and which could allow the whole 
area of rectangular/multiple selections and pastes to be re-assessed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2317#issuecomment-535682599

Re: [Github-comments] [geany/geany-plugins] Windows installer: Migrate to NSIS 3.x (#905)

2019-09-26 Thread elextr
Ahh, the obligatory last minute windows change, the release can go ahead as 
soon as this is merged :grin:

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/905#issuecomment-535678878

Re: [Github-comments] [geany/geany] Django highlighting in templates. (#2315)

2019-09-26 Thread Enrico Tröger
Thanks.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2315#issuecomment-535678680

Re: [Github-comments] [geany/geany] Django highlighting in templates. (#2315)

2019-09-26 Thread Enrico Tröger
Merged #2315 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2315#event-244105

Re: [Github-comments] [geany/geany] Enhancement - Vertical Editing Sequential Numbering (#2317)

2019-09-26 Thread elextr
@AdamDanischewski in this case you don't need an option, just put both items in 
the menu, and make both keybindable and bind one or both by default.

But note that I doubt that multipaste will help with pasting the output of 
`send selection to` since it would paste the multiple lines on every line I 
think (unless somebody checks Scintilla code or tries it and finds its 
different).  There doesn't seem to be a way of telling Scintilla that the paste 
is a rectangular select, it says "Rectangular selections are handled as 
multiple selections although the original rectangular range is remembered so 
that subsequent operations may be handled differently for rectangular 
selections" and "pasting a rectangular selection places each piece in a 
vertical column." meaning the "rectangularness" is remembered internally to 
Scintilla somehow and is unlikely to be a property of the results of `send to 
selection`?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2317#issuecomment-535678348

Re: [Github-comments] [geany/geany-plugins] Windows installer: Migrate to NSIS 3.x (#905)

2019-09-26 Thread Enrico Tröger
I tested the changes last week when creating the PR and I think the changes are 
simple enough. Most of the work has been done already when doing the same 
changes on the Geany installer a few months ago.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/905#issuecomment-535677892

Re: [Github-comments] [geany/geany] Enhancement - Vertical Editing Sequential Numbering (#2317)

2019-09-26 Thread AdamDanischewski
@Akronix I agree with your sentiments on this. 
@elextr I would be fine with there being an option for it. 

Perhaps it could be the default provided no one can give a better use case for 
it not being. To only paste one line when a vertical multiple line 
selection/rectangular selection were held on prior to pasting seems to imply 
that a user error is being corrected since it ignores the additional user 
efforts. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2317#issuecomment-535602733

[Github-comments] [geany/geany] Update zh_CN.po (#2324)

2019-09-26 Thread 柳东原 · Dongyuan Liu

You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/2324

-- Commit Summary --

  * Update zh_CN.po

-- File Changes --

M po/zh_CN.po (10)

-- Patch Links --

https://github.com/geany/geany/pull/2324.patch
https://github.com/geany/geany/pull/2324.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2324


Re: [Github-comments] [geany/geany] Update of Slovak translation (#2318)

2019-09-26 Thread Frank Lanitz
Merged #2318 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2318#event-2664116967

Re: [Github-comments] [geany/geany-plugins] Windows installer: Migrate to NSIS 3.x (#905)

2019-09-26 Thread Frank Lanitz
@eht16  Any tests needed or just merging?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/905#issuecomment-535365584