Re: [Github-comments] [geany/geany] Question: highlight-API: is loading/querying of individual styles possible? (#2331)
> I saw an issue for the pairtaghighlighter plugin asking to make the highlihgt > color/style Ahh, probably the best would be to use indicators for that, they are independent of the highlighting styles so easy for plugins to apply, see scintilla docs. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2331#issuecomment-537340817
Re: [Github-comments] [geany/geany] Question: highlight-API: is loading/querying of individual styles possible? (#2331)
> There is no API because setting it programatically would break this > configuration scheme. I only want to read a value, preferably be key name. There is a function for it, but it's static. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2331#issuecomment-537335554
Re: [Github-comments] [geany/geany] Question: highlight-API: is loading/querying of individual styles possible? (#2331)
@codebrainz: I saw an issue for the pairtaghighlighter plugin asking to make the highlihgt color/style configurable. Then I thought let's quickly add a new key/value pair to a color scheme and use that values. But then I stumbled across the API. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2331#issuecomment-537335380
Re: [Github-comments] [geany/geany] Question: highlight-API: is loading/querying of individual styles possible? (#2331)
@LarsGit223 can you elaborate on what you're trying to do in your plugin? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2331#issuecomment-537282136
Re: [Github-comments] [geany/geany] Multipaste (#2328)
codebrainz commented on this pull request. > @@ -56,162 +57,162 @@ void > sci_set_current_position(ScintillaObject *sci, gint position, gboolean gint sci_get_selection_start (ScintillaObject *sci); gint sci_get_selection_end (ScintillaObject *sci); -void sci_replace_sel (ScintillaObject *sci, const gchar *text); +void sci_replace_sel (ScintillaObject *sci, const gchar *text); > The indentation is horrid in this file :+1: At some point I'll probably make a PR to reformat this header to follow Geany's coding style. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2328#discussion_r330326753
Re: [Github-comments] [geany/geany-plugins] [pair tag highlighter] keyword "font" in a html document (#432)
Closed no response -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/432#issuecomment-537266540
Re: [Github-comments] [geany/geany-plugins] [pair tag highlighter] keyword "font" in a html document (#432)
Closed #432. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/432#event-2678793371
Re: [Github-comments] [geany/geany] Question: highlight-API: is loading/querying of individual styles possible? (#2331)
> The colorschemes seem to do the job. Yep, thats the approved method for users to specify colours. The sequence is: 1. `highlighting` maps the Scintilla style numbers to syntactic entity names for each lexer, and 2. `filetypes.common` defines named styles and default styles for them (this is Geany's default colour scheme), and 3. the individual filetype files map syntactic entity names used by that filetypes lexer to named styles, and 4. the colour scheme can override the default styles from `filetypes.common` for the named styles If a user wants different colours for the same syntactic entity in different filetypes they can create new named styles and only use them in some filetypes files, or replace the mapping in the filetype files between entities and style names with a literal style if they only want to change one filetype. There is no API because setting it programatically would break this configuration scheme. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2331#issuecomment-537265651
Re: [Github-comments] [geany/geany] Behavior of line join (#2031)
@LarsGit223 on further consideration I guess join paragraph is useful for some HTMLists who have their paragraphs on one line and similar use-cases and reflow doesn't do the same thing. IRC (without checking) reflow uses the `join_paragraph()` code so its not going to be removable even if it was exposed from line operations. So since it already exists in Geany I guess that although "Join Lines" is technically correct it does not actually describe which lines. So the keybinding should to renamed to "Join Paragraph", added to the Edit menu (eg next to reflow), and documented rather than removal. One day "somebody" will go through the keybindables and find all those not in the menus and add them so they are discoverable, but thats a separate issue. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2031#issuecomment-537259093
Re: [Github-comments] [geany/geany] Html causes segmentation fault (#1882)
@philiprbrenan: can you still re-produce this issue? If yes could you please paste the original text here in the issue rather than an image for testing? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1882#issuecomment-537207100
Re: [Github-comments] [geany/geany] Behavior of line join (#2031)
@elextr: do you really think it's OK to boldly remove the exisiting capability? If yes, maybe we should remove it in Geany core and the new feature "Join lines" (as described above) IMHO is also a good candidate for the Line Operations plugin. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2031#issuecomment-537202381
[Github-comments] [geany/geany] Define text color when setting dark background in find dialog (#2333)
Some Gtk themes define a dark foreground color for selected text, so when we set the background to dark red, it becomes difficult to read. We must therefore set a foreground color that will remain legible against our background. Fixes #2332 You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/2333 -- Commit Summary -- * Define text color when setting dark background -- File Changes -- M data/geany.css (1) M data/geany.gtkrc (1) -- Patch Links -- https://github.com/geany/geany/pull/2333.patch https://github.com/geany/geany/pull/2333.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2333
[Github-comments] [geany/geany] find dialog sets background color with undefined text color when no match is found (#2332)
When a find operation fails to find a match, the find dialog's text entry field sets the background color of selected text to dark red. This is fine if the Gtk theme happens to use a light color for selected text, but for other themes, it makes the text nearly unreadable.  If Geany is going to set a background color here, it should set a foreground color as well, in order to avoid this problem. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2332
Re: [Github-comments] [geany/geany] Close, reopen at same line (#2275)
@gsantner: I think what @philiprbrenan means is that it works fine if you close and re-open Geany. But it does not work as expected if you only close the document in Geany and then re-open it (without closing Geany itself). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2275#issuecomment-537194835
[Github-comments] [geany/geany] Question: highlight-API: is loading/querying of individual styles possible? (#2331)
I like to find the best way to let the user specify colors, e.g. by config, theme or whatever (I am talking about colors for text highlighting here not the UI parts outside the editor widget). The colorschemes seem to do the job. Looking at ```highlight.c``` it seems that every style specified in a colorscheme is loaded to the hash ```named_style_hash```. How can a plugin access a style by its key name? I only found this API call for querying a style but it does not look like it is allowing individual styles: ``` C const GeanyLexerStyle *highlighting_get_style(gint ft_id, gint style_id); ``` Thanks for all answers in advance. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2331
Re: [Github-comments] [geany/geany] Multipaste (#2328)
> @b4n It sounds like you're not really interested in crediting me for fixing > this - does this mean I won't be added to the list of contributors? To be blunt, I really don't care who's credited here :) But I'll happily credit you, my example was not trying to draw it away from you. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2328#issuecomment-537174507
Re: [Github-comments] [geany/geany-plugins] [pair tag highlighter] keyword "font" in a html document (#432)
Should we close this? The ticket is 3 years old and there is no feedback to our questions and it was maybe fixed in the meantime. Can anybody reproduce this? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/432#issuecomment-537172421
[Github-comments] [geany/geany-plugins] pairtaghighlighter: do not stop scanning on linebreaks (#914)
Before this change the plugin stopped scanning for a tag on the start or the end of a line. Therefore tags which were split over multiple lines were not recognized. With this change the plugin scans forward or backward up to a certain limit and does not stop on a linebreak. The default limit is 1024 bytes but it can be changed by configuration if required. Fixes #775. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/914 -- Commit Summary -- * pairtaghighlighter: do not stop scanning on linebreaks -- File Changes -- M pairtaghighlighter/src/pair_tag_highlighter.c (163) -- Patch Links -- https://github.com/geany/geany-plugins/pull/914.patch https://github.com/geany/geany-plugins/pull/914.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/914
Re: [Github-comments] [geany/geany] Multipaste (#2328)
Don't worry guys, all fixed. =) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2328#issuecomment-537102001
Re: [Github-comments] [geany/geany] Multipaste (#2328)
@AdamDanischewski pushed 2 commits. a1a185e87c085d330c15e623f5005886ce5c24b0 Reverted - a blank line at the end was missing 79923d281814d95ffebe1a2cb44381cd31d7d4b1 Moved SC_MULTIPASTE_EACH setting to create_new_sci() where the other direct scintilla settings are. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/2328/files/b78159d71fa989132155ccd879e79ae24df00e76..79923d281814d95ffebe1a2cb44381cd31d7d4b1
Re: [Github-comments] [geany/geany-plugins] No debugger in Geany 1.36 (#913)
Already did it! :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/913#issuecomment-537092132
Re: [Github-comments] [geany/geany] Multipaste (#2328)
@b4n It sounds like you're not really interested in crediting me for fixing this - does this mean I won't be added to the list of contributors? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2328#issuecomment-537078532
Re: [Github-comments] [geany/geany] Multipaste (#2328)
Better. IMO we should just use my version that has all the small things I'd like to see changed here (comment, location of the change (which is my bad because of an incorrect comment, sorry), no leftover unrelated whitespace changes, clearer commit message, no leftover history), but basically I'm now happy with the spirit of the changes here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2328#issuecomment-537073959
Re: [Github-comments] [geany/geany] Multipaste (#2328)
b4n commented on this pull request. > editor->sci = editor_create_widget(editor); + sci_set_multipaste(editor->sci, SC_MULTIPASTE_EACH); My bad, I meant `create_new_sci()` which is the one having the other similar defaults -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2328#discussion_r330101585
Re: [Github-comments] [geany/geany] Multipaste (#2328)
Updated - SC_MULTIPASTE_EACH is now set in geany/src/editor.c::editor_create_widget() without any wrappers since this is now the default. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2328#issuecomment-537068513
Re: [Github-comments] [geany/geany] Multipaste (#2328)
@AdamDanischewski pushed 1 commit. b78159d71fa989132155ccd879e79ae24df00e76 Setting SC_MULTIPASTE_EACH is no longer exposed -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/2328/files/921142866e85a851ca2341f4ce16e96c6d6d6959..b78159d71fa989132155ccd879e79ae24df00e76
Re: [Github-comments] [geany/geany] Multipaste (#2328)
@AdamDanischewski pushed 1 commit. 921142866e85a851ca2341f4ce16e96c6d6d6959 Setting SC_MULTIPASTE_EACH no longer exposed -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/2328/files/f22fc13f9d19b68c5dcac2bba3165dfc575ecaef..921142866e85a851ca2341f4ce16e96c6d6d6959
Re: [Github-comments] [geany/geany] Multipaste (#2328)
@AdamDanischewski pushed 1 commit. f22fc13f9d19b68c5dcac2bba3165dfc575ecaef SC_MULTIPASTE_EACH is default -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/2328/files/63d3a9b04230129a296d991a73388412971966e3..f22fc13f9d19b68c5dcac2bba3165dfc575ecaef
Re: [Github-comments] [geany/geany] Multipaste (#2328)
AdamDanischewski commented on this pull request. > @@ -39,9 +39,10 @@ sptr_t sci_send_message_internal (const gchar *file, guint > line, ScintillaObject # endif #endif -void sci_set_text (ScintillaObject *sci, const gchar *text); -gboolean sci_has_selection (ScintillaObject *sci); -void sci_end_undo_action (ScintillaObject *sci); +voidsci_set_multipaste (ScintillaObject *sci, gint mpval); Again the reason I did this is because @elextr suggested that it should be an option. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2328#discussion_r330068868
Re: [Github-comments] [geany/geany] Multipaste (#2328)
AdamDanischewski commented on this pull request. > @@ -56,162 +57,162 @@ void > sci_set_current_position(ScintillaObject *sci, gint position, gboolean gint sci_get_selection_start (ScintillaObject *sci); gint sci_get_selection_end (ScintillaObject *sci); -void sci_replace_sel (ScintillaObject *sci, const gchar *text); +void sci_replace_sel (ScintillaObject *sci, const gchar *text); The indentation is horrid in this file - I tried to be nice, it won't happen again. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2328#discussion_r330066565
Re: [Github-comments] [geany/geany] Multipaste (#2328)
AdamDanischewski commented on this pull request.
> @@ -93,6 +93,10 @@ sptr_t sci_send_message_internal (const gchar *file, guint
> line, ScintillaObject
}
#endif
+ /* Set multi paste setting (at 3104 scintilla defaults to SC_MULTIPASTE_ONCE)
*/
+void sci_set_multipaste(ScintillaObject *sci, gint mpval) {
+ SSM(sci, SCI_SETMULTIPASTE, mpval, 0);
+}
The reason I did this is because @elextr suggested that it should be an option.
I agree that it should be the only behavior.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2328#discussion_r330064994
