Re: [Github-comments] [geany/geany-plugins] Changes from Wolfgang Schwarz (#317)
Closing due to previous comments. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/317#issuecomment-537767292
Re: [Github-comments] [geany/geany-plugins] Changes from Wolfgang Schwarz (#317)
Closed #317. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/317#event-2682650519
Re: [Github-comments] [geany/geany] Added template file for CSS (#2259)
Closing due to lack of interest, feel free to re-open if anyone feeling strongly comes along. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2259#issuecomment-537766585
Re: [Github-comments] [geany/geany] Added template file for CSS (#2259)
Closed #2259. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2259#event-2682645008
Re: [Github-comments] [geany/geany] Question: highlight-API: is loading/querying of individual styles possible? (#2331)
> The highlighting is already implemented in the plugin, see the code below and > yes it's using indicators Ahh, they followed my advice before I gave it, excellent :grin: > The issue is that the colors are fixed coded into the plugin. Ok, then I strongly suggest just making it manually configurable. Trying to automatically adjust to the theme is tricky because the plugin is highlighting the whole tag and that has different styles for element name, attribute names, and attribute values, so its quite likely that part of a tag will clash unless you somehow consider all the tag styles. I guess you would need to consider the actual colours for SCE_H_TAG, SCE_H_TAGUNKNOWN, SCE_H_ATTRIBUTE, SCE_H_ATTRIBUTEUNKNOWN, SCE_H_NUMBER, SCE_H_DOUBLESTRING, SCE_H_SINGLESTRING, SCE_H_OTHER, SCE_H_COMMENT, SCE_H_ENTITY, SCE_H_TAGEND all of which can occur in a tag IIUC. > So I wondered if there is an already implemented, re-usable way to read in > color/style values. Not that I'm aware of any way, but highlighting[mappings].[hc] is @b4n's baby and maybe its hidden away there somewhere. But plugins can read the styles from Scintilla [eg foreground](https://www.scintilla.org/ScintillaDoc.html#SCI_STYLEGETFORE). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2331#issuecomment-537730757
Re: [Github-comments] [geany/geany] Enhancement Request - Multiselect Multipaste Option (#850)
@Akronix see #2328 for recent developments :grin: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/850#issuecomment-537721423
Re: [Github-comments] [geany/geany] Added template file for CSS (#2259)
IMO @codebrainz said it above. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2259#issuecomment-537720973
Re: [Github-comments] [geany/geany] Show zoom level in status bar. (#1697)
@b4n ping, its your review. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1697#issuecomment-537720414
Re: [Github-comments] [geany/geany] Plugin-API: extended project API (#2234)
elextr approved this pull request. Ok by me. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2234#pullrequestreview-296575052
Re: [Github-comments] [geany/geany] ui_utils: sort the recent file names (#258)
Yup, closed rejected. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/258#issuecomment-537718815
Re: [Github-comments] [geany/geany] ui_utils: sort the recent file names (#258)
Closed #258. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/258#event-2682317871
Re: [Github-comments] [geany/geany-plugins] Changes from Wolfgang Schwarz (#317)
Since it has conflicts and the plugin is orphaned and nobody has done anything for some years I'd say its fair enough to just close. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/317#issuecomment-537718101
Re: [Github-comments] [geany/geany] Save main and project configuration whenever documents are opened/closed (#2114)
Hopefully you'll squash or rebase to avoid the back merge? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2114#issuecomment-537678162
[Github-comments] [geany/geany-plugins] tableconvert: disable menu item on not supported filetypes (#915)
Actually the Tableconvert plugin supports the filetypes HTML, LaTeX and SQL. I suggest that the menu item _"Convert to table"_ should be disabled if the current document's filetype is not supported. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/915
Re: [Github-comments] [geany/geany-plugins] compile error in RaspberryPi (#893)
@abbrdr: any feedback? did you have a chance to try my advice? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/893#issuecomment-537668292
Re: [Github-comments] [geany/geany-plugins] Changes from Wolfgang Schwarz (#317)
> -fixed a bug when one selects text from right to left and then shifts it > (see comment "in case selection_start was after selection_end" in my code) This seems to already have been fixed by @b4n in dc0af51b96d4b98ada550d464b0cd17b24268419. I cannot reproduce any issue on selecting text from the right and shifting it. Works fine. > -When no text is selected, now the current word is exchanged with the > next/previous, which I find quite useful. IMHO this does not fit into this plugin. If someone needs it then a new PR to a different plugin where it fits in or a new plugin is welcome. I vote for closing this un-merged. What do the others think? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/317#issuecomment-537664876
Re: [Github-comments] [geany/geany] Save main and project configuration whenever documents are opened/closed (#2114)
I'm fine with merging. Just solved the merge conflict. If nobody beats me by time or with feedback, I'll merge this on Sunday. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2114#issuecomment-537650233
Re: [Github-comments] [geany/geany] ui_utils: sort the recent file names (#258)
I guess this can be closed? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/258#issuecomment-537638466
Re: [Github-comments] [geany/geany] Plugin-API: extended project API (#2234)
@codebrainz, @elextr: What do you think? Can we merge this? We just had a new release so if this is merged there is plenty of time for testing. I am asking cause a PR for the workbench plugin is depending on this PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2234#issuecomment-537634493
Re: [Github-comments] [geany/geany] Show zoom level in status bar. (#1697)
Can this be merged? I just resolved the conflicts. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1697#issuecomment-537629699
Re: [Github-comments] [geany/geany] Show zoom level in status bar. (#1697)
@LarsGit223 pushed 1 commit. 9ea258374dfb791e19af46c354a01bbdcc4f5a31 Merge branch 'master' into showzoom -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/1697/files/9510042013e1fe0c476c25dce6f1183cb52c85b6..9ea258374dfb791e19af46c354a01bbdcc4f5a31
Re: [Github-comments] [geany/geany] Added template file for CSS (#2259)
@b4n, @codebrainz, @elextr: ping. What's the final decission? Merge or close it unmerged? I'm fine with both, just want to get the ticket done. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2259#issuecomment-537623166
Re: [Github-comments] [geany/geany] Enhancement Request - Multiselect Multipaste Option (#850)
> > Sorry for seeming silly, but what are the two options? > > When there is a rectangular selection and a single item on the clipboard the > choice is to paste the single item into the first row of the selection or to > repeat the single item in every row of the selection. > > Although from #2317 comes the suggestion that if the clipboard is multi-line > that successive lines get pasted into successive rows of the selection, so > now there are three options grin I might be too closed minded here, but I sincerely don't see the user case for the first one. And when I say user case I mean actual user base demanding this one and complaining about having the second one. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/850#issuecomment-537602866
Re: [Github-comments] [geany/geany] Question: highlight-API: is loading/querying of individual styles possible? (#2331)
@elextr:
> Ahh, probably the best would be to use indicators for that,
My question is not about how highlighting itself can be implemented. The
highlighting is already implemented in the plugin, see the code below and yes
it's using indicators:
```
static void highlight_tag(ScintillaObject *sci, gint openingBracket,
gint closingBracket, gint color)
{
scintilla_send_message(sci, SCI_SETINDICATORCURRENT, INDICATOR_TAGMATCH, 0);
scintilla_send_message(sci, SCI_INDICSETSTYLE,
INDICATOR_TAGMATCH, INDIC_ROUNDBOX);
scintilla_send_message(sci, SCI_INDICSETFORE, INDICATOR_TAGMATCH,
rgb2bgr(color));
scintilla_send_message(sci, SCI_INDICSETALPHA, INDICATOR_TAGMATCH, 60);
scintilla_send_message(sci, SCI_INDICATORFILLRANGE,
openingBracket, closingBracket-openingBracket+1);
}
```
The issue is that the colors are fixed coded into the plugin. And as always
this can just be fine for some themes and for others it's causing bad
readability because the color/style cannot be adjusted to the theme.
So I wondered if there is an already implemented, re-usable way to read in
color/style values. Colorschemes does not seem to add a new key and access it
somehow. I would prefer to define a key explicitly for the pairtaghighlighter
plugin. But colorschemes seem to be bound to predefined meanings/styles.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2331#issuecomment-537564659
[Github-comments] [geany/geany] Changed default title length from 30 to 80. (#2335)
Changed the default file name length in the title bar from 30 to 80. Fulfills: Enhancement Request - File Name in Title Bar Too Short #2334 You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/2335 -- Commit Summary -- * Changed default title length from 30 to 80. -- File Changes -- M src/ui_utils.c (2) -- Patch Links -- https://github.com/geany/geany/pull/2335.patch https://github.com/geany/geany/pull/2335.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2335
[Github-comments] [geany/geany] Enhancement Request - File Name in Title Bar Too Short (#2334)
The title of the file that I am working on is truncated in the geany title bar.  I'd like it to show the full name of the file, like this:  This is especially useful when writing unit test cases, the file names are similar and often very long. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2334
