Re: [Github-comments] [geany/geany] Option to wrap searching / replacing around the document (#2887)

2021-09-04 Thread elextr
The developers of the GTK GUI library Geany uses (and indeed the C language it 
uses) have in their wisdom decided that programs must always follow the locale 
set by the LANG environment variable and do not allow program control.  The 
concept of wanting, for example, an IDE in English to match the programming 
language, not the users local dialect is not catered for.   Blame the ISO C 
folks. [end rant]

Therefore you need to set the `LANG` environment variable before you run Geany. 
 So on Linux you run Geany with:

```
LANG=en_GB.UTF-8 geany
```

I note that the new GTK4 version allows that hard coded automatic to be turned 
off so the program can set its language to something different to the system 
setting.  So after somebody made the (major) patches to support GTK4 it might 
be possible  to have a setting in Geany, although it would probably need a 
restart to take effect.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2887#issuecomment-913054237

Re: [Github-comments] [geany/geany] Translation error (#2871)

2021-09-04 Thread gustavo-silva-serra
I can confirm that this is the correct form.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2871#issuecomment-913039436

Re: [Github-comments] [geany/geany-plugins] Geany ctags fixes (#1098)

2021-09-04 Thread Jiří Techet
@eht16 Thanks for giving it a try. Yeah, the find changes should do nothing on 
Windows but the updated readtags library might so good to know it didn't cause 
any problems.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1098#issuecomment-913035123

Re: [Github-comments] [geany/geany] Corrections for the Russian translation (#2888)

2021-09-04 Thread vsl7
@Skif-off
“Зацикливать поиск по документу” is the most appropriate translation for 
“Always wrap search”.
`Find` also will try to find from the end when searching backwards.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2888#issuecomment-913013322

Re: [Github-comments] [geany/geany] Corrections for the Russian translation (#2888)

2021-09-04 Thread Skif-off
`Зацикливать поиск`? These are different things.
We have two ways: from the beginning or from the current place. Without cycles.

> Продолжить поиск с начала / конца?`

What logic? In this window we will see two buttons: `Cancel` and `Find`. 
`Cancel` is a cancel, `Find` will try to find from the beginning of document.

Or I didn't understand something...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2888#issuecomment-913007337

[Github-comments] [geany/geany] Corrections for the Russian translation (#2888)

2021-09-04 Thread vsl7
https://github.com/geany/geany/blob/41624c411702d29834da0ff926f3c9f7c895bb47/po/ru.po#L340
 Should be: `msgstr "Зацикливать поиск по документу"`

https://github.com/geany/geany/blob/41624c411702d29834da0ff926f3c9f7c895bb47/po/ru.po#L344
 Should be: `msgstr "Зацикливать поиск по документу"`

https://github.com/geany/geany/blob/41624c411702d29834da0ff926f3c9f7c895bb47/po/ru.po#L2943
 Should be: `msgstr "Продолжить поиск с начала / конца?"`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2888

Re: [Github-comments] [geany/geany] Option to wrap searching / replacing around the document (#2887)

2021-09-04 Thread vsl7
@eht16 That’s right. I was looking through all settings and didn’t recognize 
this option because of its incorrect Russian translation: “Всегда искать с 
начала файла”. Correct would be “Зацикливать поиск по документу”. Another 
problem is that there is no obvious way to change UI language in Geany.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2887#issuecomment-912986183

Re: [Github-comments] [geany/geany] Option to wrap searching / replacing around the document (#2887)

2021-09-04 Thread Enrico Tröger
Closed #2887.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2887#event-5256424440

Re: [Github-comments] [geany/geany] Option to wrap searching / replacing around the document (#2887)

2021-09-04 Thread Enrico Tröger
We already got that feature: enable "Always wrap search" in the preferences 
dialog.

![geany_always_wrap_search](https://user-images.githubusercontent.com/617017/132094182-397f30df-2423-457e--107bc85824f0.png)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2887#issuecomment-912964827

Re: [Github-comments] [geany/geany-plugins] Geany ctags fixes (#1098)

2021-09-04 Thread Enrico Tröger
LGTM, compiled and tested on Windows (even the change in the `find` command is 
not relevant there) and still works fine.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1098#issuecomment-912964332

[Github-comments] [geany/geany] Option to wrap searching / replacing around the document (#2887)

2021-09-04 Thread vsl7
It would be better to add to the search and replace dialog an option whether to 
wrap around the document (continue from the beginning when the end is reached 
and vice versa). Asking it each time is inconvenient and makes Geany unusable.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2887

[Github-comments] [geany/geany-plugins] SpellCheck: Add notes about maintaining personal dictionaries (#1108)

2021-09-04 Thread Enrico Tröger

You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/1108

-- Commit Summary --

  * SpellCheck:  Add notes about maintaining personal dictionaries

-- File Changes --

M spellcheck/README (18)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/1108.patch
https://github.com/geany/geany-plugins/pull/1108.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1108


Re: [Github-comments] [geany/geany-plugins] Fixed a crash of geany by the git-changebar on SCI_ADDTEXT (#1106)

2021-09-04 Thread Belousov Vladimir
> Agreed, would you mind extending this PR?

@eht16 yeah, sure, I will do it on Monday.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1106#issuecomment-912961664

Re: [Github-comments] [geany/geany-plugins] Fixed a crash of geany by the git-changebar on SCI_ADDTEXT (#1106)

2021-09-04 Thread Enrico Tröger
> > how do you build Geany? I assume in a Mingw64 shell against 
> > "mingw-w64-x86_64-*" packages? I'm wondering why it didn't crash for me.
> 
> @eht16 yeah, I have built Geany from Mingw64 shell against /mingw64/lib and 
> /mingw64/include, i.e against mingw-w64-x86_64 packages. I recently changed 
> my MSYS2 environment, previously it had been x32 MSYS2, now it is x64 MSYS2 
> fresh installed, so I had to rebuilt my Geany instance. The previous Geany 
> instance was x64 with x32 

That might be the difference, I use the same combination as you (Mingw64 shell 
+ /mingw64/lib) but my MSYS2 installation is rather old.
Thanks for the information.

> > For completeness, there are a couple of more occurences with the wrong cast:
> > Should we fix those as well?
> 
> I think these occurrences should be fixed as well. The numbered bookmarks 
> plugin crashed for me also, [...]

Agreed, would you mind extending this PR?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1106#issuecomment-912960524

Re: [Github-comments] [geany/geany-plugins] Fixed a crash of geany by the git-changebar on SCI_ADDTEXT (#1106)

2021-09-04 Thread Belousov Vladimir
> how do you build Geany? I assume in a Mingw64 shell against 
> "mingw-w64-x86_64-*" packages? I'm wondering why it didn't crash for me.
@eht16 yeah, I have built Geany from Mingw64 shell against /mingw64/lib and 
/mingw64/include, i.e against mingw-w64-x86_64 packages. I recently changed my 
MSYS2 environment, previously it had been x32 MSYS2, now it is x64 MSYS2 fresh 
installed, so I had to rebuilt my Geany instance. The previous Geany instance 
was x64 with x32 Scintilla built as DLL (few years ago there were troubles 
building x64 Scintilla).

> For completeness, there are a couple of more occurences with the wrong cast:
> Should we fix those as well?
I think these occurrences should be fixed as well. The numbered bookmarks 
plugin crashed for me also, but I just switched it off, and I don't use the Lua 
plugin and Geanymacro yet. Git-changebar is the only crucial plugin for me in 
the list above.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1106#issuecomment-912959777

[Github-comments] [geany/geany-plugins] Windows full cross build (#1107)

2021-09-04 Thread Enrico Tröger
This is the corresponding PR to Geany https://github.com/geany/geany/pull/2590 
to switch the Windows builds to x86_64 and GTK3.

Main changes:
- the GTK (and other dependencies) bundle is now created for the x86_64 platform
- the new parameter -x allows to run script on a Linux system using 
Wine, therefore it is necessary to run the post-install scripts after all 
packages have been extracted.
- use -Sdd for Pacman to ignore dependencies as we resolve them 
manually
- do not use tar -x --xz as Pacman nowadays also downloads .zst 
packages, instead just download the file and let tar choose the format 
automatically based on the filename
- replace GTK2 by (upcoming) GTK4 in bundle script
- ignore package signatures on bundle creation
- ignore Pacman cache on bundle creation

**Note**: the WebHelper and Markdown plugins are no longer included in the 
Windows G-P installer as there are no (already for a long time) WebKitGTK 
packages available.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/1107

-- Commit Summary --

  * Windows: Remove hard-coded paths and installer name from install script
  * Windows installer: Remove Markdown+WebHelper and update dependencies
  * Windows: Create GTK bundle for x86_64 and support non-native execution
  * Windows: Update bundle dependencies

-- File Changes --

M build/geany-plugins.nsi (138)
M build/gtk-bundle-from-msys2.sh (152)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/1107.patch
https://github.com/geany/geany-plugins/pull/1107.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1107


Re: [Github-comments] [geany/geany] Long Line Marker Issue (#2886)

2021-09-04 Thread Enrico Tröger
The long line marker can only be displayed properly when using a fixed width 
font, i.e. a monospace font.
For all other font types, each columns might have a different width and so 
there is no fixed vertical line possible across multiple lines.

If you choose a monospace font, I assume the long line markers looks like you 
expected. If not, please re-open.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2886#issuecomment-912954863

Re: [Github-comments] [geany/geany] Long Line Marker Issue (#2886)

2021-09-04 Thread elextr
Ubuntu regular is not a monospaced font, so there is no specific pixel position 
to draw a vertical line that is the same column in all lines, it depends on the 
content of the line.  IIRC the position used is a line of spaces which will 
compress in a non-monospaced font.

If you really want to use a non-monospaced font and still want long line 
indication, then set the long line to background (Preferences->Editor->Display) 
which is something that can be shown differently for each text line.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2886#issuecomment-912954878

Re: [Github-comments] [geany/geany] Long Line Marker Issue (#2886)

2021-09-04 Thread Enrico Tröger
Closed #2886.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2886#event-5256363161

Re: [Github-comments] [geany/geany-plugins] Fixed a crash of geany by the git-changebar on SCI_ADDTEXT (#1106)

2021-09-04 Thread Enrico Tröger
Tested on Windows, also against a x86_64 build and works.

However, Geany didn't crash on my system without the change. I still consider 
the change as correct.

@vlvlbel for my curiosity, how do you build Geany? I assume in a Mingw64 shell 
against  "mingw-w64-x86_64-*" packages? I'm wondering why it didn't crash for 
me.

For completeness, there are a couple of more occurences with the wrong cast:
```
geanylua/glspi_sci.c:   if (len) { 
scintilla_send_message(doc->editor->sci,SCI_COPYTEXT,len,(glong)content); }
geanymacro/src/geanymacro.c:
scintilla_send_message(sci,me->message,me->wparam,(glong)clipboardcontents);
geanymacro/src/geanymacro.c:
me->lparam=(glong)(g_strcompress(s[(*k)++]));
geanymacro/src/geanymacro.c:me->lparam=(glong)NULL;
geanymacro/src/geanymacro.c:
me->lparam=(glong)(g_strcompress(s[(*k)++]));
geanymacro/src/geanymacro.c:?((glong) g_strdup((gchar 
*)(nt->lParam))) : nt->lParam;
geanymacro/src/geanymacro.c:
me->lparam=(glong)((cTemp!=NULL)?g_strdup(cTemp):g_strdup(""));
geanymacro/src/geanymacro.c:
me->lparam=(glong)(((*cTemp2)==0)?NULL:g_strdup(cTemp2));
geanynumberedbookmarks/src/geanynumberedbookmarks.c:
scintilla_send_message(sci,SCI_MARKERDEFINEPIXMAP,m,(glong)(aszMarkerImages[k]));
git-changebar/src/gcb-plugin.c:  scintilla_send_message (sci, SCI_ADDTEXT, 
buf_len, (glong) buf);
git-changebar/src/gcb-plugin.c:  scintilla_send_message (old_sci, SCI_ADDTEXT, 
old_buf_len, (glong) old_buf);
```
Should we fix those as well?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1106#issuecomment-912951650

[Github-comments] [geany/geany] Long Line Marker Issue (#2886)

2021-09-04 Thread Neopolitan
I am currently running Geany 1.36 on Linux Mint. 

It seems that the column size doesn't scale properly, or possibly at all, when 
you change your font size or font face.

I changed my editor font to Ubuntu Regular 14pt and found that the drawn line 
from Long line market, set at 72 columns, drew the line at 32 characters, give 
or take.

I am new to geany and bug reporting in general, so I apologize in advance if 
this is a duplicate, is expected behavior, or is otherwise an invalid report.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2886