Re: [Github-comments] [geany/geany] Update C++ compiler check to require C++17 (#2862)

[elextr]

I don't have a non-c++17 compiler to test, if there are no other objections or 
alternatives will merge it in a week or so.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2862#issuecomment-913261882

Re: [Github-comments] [geany/geany] Remove redundant code (#2890)

[elextr]

Closed #2890.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2890#event-5258105852

Re: [Github-comments] [geany/geany] Remove redundant code (#2890)

[elextr]

Thanks but, the code in the ctags directory is imported mostly unchanged from 
Universal ctags project, so anything changed in that will simply be re-instated 
when the ctags version is updated.   

There is likely to be a lot of unused stuff there and we just let the linker 
leave out unused functions.  For `static` ones like those hopefully either the 
compiler or the linker will omit them.  If not well they don't add up to much 
compared to the effort to remove them, the idea is to use ctags as little 
changed as possible so updates are easy.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2890#issuecomment-913260464

Re: [Github-comments] [geany/geany] warning: explicitly defaulted move constructor is implicitly deleted (#2891)

[elextr]

That code is from the Scintilla project so needs to be reported there, although 
you do need to check it still happens because this is Scintilla 3.5 and its now 
up to 5.1.

Also for this sort of report always specify the compiler version and options 
you are using.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2891#issuecomment-913257254

Re: [Github-comments] [geany/geany] Use "encoding" keyword argument for lxml's tostring() (#2885)

[Enrico Tröger]

I justed checked again with Debian Stable (Bullseye), Old-Old-Stable (Stretch) 
and Ubuntu 18.04.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2885#issuecomment-913233725

Re: [Github-comments] [geany/geany] Windows: Do not manually realize the main window prematurely (#2892)

[Enrico Tröger]

I wish I could. But as said in the issue, I've tested all what I could think of 
what might be related and I didn't manage to break it :).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2892#issuecomment-913231820

Re: [Github-comments] [geany/geany] Use "encoding" keyword argument for lxml's tostring() (#2885)

[Colomban Wendling]

Does that work with older (yet not so ancient they don't matter) libxml?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2885#issuecomment-913228658

Re: [Github-comments] [geany/geany] Windows: Do not manually realize the main window prematurely (#2892)

[Colomban Wendling]

@b4n approved this pull request.

Fair enough, and it you tell me it doesn't break anything there, I'm happy :)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2892#pullrequestreview-746684050

Re: [Github-comments] [geany/geany] Translation error (#2871)

[Wellington Almeida]

Perfectly

Em sáb., 4 de set. de 2021 às 17:54, gustavo-silva-serra <
***@***.***> escreveu:

> I can confirm that this is the correct form.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> , or
> unsubscribe
> 
> .
> Triage notifications on the go with GitHub Mobile for iOS
> 
> or Android
> .
>
>


-- 
Wellington Almeida
Rio de Janeiro - Brasil


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2871#issuecomment-913228200

Re: [Github-comments] [geany/geany] Fix clang warnings: Use empty array instead of NULL pointer (#2889)

[Colomban Wendling]

@b4n requested changes on this pull request.

The C standard forbids zero-size arrays.  Yes, 
[GCC](https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html) and Clang do allow 
them as an extension (yet it's not *truly* 0-sized, but basically a VLA), GCC 
even discourages usage in your use case:
> Declaring zero-length arrays [anywhere but as the last member of a 
> structure], including as interior members of structure objects or as 
> non-member objects, is discouraged

At any rate, it's not valid ISO C, so any compiler would be right to forbid it. 
 And both GCC and Clang are unhappy about them when passed `-pedantic` (GCC: 
*error: zero or negative size array ‘foo’*, CLang: *warning: zero size arrays 
are an extension [-Wzero-length-array]*).

---
It's sad Clang doesn't see that the `NULL` check makes its warning moot, but 
the fix you propose is not OK as it's not valid C -- and thus likely rejected 
(rightly) by some compilers (I would guess MSVC might not like it, and maybe 
some other less common ones).



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2889#pullrequestreview-746683433

Re: [Github-comments] [geany/geany] Windows/GTK3: Message window reduces its height after restart (#2591)

[Enrico Tröger]

Thanks guys, for your suggestions.

Was could it have been?

- CSD
- any kind of timing issue related to setting the pane position
- nor a GTK bug
- ...

And the winner is:
some old _eht16-Windows-special-hack_

For reasons I don't remember anymore, I added in 
https://github.com/geany/geany/commit/9431eea2445ccf191777cf3667a9292cf4ddcb65 
(in 2009) a Windows only change to realize the main windows *before* setting 
the window geometry and position.
Maybe it was related to off-screen window positions or so. Or some GTK2 
behavior required it which is no longer the case.

After removing the `gtk_widget_realize` call, the message window height is 
stable, i.e. stays at where is has been left off. Also, I couldn't find any 
other negative impact of the removed call, even weird off-screen positions 
worked as expected (the window is moved to the visible screen area).

Too bad I don't know why the realize call was added initially :(.
At least, it pretty good explains why it happened only on Windows. Apparently, 
something in GTK3 has changed in that regard.

#2892 is here to fix it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2591#issuecomment-913163137

[Github-comments] [geany/geany] Windows: Do not manually realize the main window prematurely (#2892)

[Enrico Tröger]

This has been added in 9431eea24 but seems no longer necessary and actually 
causes problems with setting the message window height. After each start of 
Geany, the message window will be set a bit lower until it is not visible 
anymore at all.
The manual realize step was maybe necessary with older GTK2 versions but 
actually works contrarily on recent GTK3 builds.

Fixes #2591.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/2892

-- Commit Summary --

  * Windows: Do not manually realize the main window prematurely

-- File Changes --

M src/libmain.c (5)

-- Patch Links --

https://github.com/geany/geany/pull/2892.patch
https://github.com/geany/geany/pull/2892.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2892

Re: [Github-comments] [geany/geany] Corrections for the Russian translation (#2888)

[vsl7]

@Skif-off To wrap searching or replacing is to continue it from the beginning 
when the end is reached and vice versa. And it’s better to use spaces around 
`/`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2888#issuecomment-913157209

[Github-comments] [geany/geany] warning: explicitly defaulted move constructor is implicitly deleted (#2891)

[Avinash Sonawane]

Hello!

On latest master `clang` throws these warnings:
```
In file included from src/ViewStyle.cxx:26:
./src/Style.h:76:2: warning: explicitly defaulted move constructor is 
implicitly deleted [-Wdefaulted-function-deleted]
Style(Style &&) = default;
^
./src/Style.h:71:12: note: move constructor of 'Style' is implicitly deleted 
because field 'font' has a deleted move constructor
FontAlias font;
  ^
./src/Style.h:38:2: note: 'FontAlias' has been explicitly marked deleted here
FontAlias(FontAlias &&)  = delete;
^
```

Thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2891

[Github-comments] [geany/geany] Remove redundant code (#2890)

[Avinash Sonawane]

Hello!

While chasing down these `clang` warnings I found that some code is redundant 
and can be safely removed:
```
main/parse.c:5007:26: warning: unused function FallbackParser 
[-Wunused-function]
static parserDefinition *FallbackParser (void)
 ^
main/parse.c:5040:26: warning: unused function CTagsParser 
[-Wunused-function]
static parserDefinition *CTagsParser (void)
 ^
main/parse.c:5355:26: warning: unused function CTagsSelfTestParser 
[-Wunused-function]
static parserDefinition *CTagsSelfTestParser (void)
 ^
```

This is because we explicitly define `EXTERNAL_PARSER_LIST ` in tm_parsers.h at 
https://github.com/geany/geany/blob/master/src/tagmanager/tm_parsers.h#L16 so 
guess no need to check for not defined case?

Thanks!
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/2890

-- Commit Summary --

  * Remove redundant code

-- File Changes --

M ctags/main/parse.c (338)
M ctags/main/parse_p.h (13)

-- Patch Links --

https://github.com/geany/geany/pull/2890.patch
https://github.com/geany/geany/pull/2890.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2890

[Github-comments] [geany/geany] Fix clang warnings: Use empty array instead of NULL pointer (#2889)

[Avinash Sonawane]

Hello!

At present, `clang` throws these warnings on master:
```
highlighting.c:1011:3: warning: sizeof (((HLKeyword *)((void *)0))) 
will return the size of the pointer, not the array itself [-Wsizeof-pointer-div]
init_styleset_case(CONF);
^~~~
highlighting.c:966:5: note: expanded from macro init_styleset_case

HL_N_ENTRIES(highlighting_keywords_##LANG_NAME)); \
^~~
./highlightingmappings.h:72:48: note: expanded from macro HL_N_ENTRIES
#define HL_N_ENTRIES(array) ((array != NULL) ? G_N_ELEMENTS(array) : 0)
   ^~~
/usr/include/glib-2.0/glib/gmacros.h:820:42: note: expanded from macro 
G_N_ELEMENTS
#define G_N_ELEMENTS(arr)   (sizeof (arr) / sizeof ((arr)[0]))
  ^
highlighting.c:1014:3: warning: sizeof (((HLKeyword *)((void *)0))) 
will return the size of the pointer, not the array itself [-Wsizeof-pointer-div]
init_styleset_case(DIFF);
^~~~
highlighting.c:966:5: note: expanded from macro init_styleset_case

HL_N_ENTRIES(highlighting_keywords_##LANG_NAME)); \
^~~
./highlightingmappings.h:72:48: note: expanded from macro HL_N_ENTRIES
#define HL_N_ENTRIES(array) ((array != NULL) ? G_N_ELEMENTS(array) : 0)
   ^~~
/usr/include/glib-2.0/glib/gmacros.h:820:42: note: expanded from macro 
G_N_ELEMENTS
#define G_N_ELEMENTS(arr)   (sizeof (arr) / sizeof ((arr)[0]))
  ^
highlighting.c:1032:3: warning: sizeof (((HLKeyword *)((void *)0))) 
will return the size of the pointer, not the array itself [-Wsizeof-pointer-div]
init_styleset_case(MAKE);
^~~~
highlighting.c:966:5: note: expanded from macro init_styleset_case

HL_N_ENTRIES(highlighting_keywords_##LANG_NAME)); \
^~~
./highlightingmappings.h:72:48: note: expanded from macro HL_N_ENTRIES
#define HL_N_ENTRIES(array) ((array != NULL) ? G_N_ELEMENTS(array) : 0)
   ^~~
/usr/include/glib-2.0/glib/gmacros.h:820:42: note: expanded from macro 
G_N_ELEMENTS
#define G_N_ELEMENTS(arr)   (sizeof (arr) / sizeof ((arr)[0]))
  ^
highlighting.c:1034:3: warning: sizeof (((HLKeyword *)((void *)0))) 
will return the size of the pointer, not the array itself [-Wsizeof-pointer-div]
init_styleset_case(MARKDOWN);
^~~~
highlighting.c:966:5: note: expanded from macro init_styleset_case

HL_N_ENTRIES(highlighting_keywords_##LANG_NAME)); \
^~~
./highlightingmappings.h:72:48: note: expanded from macro HL_N_ENTRIES
#define HL_N_ENTRIES(array) ((array != NULL) ? G_N_ELEMENTS(array) : 0)
   ^~~
/usr/include/glib-2.0/glib/gmacros.h:820:42: note: expanded from macro 
G_N_ELEMENTS
#define G_N_ELEMENTS(arr)   (sizeof (arr) / sizeof ((arr)[0]))
  ^
highlighting.c:1040:3: warning: sizeof (((HLKeyword *)((void *)0))) 
will return the size of the pointer, not the array itself [-Wsizeof-pointer-div]
init_styleset_case(PO);
^~
highlighting.c:966:5: note: expanded from macro init_styleset_case

HL_N_ENTRIES(highlighting_keywords_##LANG_NAME)); \
^~~
./highlightingmappings.h:72:48: note: expanded from macro HL_N_ENTRIES
#define HL_N_ENTRIES(array) ((array != NULL) ? G_N_ELEMENTS(array) : 0)
   ^~~
/usr/include/glib-2.0/glib/gmacros.h:820:42: note: expanded from macro 
G_N_ELEMENTS
#define G_N_ELEMENTS(arr)   (sizeof (arr) / sizeof ((arr)[0]))
  ^
highlighting.c:1050:3: warning: sizeof (((HLKeyword *)((void *)0))) 
will return the size of the pointer, not the array itself [-Wsizeof-pointer-div]
init_styleset_case(TXT2TAGS);
^~~~
highlighting.c:966:5: note: expanded from macro init_styleset_case

HL_N_ENTRIES(highlighting_keywords_##LANG_NAME)); \
^~~

Re: [Github-comments] [geany/geany] Corrections for the Russian translation (#2888)

[Skif-off]

It seems now I began to understand what you want to say, but "Продолжать" is a 
wrong: "Always wrap search" is about the beginning of the search, not a 
continuation.


To be honest, I'm not sure it is necessary to change/fix urgently. Or is it a 
habit? :) Мaybe something like
```po
msgid "Always wrap search"
msgstr "Всегда искать по кругу"

msgid "Always wrap search around the document"
msgstr "Всегда выполнять поиск по кругу по всему документу"


msgid "Wrap search and find again?"
msgstr "Повторить поиск с начала/конца?"
```
?

P.S. Don't use spaces around "/" (as in other strings).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2888#issuecomment-913132513