[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-03 Thread elextr via Github-comments
> I would suggest to provide Windows installer. Most of the users will still 
> use official installer who are not familiar with msys2 and its packaging 
> system.

But as I said above, none of the major contributors use Geany on Windows, even 
the nice guy who makes the build (and yes with installer) so its virtually 
untested.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3811#issuecomment-2036208896
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-03 Thread Biswapriyo Nath via Github-comments
> Maybe we can stop making a build for Windows (hopeful).

I would suggest to provide Windows installer. Most of the users will still use 
official installer who are not familiar with msys2 and its packaging system.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3811#issuecomment-2036203592
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-03 Thread elextr via Github-comments
> geany 2.0 is built with meson in msys2 project

Maybe we can stop making a build for Windows (hopeful).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3811#issuecomment-2036200273
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-03 Thread Biswapriyo Nath via Github-comments
> Is that harmless on Linux builds?

The `win_subsystem` option is valid for Windows target only.

geany 2.0 is built with meson in msys2 project, see 
https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-geany/PKGBUILD

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3811#issuecomment-2036181922
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] meson: correctly set WIN32 in config.h (PR #3660)

2024-04-03 Thread Biswapriyo Nath via Github-comments
> Is `_WIN32` set for cross builds?

`_WIN32` is set in compiler which targets Windows platform - no header or IDE 
is required. You can verify that using `cc -dM -E - < /dev/null | grep WIN32` 
command.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3660#issuecomment-2036167518
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-03 Thread elextr via Github-comments
Is that harmless on Linux builds?   If not it needs to be conditioned 
appropriately the same as `win_src` and `vte_src` are, probably best if its 
done anyway, even if harmless at this point, since Meson has a habit of 
increasing strictness and creating errors of previously acceptable things.

I am not sure that the meson build has been tested on Windows, the Windows 
builds for Geany are usually cross built from Linux.  Basically there are no 
Windows users amongst the regular Geany contributors, so a Grumpy olde guy like 
me says drop the Windows build until somebody(s) using Windows support it, but 
the really nice guy who makes the builds keeps doing it even though he doesn't 
use it.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3811#issuecomment-2035799889
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] RFE: markdown plugin - option to synchronize views (Issue #1267)

2024-04-03 Thread elextr via Github-comments
Plugins are submitted by and maintained by individuals named in the Maintainers 
file.  Although Markdown is listed as "maintained" nothing has been heard from 
the maintainer for years, so requests may indeed be yelling into a void.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1267#issuecomment-2035788200
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] meson: correctly set WIN32 in config.h (PR #3660)

2024-04-03 Thread elextr via Github-comments
Is `_WIN32` set for cross builds?  For Geany Windows builds are usually cross 
built on Linux.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3660#issuecomment-2035767733
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] meson: correctly set WIN32 in config.h (PR #3660)

2024-04-03 Thread Biswapriyo Nath via Github-comments
> And they are in ctags code, so this would have to be fixed upstream.

I have created a pull request to fix it in upstream ctags repository.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3660#issuecomment-2035221498
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] RFE: markdown plugin - option to synchronize views (Issue #1267)

2024-04-03 Thread greytomorrow via Github-comments
So @herrdeh knows they're not yelling into the void, :100: This feature is 
absolutely necessary.

I must add that whenever an edit is made, no matter where, the markdown preview 
**always jumps to the beginning** of the document, losing the point where the 
user was working. One has to scroll through the markdown preview to find where 
they'd left off.

Thank you.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1267#issuecomment-2034984541
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-03 Thread Biswapriyo Nath via Github-comments
This would be similar as `-mwindows` flag in src/Makefile.am 
https://github.com/geany/geany/blob/3a92129d61d4d8e96136e29d4709bb638527be40/src/Makefile.am#L157

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3811#issuecomment-2034823993
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-03 Thread Biswapriyo Nath via Github-comments
Previously, a console window is shown in background when geany.exe is executed. 
This change fixes the above issue by specifying _windows_ subsystem type.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/3811

-- Commit Summary --

  * meson: Prevent showing console after running geany in Windows

-- File Changes --

M meson.build (3)

-- Patch Links --

https://github.com/geany/geany/pull/3811.patch
https://github.com/geany/geany/pull/3811.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3811
You are receiving this because you are subscribed to this thread.

Message ID: