[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
Tested... Seems to work. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2080360294 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)
> hum… @elextr @xiota so what's your conclusion? Depend on libsoup3 as this PR > because it's HTTP, or depend on a GVFS backend for HTTP? Waiting for https://github.com/geany/geany-plugins/pull/1340#issuecomment-2079741003 If it works `?` #1340 `:` #1336 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2080317675 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Geany segfaults after clicking in a new documents text area. (Issue #3857)
Duplicate of #2736 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3857#issuecomment-2080307580 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Geany segfaults after clicking in a new documents text area. (Issue #3857)
Closed #3857 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3857#event-12629720274 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] When closing the current tab, move to the tab on the left, not on the right (Issue #3855)
Closed #3855 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3855#event-12629711665 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
@elextr approved this pull request. Bearing in mind my lack of knowledge of libsoup it looks ok. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#pullrequestreview-2026126069 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Various small WebHelper improvements (PR #1295)
@elextr commented on this pull request.
> @@ -950,6 +1005,23 @@ gwh_browser_set_uri (GwhBrowser *self,
g_free (real_uri);
}
+gboolean
+gwh_browser_set_uri_from_document (GwhBrowser*self,
+ GeanyDocument *doc)
+{
+ gchar *uri;
+
+ /* document must exist on disk */
+ if (! doc || ! doc->real_path)
+return FALSE;
+
+ uri = g_strconcat ("file://", doc->file_name, NULL);
Ok, I forgot the inconsistency that sometimes paths are called paths and
sometimes filenames in C land, ... sigh @elextr goes back to his nice
consistent C++ `std::path` :grin:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1295#discussion_r1581662031
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
Many pastebins dont work, but its not new to the changes here… CC @xiota @jbicha You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1342 -- Commit Summary -- * geniuspaste: Port to libsoup3 * geniuspaste: Remove use of deprecated GTK API -- File Changes -- M build/geniuspaste.m4 (3) M geniuspaste/README (4) M geniuspaste/src/geniuspaste.c (95) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1342.patch https://github.com/geany/geany-plugins/pull/1342.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1...@github.com
[Github-comments] [geany/geany-plugins] projectorganizer: Add popup panel for navigation (PR #1341)
This feature allows quick navigation do document/workspace symbols based on their names, open files, and line numbers. The panels code is mostly stolen from the LSP plugin which in turn stole it from the Colomban Wendlings Commander plugin. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1341 -- Commit Summary -- * projectorganizer: Add popup panel for navigation -- File Changes -- M projectorganizer/README (6) M projectorganizer/src/Makefile.am (6) A projectorganizer/src/prjorg-goto-anywhere.c (332) A projectorganizer/src/prjorg-goto-anywhere.h (28) A projectorganizer/src/prjorg-goto-panel.c (496) A projectorganizer/src/prjorg-goto-panel.h (59) M projectorganizer/src/prjorg-menu.c (55) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1341.patch https://github.com/geany/geany-plugins/pull/1341.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1341 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1...@github.com
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)
@xiota I don't think we need to explore a *different* additional HTTP library; either we only use what's already part of the general GTK stack, or using libsoup which is also a direct or indirect dependency of 3 other plugins is fine. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340#issuecomment-2079813014 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)
Guys, be a bit patient :D. I'll test this on Windows/MSYS2 later or in the next days. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340#issuecomment-2079741003 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)
> > For "table" and "itemize" there is a trailing space after the cursor > > marker. Is this intended? > > "block" uses no indentation at all, "itemize" uses a tab resp. spaces and > > "table" uses a single space only. > > This is fixed. I tried to re-sync the indentions I cannot verify as I do not know what is the purposed variant. To me it looks inconsistent:  More importantly, the rubbisch after the "block" environment is because `g_strconcat()` must always be NULL-terminated which it is not in the newly added code. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1330#issuecomment-2079738972 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)
@eht16 commented on this pull request.
> - tmp = g_strdup_printf("\n\\end{%s}", environment);
- glatex_insert_string(tmp, FALSE);
- g_free(tmp);
-
- indention_prefs = editor_get_indent_prefs(doc->editor);
- if (type == GLATEX_ENVIRONMENT_TYPE_LIST)
- {
- sci_set_line_indentation(doc->editor->sci,
- sci_get_current_line(doc->editor->sci),
- indent + indention_prefs->width);
+ if (type == GLATEX_ENVIRONMENT_TYPE_LIST)
+ {
+ tmpstring = g_strconcat(
+ "\\begin{",
+ environment,
+ "}\n\t\\item %cursor% \n\\end{",
There is still a trailing space.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1330#pullrequestreview-2025456762
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)
I think a problem with gio method is depends on gvfs (gnome) and not available on msys2 and brew (win/mac). Wondering now about libcurl vs libsoup. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340#issuecomment-2079619971 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)
See #1340 if wanted. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2079550087 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)
Same as #1336 but using GIO instead of libsoup. If wanted? CC @elextr @xiota @frlan. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1340 -- Commit Summary -- * updatechecker: Port to libsoup3 * updatechecker: Dont leak the libsoup session * updatechecker: Avoid a deprecated call * updatechecker: Remove weird German quotes * updatechecker: Port from libsoup to plain GIO -- File Changes -- M build/updatechecker.m4 (2) M updatechecker/README (6) M updatechecker/src/updatechecker.c (145) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1340.patch https://github.com/geany/geany-plugins/pull/1340.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1...@github.com
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)
Note that writing an async version of the feature, while reasonably easy, is a little bit more work. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2079476011 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)
hum… @elextr @xiota so what's your conclusion? Depend on libsoup3 as this PR because it's HTTP, or depend on a GVFS backend for HTTP? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2079474204 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Various small WebHelper improvements (PR #1295)
@b4n commented on this pull request.
> @@ -950,6 +1005,23 @@ gwh_browser_set_uri (GwhBrowser *self,
g_free (real_uri);
}
+gboolean
+gwh_browser_set_uri_from_document (GwhBrowser*self,
+ GeanyDocument *doc)
+{
+ gchar *uri;
+
+ /* document must exist on disk */
+ if (! doc || ! doc->real_path)
+return FALSE;
+
+ uri = g_strconcat ("file://", doc->file_name, NULL);
No, `doc->real_path` is used to verify the document is actually saved to a
file, but it's in locale encoding, whereas `doc->file_name` is the expected
UTF-8. Admittedly, it might not behave properly if the locale is non-UTF-8 and
the file path contains non-ASCII characters; but at least the worse that would
happen would be the file not being found.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1295#discussion_r1581062630
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] [FR] Use XDG desktop portal filechooser instead GTK on Linux/BSD (Issue #3458)
The main issue with native dialogs/portals, is that they have reduced feature set, see e.g. [GtkFileChooserNative](https://docs.gtk.org/gtk3/class.FileChooserNative.html). And some might be a problematic trade-off for our use cases. Also note that I can't read anything in the link above about the portals being used outside of a sandboxed app, so I'm not sure if it would happen. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3458#issuecomment-2079420019 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] [FR] Use XDG desktop portal filechooser instead GTK on Linux/BSD (Issue #3458)
> GTK4 (if Geany ever gets there) has a > [native](https://docs.gtk.org/gtk4/class.FileChooserNative.html) file chooser > for Windows and Macos, but not Qt (can't think why not ;-) Actually, the native file chooser is indeed for Qt if the app calling it is run on Plasma or another Qt environment. The "native file chooser" just calls out to the XDG portal. And GTK3 already has that API as well. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3458#issuecomment-2079406956 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)
Yeah I guess using GIO directly for this kind of super simple GET would make sense Indeed. I also think that gvfs will indeed be part of all reasonable GIO installations, but I could be wrong. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2079187953 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)
Someone could run the test program on windows or mac to find out. I no longer have (easy) access to either. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2078735830 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)
Well, I interpret the very first words in the readme "GVfs is a userspace virtual filesystem implementation for GIO" to mean its part of GIO. IIUC it provides the implementations for the abstract file/URL/dbus stream operations in GIO and thats why you get an error if its not installed and you try to read anything other than a local file. Never mind, its was worth a try, and thanks for writing that test program. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2078728259 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)
It is separate from GIO. This is the project page: https://gitlab.gnome.org/GNOME/gvfs Debian package, appears to be `gvfs-backends` -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2078714133 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)
> Looks like it depends on gvfs... After uninstalling... Well, IIUC GVFS is _part_ of GIO (not to be confused with GnomeVFS), so if its uninstalled its not surprising parts of GIO don't work. But that probably means reading URLs won't work on Windows, dunno about Macos, so back to the soup I guess :stuck_out_tongue_winking_eye: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2078709049 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)
I use whatever is provided by the package manager. Even on Debian, pkg-config is a dummy package that redirects to pkgconf. Their stance doesn't seem particularly "aggressive" in context because they call out "passive-aggressive people who try to argue with us". Seems they probably had some people who opened numerous issues reporting closely related problems that they were told multiple times are not bugs. It would be like... what if someone opened multiple issues for Geany complaining that it doesn't support various Qt6 features despite being told multiple times that they aren't bugs? Eventually, those complaints could be considered intentionally disruptive, and people who "insist" on continuing need to be cut off. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2078702112 You are receiving this because you are subscribed to this thread. Message ID:
