[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)
@rdipardo @techee thanks for testing, so apart from the inconsistent theming issue it seems to work. @techee you said in the OP "where the GTK dialogs don't offer the best user experience.". Can you expand on that and why " using native dialogs under Windows and macOS is more important IMO."? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3861#issuecomment-2084346252 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)
File filters work both on Windows and macOS:  https://github.com/geany/geany/assets/713965/03616e82-594b-4921-be10-ce999eb38167;> -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3861#issuecomment-2083787087 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)
@techee pushed 1 commit. 2bf55c0d6657fa0a80ffd573316c47308d9ba581 Use filters with GtkFileChooserNative -- View it on GitHub: https://github.com/geany/geany/pull/3861/files/d1d16fa03df309916acf577a2df2a97cf7d419d9..2bf55c0d6657fa0a80ffd573316c47308d9ba581 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)
> No need to build yourself, a full installer with the changes can be downloaded from the CI builds: https://github.com/geany/geany/actions/runs/8869590862 Nice, I didn't know about that. The screenshot below comes from Windows 11, Geany on the left, Notepad++ on the right. The only difference I see is the file type selection that Notepad++ offers. I ifdef'ed that out in this patch thinking it wouldn't work but maybe it does - I'll try that.  -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3861#issuecomment-2083733722 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)
> Windows 10/11 feedback would be great So far so good on a stock Win 10 (22H2) VM with native dark mode active (i.e. `AppsUseLightTheme` == `0`):1. https://github.com/geany/geany/assets/59004801/ef76157a-d5ae-4111-b147-ce6a4ce91945;> > Also I presume the native dialogs are themed by the platform, not by GTK > themes The screen capture and Registry values below confirm as much. At least it's not launching the XP-era file dialogue that caused #3209 --- 1. ~~~sh-session $ reg query "HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Themes\Personalize" /se # HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Themes\Personalize ColorPrevalenceREG_DWORD0x0 EnableTransparencyREG_DWORD0x0 AppsUseLightThemeREG_DWORD0x0 SystemUsesLightThemeREG_DWORD0x0 ~~~ -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3861#issuecomment-2083492646 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)
>Somebody who has Windows 11 and can build Geany with this needs to >test as well. No need to build yourself, a full installer with the changes can be downloaded from the CI builds: https://github.com/geany/geany/actions/runs/8869590862 Windows 10/11 feedback would be great, I can only test on Windows 7 which is unsupported and not representative. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3861#issuecomment-2081961546 You are receiving this because you are subscribed to this thread. Message ID:
