[Github-comments] Re: [geany/geany] Selection color changed in default theme but the changed color doesn't take effect if the "Find" dialog box is open. The changed color takes effect only when the "F
> I click next on the find box and the text is highlighted in grey. The found text is not simply highlighted, it is selected, so what is shown is the unfocused selection style, which as above is hard coded to `#xc0c0c0`. > In notepad, the matched text is highlighted in blue So Notepad either simply highlights the found text in blue, which is not focus dependent, or uses a new enough Scintilla that the unfocused selection style setting is available and is set to blue. Bottom line is, as I said above, if/when Geany uses a new enough Scintilla it will be possible to add settings to `filetypes.common` for unfocused (inactive) selection so anybody or any colour scheme can set its own. But Geany is a totally volunteer project so "somebody" has to do it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3874#issuecomment-2119724375 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Selection color changed in default theme but the changed color doesn't take effect if the "Find" dialog box is open. The changed color takes effect only when the "F
Hi, In my issue there is no case of dimming. I open the Find box. There is no selection right now. I click next on the find box and the text is highlighted in grey. I haven't observed this behaviour in MS Word, Notepad, Netbeans, etc. In notepad, the matched text is highlighted in blue while the find box is still open and the find box has the focus. If a popup opens then you can dim the current selection. But if the job of the popup is to highlight text then it should use some contrasting color because in most of the cases the text is black/dark. Even in dark mode, it is not necessary that the text will be in white. I have tried some dark themes in Geany but I like the default theme more than other themes. Regards, Amit -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3874#issuecomment-2119668461 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Please just add a -i in the geany.desktop for not stuck in "other use socket" improperly. (Issue #3871)
> > The socket file message probably means either Geany crashed > Does it lead to this? I don't think so Crashed ... as another user, eg database_admin ... -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3871#issuecomment-2119456562 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Update ctags to p6.1.20240519.0 (PR #3877)
> Just thinking, in #3859 I mapped matlab variables to `tm_tag_variable_t` so > they are displayed in the sidebar but maybe the result is a little too > verbose. Especially since it generates a tag for every variable assignment - > I just tried it with some random code from github and it displays lots of > identical variables in the sidebar, just every time the variable gets > assigned. > > So shouldn't we rather map it to `tm_tag_undef_t`? Hum yeah if it's gonna tag every variable assignment in the file regardless of scope, it's probably better to disable indeed, otherwise the more useful tags are likely gonna be hard to find. Maybe `tm_local_var_t` if we want, to still have goto stuff? Not sure if it's really useful though. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3877#issuecomment-2119389405 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Update ctags to p6.1.20240519.0 (PR #3877)
@b4n commented on this pull request.
Wanna laugh? https://github.com/universal-ctags/ctags/pull/4008 :smile:
> @@ -951,6 +951,7 @@ static TMParserMapEntry map_POWERSHELL[] = {
{'c', tm_tag_class_t}, // class
{'i', tm_tag_function_t}, // filter
{'g', tm_tag_enum_t}, // enum
+ {'e', tm_tag_undef_t}, // enumlabel
Should be mapped to `tm_tag_enumerator_t`, shouldn't it? It's usually mapped
to `"Variables"` / `TM_ICON_VAR` apparently (but here enumerators are always
gonna have a parent).
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3877#pullrequestreview-2065159996
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] Please just add a -i in the geany.desktop for not stuck in "other use socket" improperly. (Issue #3871)
>I don't think this would be better. >Then every time a new instance would be started which works indepedent of the >existing one. This is especially unconvenient when opening files via the >.desktop items (task bar, app menus, file managers, ...). Agreed, we ain't gonna do that. > The socket file message probably means either Geany crashed Does it lead to this? I don't think so > Geany was run as root or `sudo` and that still owns the socket link in your > config directory. More likely. This is another example of a misconfigured sudo that wrecks dotfiles in the user's directory */me sighs*. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3871#issuecomment-2119386492 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Selection color changed in default theme but the changed color doesn't take effect if the "Find" dialog box is open. The changed color takes effect only when the "F
There is no background that is always right, thats why Scintilla has made it settable I guess. But the grey has sufficient contrast with black on white text and white on black text (on my monitor with my eyes, YMMV). Dimming the selection when not focused is a common idiom on Windows, and (IIUC) on Macos. Scintilla tries to work roughly the same on all platforms. The operative word is "dim", to become less conspicuous when unfocused, is the point of the feature, so choosing a bright colour is inappropriate for that use-case. Other cross platform applications that come from platforms other than Linux dim it, eg Vscode. Vim is Unix and from a terminal background where multiple windows do not exist so the feature was originally impossible, and Hasbeens is a Java Swing application IIUC which is Sun/Oracle Unix. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3874#issuecomment-2119289017 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Selection color changed in default theme but the changed color doesn't take effect if the "Find" dialog box is open. The changed color takes effect only when the "F
So, it looks like I will have to live with this. I have worked other editors also (vim, netbeans, etc.) and other software also but I never noticed this kind of thing - greying out selection if the edit pane is not in focus. May be some other editors also do it but it looks like they don't make it grey, but some other color so that the selected text is still visible and that's why I didn't notice it. So, in my opinion, I think Scintilla chose the wrong color because, in most of the cases, the text is black. May be they should have chosen light blue. Regards, Amit -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3874#issuecomment-2119280199 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Selection color changed in default theme but the changed color doesn't take effect if the "Find" dialog box is open. The changed color takes effect only when the "F
@eht16 has pointed out the reason you don't see the selection colour, you still have the focus on the find dialog, so the edit pane does not have focus, and Scintilla makes the selection grey when the edit pane is not focused. There is a fairly new API that allows [changing the unfocused styling](https://www.scintilla.org/ScintillaDoc.html#SC_ELEMENT_SELECTION_INACTIVE_TEXT), so I'm not sure its available in the version Geany uses, but when it is "somebody" can add elements to the `filetypes.common` to change it. In the meantime you will have to focus the edit pane to see the selected style. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3874#issuecomment-2119262104 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Selection color changed in default theme but the changed color doesn't take effect if the "Find" dialog box is open. The changed color takes effect only when the "F
My main issue is this: I keep the Find dialog box open to search for the text. I don't want to close the Find box. So, when I click Next on the Find box, it moves to the next matched item but it is not highlighting the matched text in the color that I gave in the selection variable settings. It is highlighting in silver color (0xc0c0c0) but the text is black in the default theme, and since these two colors are not very contrasting, the text is almost not visible. I have to go very close to the screen to see the matched text (since I searched using a regex pattern, so I don't know in advance that what all will be matched). Also, it looks like 0xc0c0c0 is hardcoded somewhere in the code. But in the default theme the text is black, so the choice of 0xc0c0c0 color is not good. Regards, Amit -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3874#issuecomment-2119255607 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Update ctags to p6.1.20240519.0 (PR #3877)
> it doesn't know whether it's inside a function so it shows all assignments > and the result is a little too noisy. Yeah, if they are not scoped then its not very useful. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3877#issuecomment-2119241869 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Update ctags to p6.1.20240519.0 (PR #3877)
> Python does this too, every assignment is a new declaration and shows in the > sidebar Yes, but this happens only for the global variables, not variables inside functions. Since the matlab parser is just a dumb regex parser, it doesn't know whether it's inside a function so it shows all assignments and the result is a little too noisy. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3877#issuecomment-2119238990 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Update ctags to p6.1.20240519.0 (PR #3877)
Python does this too, every assignment is a new declaration and shows in the sidebar, on the other hand Julia (where assignment is also declaration) has chosen not to show any assignments in the sidebar, YMMV. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3877#issuecomment-2119234485 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Please just add a -i in the geany.desktop for not stuck in "other use socket" improperly. (Issue #3871)
The socket file message probably means either Geany crashed (or was crashed by logging out or shutting down with it still running) or Geany was run as root or `sudo` and that still owns the socket link in your config directory. You can look there and the link will be obvious, so you should be able to just delete it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3871#issuecomment-2119231983 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Update ctags to p6.1.20240519.0 (PR #3877)
Just thinking, in https://github.com/geany/geany/pull/3859 I mapped matlab variables to `tm_tag_variable_t` so they are displayed in the sidebar but maybe the result is a little too verbose. Especially since it generates a tag for every variable assignment - I just tried it with some random code from github and it displays lots of identical variables in the sidebar, just every time the variable gets assigned. So shouldn't we rather map it to `tm_tag_undef_t`? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3877#issuecomment-2119231054 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] codenav/goto_file: Fix use-after-free crash (PR #1339)
Merged #1339 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1339#event-12858384938 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] codenav/goto_file: Fix use-after-free crash (PR #1339)
Tested and works. Thank you! -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1339#issuecomment-2119229141 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Selection color changed in default theme but the changed color doesn't take effect if the "Find" dialog box is open. The changed color takes effect only when the "F
Could it be that the selection color just changes when the find dialog is open because the focus is set from the Geany main window to the find dialog? At least, I see similar behaviour on Linux as well. If so, this is not a problem at all but rather normal behavior and not related to the find dialog. To verify, @amit-choudhary-0523 does it also happen when you click into the search field in the toolbar? Or when opening any other dialog? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3874#issuecomment-2119225672 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Geany takes \n as 'n' in search/replace whole words only. It should treat new lines as '\n' search only (Issue #3875)
To add to @eht16 comment, search replace does not understand the context of what it is editing, it does not see a programming language string in which `\n` means newline, it just sees text characters `\` and `n`. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3875#issuecomment-2119224792 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany] Update ctags to p6.1.20240519.0 (PR #3877)
This PR contains some ctags updates which were made upstream as discussed in https://github.com/geany/geany/pull/3859. Apart from that I noticed that the `update-ctags.py` script didnt copy the updated libreadtags library so I modified it to do so and as a result this PR also contains updated readtags.c/h which was missed in the previous PR. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3877 -- Commit Summary -- * update-ctags.py: Also copy the readtags library * Update ctags to p6.1.20240519.0 * Add missing powershell mapping * Update matlab unit test output -- File Changes -- M ctags/libreadtags/readtags.c (298) M ctags/libreadtags/readtags.h (20) M ctags/main/repoinfo.h (2) M ctags/parsers/jscript.c (96) M ctags/parsers/matlab.c (11) M ctags/parsers/pascal.c (11) M ctags/parsers/powershell.c (35) M scripts/update-ctags.py (4) M src/tagmanager/tm_parser.c (1) M tests/ctags/matlab_test.m.tags (4) -- Patch Links -- https://github.com/geany/geany/pull/3877.patch https://github.com/geany/geany/pull/3877.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3877 You are receiving this because you are subscribed to this thread. Message ID: geany/geany/pull/3...@github.com
[Github-comments] Re: [geany/geany] Please just add a -i in the geany.desktop for not stuck in "other use socket" improperly. (Issue #3871)
I don't think this would be better. Then every time a new instance would be started which works indepedent of the existing one. This is especially unconvenient when opening files via the .desktop items (task bar, app menus, file managers, ...). To me it sounds rather like this would only fix the symptom for another problem: why does Geany think the socket it wants to use belongs to another user? In any case, you always can override the .desktop yourself via `~/.local/share/applications/geany.desktop`. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3871#issuecomment-2119214222 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Geany takes \n as 'n' in search/replace whole words only. It should treat new lines as '\n' search only (Issue #3875)
I wonder if this could be too specific? Maybe there are cases where it is legitimite to treat the 'n' in '\n' as whole word if the context does not know about escape sequences. The behavior can be changed by adding '\\' to the `wordchars` settings in `filetypes.common` and the filetype definition files for the various filetypes. For details, see https://geany.org/manual/#filetype-configuration. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3875#issuecomment-2119211699 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Geany takes \n as 'n' in search/replace whole words only. It should treat new lines as '\n' search only (Issue #3875)
Closed #3875 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3875#event-12858279682 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geanyctags, projectorganizer, vimode: Some README and URL updates (PR #1348)
Merged #1348 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1348#event-12858259774 You are receiving this because you are subscribed to this thread. Message ID:
