[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
Did not CI already do that in "CI Build / Linux Meson Build (pull_request)" ? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2054065400 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: correctly set WIN32 in config.h (PR #3660)
> ``` > $ cc -dM -E - < /dev/null | grep WIN32 > 137:#define __WIN32__ 1 > 183:#define _WIN32 1 > 301:#define WIN32 1 > 325:#define __WIN32 1 > ``` Yes, gcc and clang both defines those macros which are not official or documented by Microsoft. Those are probably for compatibility with ancient code. Android has similar issue about `ANDROID` vs `__ANDROID__` but the later one should be used according to documentation. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3660#issuecomment-2054056772 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany] meson: Add icon with geany program (PR #3812)
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3812 -- Commit Summary -- * meson: Add icon with geany program -- File Changes -- M meson.build (4) -- Patch Links -- https://github.com/geany/geany/pull/3812.patch https://github.com/geany/geany/pull/3812.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3812 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: correctly set WIN32 in config.h (PR #3660)
This underlying issue has been fixed in upstream ctags repository. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3660#issuecomment-2037147774 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
> Maybe we can stop making a build for Windows (hopeful). I would suggest to provide Windows installer. Most of the users will still use official installer who are not familiar with msys2 and its packaging system. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2036203592 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
> Is that harmless on Linux builds? The `win_subsystem` option is valid for Windows target only. geany 2.0 is built with meson in msys2 project, see https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-geany/PKGBUILD -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2036181922 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: correctly set WIN32 in config.h (PR #3660)
> Is `_WIN32` set for cross builds? `_WIN32` is set in compiler which targets Windows platform - no header or IDE is required. You can verify that using `cc -dM -E - < /dev/null | grep WIN32` command. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3660#issuecomment-2036167518 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: correctly set WIN32 in config.h (PR #3660)
> And they are in ctags code, so this would have to be fixed upstream. I have created a pull request to fix it in upstream ctags repository. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3660#issuecomment-2035221498 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
This would be similar as `-mwindows` flag in src/Makefile.am https://github.com/geany/geany/blob/3a92129d61d4d8e96136e29d4709bb638527be40/src/Makefile.am#L157 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2034823993 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
Previously, a console window is shown in background when geany.exe is executed. This change fixes the above issue by specifying _windows_ subsystem type. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3811 -- Commit Summary -- * meson: Prevent showing console after running geany in Windows -- File Changes -- M meson.build (3) -- Patch Links -- https://github.com/geany/geany/pull/3811.patch https://github.com/geany/geany/pull/3811.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix building with meson in mingw (PR #3466)
Closed #3466. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3466#event-11866481075 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix building with meson in mingw (PR #3466)
Is there any progress on this topic? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3466#issuecomment-1529045047 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix building with meson in mingw (PR #3466)
Rebase done. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3466#issuecomment-1519056261 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix building with meson in mingw (PR #3466)
@Biswa96 pushed 3 commits. d0f84fcee7bff902896ab61e259e6e2eed54e1c1 meson: Fix conditions when function is absent in Windows 8d6e4d3b33c0e0c0f563e871b27cc14ce9da7521 meson: Define WIN32 macro for ctags cd35bd52030908b632930532c6d563ea9119337f CI: Add mingw meson build -- View it on GitHub: https://github.com/geany/geany/pull/3466/files/bafaaef3031611c39535f655343f57defce526ba..cd35bd52030908b632930532c6d563ea9119337f You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix building with meson in mingw (PR #3466)
I have added a basic mingw64 meson workflow. The CI needs permission to allow that. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3466#issuecomment-1518981645 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix building with meson in mingw (PR #3466)
@Biswa96 pushed 1 commit. bafaaef3031611c39535f655343f57defce526ba CI: Add mingw meson build -- View it on GitHub: https://github.com/geany/geany/pull/3466/files/3c960a4045a186ab825b8ff55df515a0071d3214..bafaaef3031611c39535f655343f57defce526ba You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix building with meson in mingw (PR #3466)
Maybe we should discuss that CI topic in separate issue or pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3466#issuecomment-1518684434 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix building with meson in mingw (PR #3466)
If required, I can try to add the mingw meson build in CI and replace autotools with meson also. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3466#issuecomment-1518197507 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany] Fix building with meson in mingw (PR #3466)
Fixes https://github.com/geany/geany/issues/3435 @AntumDeluge @eli-schwartz You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3466 -- Commit Summary -- * meson: Fix conditions when function is absent in Windows * meson: Define WIN32 macro for ctags -- File Changes -- M meson.build (22) -- Patch Links -- https://github.com/geany/geany/pull/3466.patch https://github.com/geany/geany/pull/3466.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3466 You are receiving this because you are subscribed to this thread. Message ID:
