Re: [Github-comments] [geany/geany] Show zoom level in status bar. (#1697)
@rodrigo1406: no, it's not merged yet. See #2339. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1697#issuecomment-616619190
Re: [Github-comments] [geany/geany-plugins] Debugger Plugin on Raspian (Pi4) doesn't work (not loaded) (#957)
@Ehlarm: Did you try to re-install lib-vte with ```sudo apt-get install libvte-2.91-dev```? Did VTE installation work well - no error messages or so? I re-checked compiling Geany and Geany-Plugins 1.36 on my Ubuntu machine. Works fine. All plugins depending on VTE are build, e.g. debugger and scope. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/957#issuecomment-591013507
Re: [Github-comments] [geany/geany-plugins] Debugger Plugin on Raspian (Pi4) doesn't work (not loaded) (#957)
@Ehlarm: Was your output from Geany-Plugins truncated on copying it into this issue? There should be something like this on the end: ``` Features: GeanyVC GtkSpell support: no Markdown library: peg-markdown Utility library: yes Utility library VTE support: yes ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/957#issuecomment-591011536
Re: [Github-comments] [geany/geany-plugins] Debugger Plugin on Raspian (Pi4) doesn't work (not loaded) (#957)
For completeness please also report the gtk and glib version, you can find them in Geany's about dialog. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/957#issuecomment-590475677
Re: [Github-comments] [geany/geany-plugins] debugger (#938)
@Ehlarm: please open a new issue and report your details there as this issue is about a different operating system so the problem fixes might differ and should not be mixed up. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/938#issuecomment-590405319
Re: [Github-comments] [geany/geany-plugins] Make libgit2 version preprocessor conditionals compatible with libgit… (#956)
LGBI and build passed, fine for me. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/956#issuecomment-590104073
Re: [Github-comments] [geany/geany-plugins] Find in file not working in geany on ubuntu 16.04 (#593)
@grubernd: could you provide an example file and search string so that we can reproduce the problem? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/593#issuecomment-585355440
Re: [Github-comments] [geany/geany-plugins] [WIP] commander: fixed deprecated gtk3 calls (#865)
I don't see a good solution for this. The gtk people keep on deprecating stuff. At the moment I will not continue work on this - I more tend to wait until gtk2 support is dropped and only one version needs to be supported. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/865#issuecomment-583585541
Re: [Github-comments] [geany/geany] What exactly are the required deps for building on Ubuntu? (#2403)
Did you run ```./autogen.sh``` first? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2403#issuecomment-557703911
Re: [Github-comments] [geany/geany] Geany becomes slow and unresponsive when editing tags of large html files? (#2401)
Do you have any plugins enabled? Does the problem disappear if you disable all plugins? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2401#issuecomment-557156169
Re: [Github-comments] [geany/geany] GTK+ 3 installation not used by default by configure script (#2393)
IMHO the documentation at https://geany.org/manual/dev/hacking.html#gtk-versions-api-documentation sounds like GTK2 is the default. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2393#issuecomment-552967077
[Github-comments] [geany/geany] Add "Close Documents to the Left" feature (#2365)
Not much to say, simply the same as Close Documents to the Right - only to the left. Also see #2282. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/2365 -- Commit Summary -- * Add Close Documents to the Left feature -- File Changes -- M src/notebook.c (32) -- Patch Links -- https://github.com/geany/geany/pull/2365.patch https://github.com/geany/geany/pull/2365.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2365
Re: [Github-comments] [geany/geany] Show zoom level in status bar. (#1697)
> Bah, forget it. This is dead now. Move on. Ok, will wait for #2339 to be merged. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1697#issuecomment-542516427
Re: [Github-comments] [geany/geany-plugins] Utilities for Pair Tag Highlighter (#926)
@vmkononenko: please have a look. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/926#issuecomment-542318297
Re: [Github-comments] [geany/geany-plugins] Utilities for Pair Tag Highlighter (#926)
LarsGit223 approved this pull request. I have re-tested and now it seems to work fine. Goto and Select work as expected, also on elements which start at the beginning of the document. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/926#pullrequestreview-302067852
Re: [Github-comments] [geany/geany] Show zoom level in status bar. (#1697)
> Most likely it's done that since you created a second PR with the same > branch. You could try and close the second one and I suspect the "Re-open" > option will become active again for this PR. The second/other PR is from another branch ```showzoom2```. But I already pushed again to ```showzoom``` before trying to re-open this PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1697#issuecomment-542267111
Re: [Github-comments] [geany/geany] Show zoom level in status bar. (#1697)
I pushed to showzoom again and I hopefully have restored the branch but I do not see it here since it's already closed. How can I re-open this PR? Github only let's me create a new PR from ```LarsGit223:showzoom```. Would that re-open this one? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1697#issuecomment-541833077
Re: [Github-comments] [geany/geany] Show zoom in status bar (use specifier %z). (#2339)
@LarsGit223 pushed 1 commit. c7113a70234c78267209cbb43cafb429d50ec947 added missing docs -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/2339/files/e07c43e0b0048f29f8685cd86d599c851da7dedf..c7113a70234c78267209cbb43cafb429d50ec947
Re: [Github-comments] [geany/geany-plugins] Utilities for Pair Tag Highlighter (#926)
LarsGit223 requested changes on this pull request. I re-tested this and select seems to work fine now :+1: There is one little open issue: if the cursor is in a closing tag and the matching opening tag starts at the beginning of the document, then goto does not work. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/926#pullrequestreview-301448047
Re: [Github-comments] [geany/geany] Opening multiple files opens multiple Geanys (#2357)
Works fine for me with Geany master branch, Ubuntu 18.04.3, Files (Nautilus) application. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2357#issuecomment-541740609
Re: [Github-comments] [geany/geany-plugins] treebrowser: fix icons in the tree and the toolbar (#927)
LarsGit223 commented on this pull request.
>
ctype = g_content_type_guess(path, NULL, 0, NULL);
icon = g_content_type_get_icon(ctype);
g_free(ctype);
if (icon != NULL)
{
- gtk_icon_size_lookup(GTK_ICON_SIZE_MENU, , NULL);
- info =
gtk_icon_theme_lookup_by_gicon(gtk_icon_theme_get_default(), icon, width,
GTK_ICON_LOOKUP_USE_BUILTIN);
- g_object_unref(icon);
+ info =
gtk_icon_theme_lookup_by_gicon(gtk_icon_theme_get_default(), icon, 16, 0);
Ok, then we leave it as-is. I didn't doubt that it works I just wondered if
there is a coding style for stuff like this which says 'use constants or
literals.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/927#discussion_r334326275
Re: [Github-comments] [geany/geany-plugins] treebrowser: fix icons in the tree and the toolbar (#927)
LarsGit223 requested changes on this pull request.
Apart from the two little remarks, it looks good to me.
> - GtkIconSet *icon_set;
-
- icon_set = gtk_icon_factory_lookup_default(stock_id);
-
- if (icon_set)
- return gtk_icon_set_render_icon(icon_set,
gtk_widget_get_default_style(),
-
gtk_widget_get_default_direction(),
-
GTK_STATE_NORMAL, GTK_ICON_SIZE_MENU, NULL, NULL);
- return NULL;
-}
-#endif
-
-static GdkPixbuf *
-utils_pixbuf_from_path(gchar *path)
+static GIcon *
+utils_gicon_from_path(gchar *path)
The parameter path could be const.
>
ctype = g_content_type_guess(path, NULL, 0, NULL);
icon = g_content_type_get_icon(ctype);
g_free(ctype);
if (icon != NULL)
{
- gtk_icon_size_lookup(GTK_ICON_SIZE_MENU, , NULL);
- info =
gtk_icon_theme_lookup_by_gicon(gtk_icon_theme_get_default(), icon, width,
GTK_ICON_LOOKUP_USE_BUILTIN);
- g_object_unref(icon);
+ info =
gtk_icon_theme_lookup_by_gicon(gtk_icon_theme_get_default(), icon, 16, 0);
What is usually used for icon sizes? You entered 16 but what about using a gtk
constant like before?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/927#pullrequestreview-301037073
Re: [Github-comments] [geany/geany-plugins] Tableconvert: Disable menu general menu item in case of unsupported file type (#922)
LarsGit223 commented on this pull request. > @@ -27,7 +27,7 @@ #include #include - +#include This is not required. I removed it and can still build Geany-Plugins. Also it makes the Travis-CI build fail for some reason (but I don't know why). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/922#pullrequestreview-299631494
Re: [Github-comments] [geany/geany-plugins] Tableconvert: Disable menu general menu item in case of unsupported file type (#922)
LarsGit223 requested changes on this pull request.
Fine for me, except that ```cb_table_convert_change_document``` should also be
a static function.
> @@ -35,6 +35,19 @@ PLUGIN_SET_TRANSLATABLE_INFO(
GeanyPlugin*geany_plugin;
GeanyData *geany_data;
+
+PluginCallback plugin_callbacks[] =
+{
+ { "editor-notify", (GCallback) _table_convert_change_document,
FALSE, NULL },
+ { "document-activate", (GCallback) _table_convert_change_document,
FALSE, NULL },
+ { "document-filetype-set", (GCallback)
_table_convert_change_document, FALSE, NULL },
+ { "document-new", (GCallback) _table_convert_change_document, FALSE,
NULL},
+ { "geany-startup-complete", (GCallback)
_table_convert_change_document, FALSE, NULL },
+ { "document-close", (GCallback) _table_convert_change_document,
FALSE, NULL},
+ { NULL, NULL, FALSE, NULL }
+};
I guess that's fine now.
> @@ -338,6 +351,31 @@ void cb_table_convert_type(G_GNUC_UNUSED GtkMenuItem
> *menuitem, G_GNUC_UNUSED gp
convert_to_table(TRUE, GPOINTER_TO_INT(gdata));
}
+void cb_table_convert_change_document(G_GNUC_UNUSED GtkMenuItem *menuitem,
G_GNUC_UNUSED gpointer gdata)
Should still be static. Unless you prefer it that way.
> @@ -338,6 +351,31 @@ void cb_table_convert_type(G_GNUC_UNUSED GtkMenuItem
> *menuitem, G_GNUC_UNUSED gp
convert_to_table(TRUE, GPOINTER_TO_INT(gdata));
}
+void cb_table_convert_change_document(G_GNUC_UNUSED GtkMenuItem *menuitem,
G_GNUC_UNUSED gpointer gdata)
+{
+ set_activate_state();
+}
+
+void set_activate_state()
+{
+ // getting document
+ GeanyDocument *doc = NULL;
+ doc = document_get_current();
+
+ if (
+ doc != NULL && (
Ok, when the events are fired, a document is most likely just opened or
switched to so there most likely cannot be a selection (yet).
> @@ -70,6 +70,6 @@ extern TableConvertRule tablerules[];
extern void cb_table_convert(G_GNUC_UNUSED GtkMenuItem *menuitem,
G_GNUC_UNUSED gpointer gdata);
extern void cb_table_convert_type(G_GNUC_UNUSED GtkMenuItem *menuitem,
gpointer gdata);
-extern void convert_to_table(gboolean header, gint file_type);
+extern void cb_table_convert_change_document(G_GNUC_UNUSED GtkMenuItem
*menuitem, gpointer gdata);
See above. Should be static and removed from the header file.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/922#pullrequestreview-299566518
Re: [Github-comments] [geany/geany-plugins] pairtaghighlighter: do not stop scanning on linebreaks (#914)
@vmkononenko: please have a look. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/914#issuecomment-539587374
Re: [Github-comments] [geany/geany] Iterate in tab order for *Close Other Documents* (#2347)
What is this PR doing or better said what is the advantage compared to the current code? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2347#issuecomment-539585330
Re: [Github-comments] [geany/geany-plugins] Tableconvert: Disable menu general menu item in case of unsupported file type (#922)
LarsGit223 commented on this pull request.
> @@ -338,6 +351,31 @@ void cb_table_convert_type(G_GNUC_UNUSED GtkMenuItem
> *menuitem, G_GNUC_UNUSED gp
convert_to_table(TRUE, GPOINTER_TO_INT(gdata));
}
+void cb_table_convert_change_document(G_GNUC_UNUSED GtkMenuItem *menuitem,
G_GNUC_UNUSED gpointer gdata)
+{
+ set_activate_state();
+}
+
+void set_activate_state()
+{
+ // getting document
+ GeanyDocument *doc = NULL;
+ doc = document_get_current();
+
+ if (
+ doc != NULL && (
Can you explain what you mean please? I mean it would be good to check if there
is a selection, not really getting it (there is the ```doc``` pointer and
that's all we need?).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/922#discussion_r332334357
Re: [Github-comments] [geany/geany-plugins] Tableconvert: Disable menu general menu item in case of unsupported file type (#922)
LarsGit223 commented on this pull request.
> @@ -338,6 +351,31 @@ void cb_table_convert_type(G_GNUC_UNUSED GtkMenuItem
> *menuitem, G_GNUC_UNUSED gp
convert_to_table(TRUE, GPOINTER_TO_INT(gdata));
}
+void cb_table_convert_change_document(G_GNUC_UNUSED GtkMenuItem *menuitem,
G_GNUC_UNUSED gpointer gdata)
+{
+ set_activate_state();
+}
+
+void set_activate_state()
+{
+ // getting document
+ GeanyDocument *doc = NULL;
+ doc = document_get_current();
+
+ if (
+ doc != NULL && (
Well, the menu item is doing nothing if there is no selection. IMHO it should
check the selection or if not the user should get a message that a selection is
needed before selecting the menu item.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/922#discussion_r332155013
Re: [Github-comments] [geany/geany] Color Chooser Inserts and Replaces Text - Purpose of Tool is Misleading (#2204)
@allanwmacdonald: We added a section to the manual describing the Color Chooser. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2204#issuecomment-539110711
Re: [Github-comments] [geany/geany-plugins] Overview: initialize color variables (#916)
> In any case, I'm fine with this PR if it shuts up cppcheck; this isn't > performance critical in anyway, and it doesn't affect readability. I agree to this and vote for merging it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/916#issuecomment-538766979
Re: [Github-comments] [geany/geany-plugins] Disable menu general menu item in case of unsupported file type (#922)
@frlan: it would be nice if you could prefix the commit message with ```tableconvert: ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/922#issuecomment-538747334
Re: [Github-comments] [geany/geany-plugins] Disable menu general menu item in case of unsupported file type (#922)
LarsGit223 requested changes on this pull request.
> @@ -338,6 +351,31 @@ void cb_table_convert_type(G_GNUC_UNUSED GtkMenuItem
> *menuitem, G_GNUC_UNUSED gp
convert_to_table(TRUE, GPOINTER_TO_INT(gdata));
}
+void cb_table_convert_change_document(G_GNUC_UNUSED GtkMenuItem *menuitem,
G_GNUC_UNUSED gpointer gdata)
This is a local function so IMHO it should be static and only declared in
```tableconvert.c``` not in ```tableconvert.h```.
> @@ -338,6 +351,31 @@ void cb_table_convert_type(G_GNUC_UNUSED GtkMenuItem
> *menuitem, G_GNUC_UNUSED gp
convert_to_table(TRUE, GPOINTER_TO_INT(gdata));
}
+void cb_table_convert_change_document(G_GNUC_UNUSED GtkMenuItem *menuitem,
G_GNUC_UNUSED gpointer gdata)
+{
+ set_activate_state();
+}
+
+void set_activate_state()
+{
The same here. This is only a static function.
> @@ -71,5 +71,7 @@ extern TableConvertRule tablerules[];
extern void cb_table_convert(G_GNUC_UNUSED GtkMenuItem *menuitem,
G_GNUC_UNUSED gpointer gdata);
extern void cb_table_convert_type(G_GNUC_UNUSED GtkMenuItem *menuitem,
gpointer gdata);
extern void convert_to_table(gboolean header, gint file_type);
+extern void cb_table_convert_change_document(G_GNUC_UNUSED GtkMenuItem
*menuitem, gpointer gdata);
+extern void set_activate_state();
I suggest to move this two function declarations above to the beginning of
```tableconvert.c```. And I would remove the not required ```extern```.
> @@ -338,6 +351,31 @@ void cb_table_convert_type(G_GNUC_UNUSED GtkMenuItem
> *menuitem, G_GNUC_UNUSED gp
convert_to_table(TRUE, GPOINTER_TO_INT(gdata));
}
+void cb_table_convert_change_document(G_GNUC_UNUSED GtkMenuItem *menuitem,
G_GNUC_UNUSED gpointer gdata)
+{
+ set_activate_state();
+}
+
+void set_activate_state()
+{
+ // getting document
+ GeanyDocument *doc = NULL;
+ doc = document_get_current();
+
+ if (
+ doc != NULL && (
This should also check if there is a current selection or not. The function
```convert_to_table()``` is only doing something if there is a selection (```if
(sci_has_selection(doc->editor->sci)) ...```).
> @@ -35,6 +35,19 @@ PLUGIN_SET_TRANSLATABLE_INFO(
GeanyPlugin*geany_plugin;
GeanyData *geany_data;
+
+PluginCallback plugin_callbacks[] =
+{
+ { "editor-notify", (GCallback) _table_convert_change_document,
FALSE, NULL },
+ { "document-activate", (GCallback) _table_convert_change_document,
FALSE, NULL },
+ { "document-filetype-set", (GCallback)
_table_convert_change_document, FALSE, NULL },
+ { "document-new", (GCallback) _table_convert_change_document, FALSE,
NULL},
+ { "geany-startup-complete", (GCallback)
_table_convert_change_document, FALSE, NULL },
+ { "document-close", (GCallback) _table_convert_change_document,
FALSE, NULL},
+ { NULL, NULL, FALSE, NULL }
+};
Do you really need all of this callbacks? I guess at least
```geany-startup-complete``` is not required or am I overseeing something?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/922#pullrequestreview-297838319
Re: [Github-comments] [geany/geany] Replace Deprecated `gtk_color_selection_dialog_new` with `gtk_color_chooser_dialog_new` (#2340)
LarsGit223 requested changes on this pull request.
The gtk version checks are not correct. This will break on systems between gtk
version 3.0 and 3.4.
> @@ -828,20 +842,27 @@ void tools_color_chooser(const gchar *color)
if (ui_widgets.open_colorsel == NULL)
{
+#if (gtk_major_version == 3)
+ ui_widgets.open_colorsel =
gtk_color_chooser_dialog_new(_("Color Chooser"),
GTK_WINDOW(main_widgets.window));
```gtk_color_chooser_dialog_new()``` requires at least gtk version 3.4 not 3.
You could use ```#if GTK_CHECK_VERSION(3, 4, 0) ... else ... endif``` for a
correct version check.
> GeanyDocument *doc = document_get_current();
+ g_return_if_fail(doc != NULL);
+#if (gtk_major_version == 3)
+ GdkRGBA color;
+ char hex[8] = { 0 };
+
+
gtk_color_chooser_get_rgba(GTK_COLOR_CHOOSER(ui_widgets.open_colorsel), );
+ sprintf(hex, "#%02X%02X%02X",
This requires version 3.4 not 3.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2340#pullrequestreview-297837203
Re: [Github-comments] [geany/geany] Show zoom level in status bar. (#1697)
@codebrainz: thanks, did not know that I can rename branches. I'll try to remeber that if I get to the same situation again. Now I got the new PR open anyway so I will keep that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1697#issuecomment-538686102
Re: [Github-comments] [geany/geany] Show zoom level in status bar. (#1697)
#2339 is not a fix of this branch, I just checked out master and applied the changes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1697#issuecomment-538672669
Re: [Github-comments] [geany/geany] Show zoom level in status bar. (#1697)
@codebrainz: I mixed up the commit history. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1697#issuecomment-538667634
Re: [Github-comments] [geany/geany] Show zoom in status bar (use specifier %z). (#2339)
@kugel-: I did something wrong on rebasing/squashing the original PR and so the commit history was completely messed up. From there I did not know how to get back to a clean history. (I usually squash without problems and do not create new PRs without reason) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2339#issuecomment-538645321
Re: [Github-comments] [geany/geany] doc: added documentation for the Color Chooser (#2337)
> Could also mention that if the cursor is next to/within a hash-prefixed hex > code, then the dialog will display the color the code represents. Done. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2337#issuecomment-538642468
Re: [Github-comments] [geany/geany] doc: added documentation for the Color Chooser (#2337)
@LarsGit223 pushed 1 commit. e32e5bb0bf7f8fa31940e1edc9b284b75de2845a doc: added documentation for the Color Chooser -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/2337/files/a9d88e7dc5696b922295d1ad1395afbc729f382d..e32e5bb0bf7f8fa31940e1edc9b284b75de2845a
Re: [Github-comments] [geany/geany] Show zoom level in status bar. (#1697)
Do not merge this, closing in favor of #2339. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1697#issuecomment-538641738
Re: [Github-comments] [geany/geany] Show zoom level in status bar. (#1697)
Closed #1697. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1697#event-2689249777
[Github-comments] [geany/geany] Show zoom in status bar (use specifier %z). (#2339)
Replacement PR for PR #1697. I re-applied the changes to the current master, re-tested and created this PR. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/2339 -- Commit Summary -- * Show zoom in status bar (use specifier %z). -- File Changes -- M src/editor.c (1) M src/sciwrappers.c (10) M src/sciwrappers.h (3) M src/ui_utils.c (16) -- Patch Links -- https://github.com/geany/geany/pull/2339.patch https://github.com/geany/geany/pull/2339.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2339
Re: [Github-comments] [geany/geany] Show zoom level in status bar. (#1697)
Sorry, broke it. Will post another clean PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1697#issuecomment-538640073
Re: [Github-comments] [geany/geany] Show zoom level in status bar. (#1697)
I will try to squash it myself. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1697#issuecomment-538637393
Re: [Github-comments] [geany/geany] doc: added documentation for the Colour Chooser (#2337)
LarsGit223 commented on this pull request. > @@ -1145,6 +1145,17 @@ applications, in that you'll need to continue to hold > down the Ctrl and Shift keys while typing the code point hex digits (and the Enter or Return to finish the code point). +Inserting color values +^^ + +You can insert a color value by selecting *Tools->Colour Chooser* from the menu. Fixed now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2337#discussion_r331582663
Re: [Github-comments] [geany/geany] doc: added documentation for the Colour Chooser (#2337)
LarsGit223 commented on this pull request. > @@ -1145,6 +1145,17 @@ applications, in that you'll need to continue to hold > down the Ctrl and Shift keys while typing the code point hex digits (and the Enter or Return to finish the code point). +Inserting color values +^^ + +You can insert a color value by selecting *Tools->Colour Chooser* from the menu. Forget it. Just noticed my desktop language was indeed set to ```English (United Kingdom)```. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2337#discussion_r331580949
Re: [Github-comments] [geany/geany] doc: added documentation for the Colour Chooser (#2337)
LarsGit223 commented on this pull request. > @@ -1145,6 +1145,17 @@ applications, in that you'll need to continue to hold > down the Ctrl and Shift keys while typing the code point hex digits (and the Enter or Return to finish the code point). +Inserting color values +^^ + +You can insert a color value by selecting *Tools->Colour Chooser* from the menu. +A dialog appears to select the wanted color. On clicking on *Apply* or *Select* +the code for the choosen color will be inserted in the format *#RRGGBB*. Thanks, fixed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2337#discussion_r331579166
Re: [Github-comments] [geany/geany] doc: added documentation for the Colour Chooser (#2337)
@LarsGit223 pushed 1 commit. 90eb26f432f2557001c8bca22e1388543864ecb6 doc: added documentation for the Colour Chooser -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/2337/files/848dc1710cb7fa98e73326319f5241fdf7123482..90eb26f432f2557001c8bca22e1388543864ecb6
Re: [Github-comments] [geany/geany] doc: added documentation for the Colour Chooser (#2337)
LarsGit223 commented on this pull request. > @@ -1145,6 +1145,17 @@ applications, in that you'll need to continue to hold > down the Ctrl and Shift keys while typing the code point hex digits (and the Enter or Return to finish the code point). +Inserting color values +^^ + +You can insert a color value by selecting *Tools->Colour Chooser* from the menu. But the menu item not. This is taken from the menu as-is. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2337#discussion_r331577748
[Github-comments] [geany/geany] doc: added documentation for the Colour Chooser (#2337)
I added a little section documenting the Colour Chooser to the manual. Also see #2204. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/2337 -- Commit Summary -- * doc: added documentation for the Colour Chooser -- File Changes -- M doc/geany.txt (11) -- Patch Links -- https://github.com/geany/geany/pull/2337.patch https://github.com/geany/geany/pull/2337.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2337
Re: [Github-comments] [geany/geany] Show zoom level in status bar. (#1697)
LarsGit223 commented on this pull request.
> +gint sci_get_fontsize(ScintillaObject *sci, gint style)
+{
+ return (gint) SSM(sci, SCI_STYLEGETSIZE, (uptr_t) style, 0);
+}
Changed and tested. Now looks like your code snippet below.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1697#discussion_r331472383
Re: [Github-comments] [geany/geany] Show zoom level in status bar. (#1697)
LarsGit223 commented on this pull request. > @@ -218,6 +219,8 @@ void > sci_move_selected_lines_up (ScintillaObject *sci); void sci_set_font_fractional (ScintillaObject *sci, gint style, const gchar *font, gdouble size); +gint sci_get_fontsize (ScintillaObject *sci, gint style); Done. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1697#discussion_r331471960
Re: [Github-comments] [geany/geany] Show zoom level in status bar. (#1697)
@LarsGit223 pushed 1 commit. e7b9ece9256e0f890899eb06aa52313290b7cacf sciwrappers: use fractional size in 'sci_get_font_size()' -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/1697/files/9ea258374dfb791e19af46c354a01bbdcc4f5a31..e7b9ece9256e0f890899eb06aa52313290b7cacf
Re: [Github-comments] [geany/geany] Show zoom level in status bar. (#1697)
LarsGit223 commented on this pull request.
> @@ -304,6 +305,21 @@ static gchar *create_statusbar_statistics(GeanyDocument
> *doc,
g_string_append_printf(stats_str, "%d",
sci_get_style_at(doc->editor->sci,
pos));
break;
+ case 'z':
+ zoom = sci_get_zoom(doc->editor->sci);
+ if (zoom != 0)
+ {
+ gint size, percent;
+
+ size =
sci_get_fontsize(doc->editor->sci, STYLE_DEFAULT);
+ if (size > 0)
+ {
+ percent = (size + zoom) * 100 /
size;
I agree, out-of-scope for this PR.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1697#discussion_r331467291
Re: [Github-comments] [geany/geany-plugins] Utilities for Pair Tag Highlighter (#763)
LarsGit223 requested changes on this pull request. I tested this and 2 things do not seem to work: - if the opening tag starts at position 0, then goto and select do not work - if the cursor is in the closing tag, then select does not work -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/763#pullrequestreview-297345299
Re: [Github-comments] [geany/geany] highlighting: added API call to query GeanyLexerStyle by name (#2336)
LarsGit223 commented on this pull request.
> + * @return A pointer to the style struct.
+ */
+GEANY_API_SYMBOL
+const GeanyLexerStyle *highlighting_get_named_style(const gchar *named_style)
+{
+ GeanyLexerStyle *cs;
+ gchar *comma, *name = NULL;
+
+ g_return_val_if_fail(named_style, NULL);
+ name = utils_strdupa(named_style); /* named_style must not be
written to, may be a static string */
+
+ comma = strstr(name, ",");
+ if (comma)
+ {
+ *comma = '\0'; /* terminate name to make lookup work */
+ }
I removed it. It was a leftover copied in from ```read_named_style()```. But it
doesn't make sense any more.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2336#discussion_r331244133
Re: [Github-comments] [geany/geany] highlighting: added API call to query GeanyLexerStyle by name (#2336)
@LarsGit223 pushed 1 commit. e096b0f080ebe92c4c4d9b9b442174212fe4f096 highlighting: added API call to query GeanyLexerStyle by name -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/2336/files/9ff6031fb01b9e49cd92dc3221ac21a2e34c736f..e096b0f080ebe92c4c4d9b9b442174212fe4f096
[Github-comments] [geany/geany] highlighting: added API call to query GeanyLexerStyle by name (#2336)
This PR adds a new API call to ```highlighting.c```: ``` C const GeanyLexerStyle *highlighting_get_named_style(const gchar *named_style); ``` This shall enable plugins to query styles dedicated to plugin specific highlighting. Plugins could have their own styles with dedicated keys/names and instruct users to simply add them to a colorscheme. Another option would be a configuration setting in a plugin but then the setting is separated from the colorscheme which may result in bad readability. Also see the discussion at https://github.com/geany/geany/issues/2331. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/2336 -- Commit Summary -- * highlighting: added API call to query GeanyLexerStyle by name -- File Changes -- M src/highlighting.c (24) M src/highlighting.h (2) M src/plugindata.h (2) -- Patch Links -- https://github.com/geany/geany/pull/2336.patch https://github.com/geany/geany/pull/2336.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2336
Re: [Github-comments] [geany/geany-plugins] Geanyprj's Project dock is extremely small (#744)
@codebrainz: yes, your suggested change fixes the issue. Posted a PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/744#issuecomment-537913556
[Github-comments] [geany/geany-plugins] geanyprj: fixed cut-off sidebar tab under gtk3 (#917)
Fixes #744. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/917 -- Commit Summary -- * geanyprj: fixed cut-off sidebar tab under gtk3 -- File Changes -- M geanyprj/src/sidebar.c (2) -- Patch Links -- https://github.com/geany/geany-plugins/pull/917.patch https://github.com/geany/geany-plugins/pull/917.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/917
Re: [Github-comments] [geany/geany-plugins] [New feature] autoclose: remove pairing quotes (#687)
This has now been implemented in PR #896 and merged into master. So it will be included in the next Geany release 1.37. Please test. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/687#issuecomment-537818519
[Github-comments] [geany/geany-plugins] tableconvert: disable menu item on not supported filetypes (#915)
Actually the Tableconvert plugin supports the filetypes HTML, LaTeX and SQL. I suggest that the menu item _"Convert to table"_ should be disabled if the current document's filetype is not supported. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/915
Re: [Github-comments] [geany/geany-plugins] compile error in RaspberryPi (#893)
@abbrdr: any feedback? did you have a chance to try my advice? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/893#issuecomment-537668292
Re: [Github-comments] [geany/geany-plugins] Changes from Wolfgang Schwarz (#317)
> -fixed a bug when one selects text from right to left and then shifts it > (see comment "in case selection_start was after selection_end" in my code) This seems to already have been fixed by @b4n in dc0af51b96d4b98ada550d464b0cd17b24268419. I cannot reproduce any issue on selecting text from the right and shifting it. Works fine. > -When no text is selected, now the current word is exchanged with the > next/previous, which I find quite useful. IMHO this does not fit into this plugin. If someone needs it then a new PR to a different plugin where it fits in or a new plugin is welcome. I vote for closing this un-merged. What do the others think? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/317#issuecomment-537664876
Re: [Github-comments] [geany/geany] ui_utils: sort the recent file names (#258)
I guess this can be closed? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/258#issuecomment-537638466
Re: [Github-comments] [geany/geany] Plugin-API: extended project API (#2234)
@codebrainz, @elextr: What do you think? Can we merge this? We just had a new release so if this is merged there is plenty of time for testing. I am asking cause a PR for the workbench plugin is depending on this PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2234#issuecomment-537634493
Re: [Github-comments] [geany/geany] Show zoom level in status bar. (#1697)
Can this be merged? I just resolved the conflicts. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1697#issuecomment-537629699
Re: [Github-comments] [geany/geany] Show zoom level in status bar. (#1697)
@LarsGit223 pushed 1 commit. 9ea258374dfb791e19af46c354a01bbdcc4f5a31 Merge branch 'master' into showzoom -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/1697/files/9510042013e1fe0c476c25dce6f1183cb52c85b6..9ea258374dfb791e19af46c354a01bbdcc4f5a31
Re: [Github-comments] [geany/geany] Added template file for CSS (#2259)
@b4n, @codebrainz, @elextr: ping. What's the final decission? Merge or close it unmerged? I'm fine with both, just want to get the ticket done. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2259#issuecomment-537623166
Re: [Github-comments] [geany/geany] Question: highlight-API: is loading/querying of individual styles possible? (#2331)
@elextr:
> Ahh, probably the best would be to use indicators for that,
My question is not about how highlighting itself can be implemented. The
highlighting is already implemented in the plugin, see the code below and yes
it's using indicators:
```
static void highlight_tag(ScintillaObject *sci, gint openingBracket,
gint closingBracket, gint color)
{
scintilla_send_message(sci, SCI_SETINDICATORCURRENT, INDICATOR_TAGMATCH, 0);
scintilla_send_message(sci, SCI_INDICSETSTYLE,
INDICATOR_TAGMATCH, INDIC_ROUNDBOX);
scintilla_send_message(sci, SCI_INDICSETFORE, INDICATOR_TAGMATCH,
rgb2bgr(color));
scintilla_send_message(sci, SCI_INDICSETALPHA, INDICATOR_TAGMATCH, 60);
scintilla_send_message(sci, SCI_INDICATORFILLRANGE,
openingBracket, closingBracket-openingBracket+1);
}
```
The issue is that the colors are fixed coded into the plugin. And as always
this can just be fine for some themes and for others it's causing bad
readability because the color/style cannot be adjusted to the theme.
So I wondered if there is an already implemented, re-usable way to read in
color/style values. Colorschemes does not seem to add a new key and access it
somehow. I would prefer to define a key explicitly for the pairtaghighlighter
plugin. But colorschemes seem to be bound to predefined meanings/styles.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2331#issuecomment-537564659
Re: [Github-comments] [geany/geany] Question: highlight-API: is loading/querying of individual styles possible? (#2331)
> There is no API because setting it programatically would break this > configuration scheme. I only want to read a value, preferably be key name. There is a function for it, but it's static. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2331#issuecomment-537335554
Re: [Github-comments] [geany/geany] Question: highlight-API: is loading/querying of individual styles possible? (#2331)
@codebrainz: I saw an issue for the pairtaghighlighter plugin asking to make the highlihgt color/style configurable. Then I thought let's quickly add a new key/value pair to a color scheme and use that values. But then I stumbled across the API. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2331#issuecomment-537335380
Re: [Github-comments] [geany/geany] Html causes segmentation fault (#1882)
@philiprbrenan: can you still re-produce this issue? If yes could you please paste the original text here in the issue rather than an image for testing? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1882#issuecomment-537207100
Re: [Github-comments] [geany/geany] Behavior of line join (#2031)
@elextr: do you really think it's OK to boldly remove the exisiting capability? If yes, maybe we should remove it in Geany core and the new feature "Join lines" (as described above) IMHO is also a good candidate for the Line Operations plugin. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2031#issuecomment-537202381
Re: [Github-comments] [geany/geany] Close, reopen at same line (#2275)
@gsantner: I think what @philiprbrenan means is that it works fine if you close and re-open Geany. But it does not work as expected if you only close the document in Geany and then re-open it (without closing Geany itself). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2275#issuecomment-537194835
[Github-comments] [geany/geany] Question: highlight-API: is loading/querying of individual styles possible? (#2331)
I like to find the best way to let the user specify colors, e.g. by config, theme or whatever (I am talking about colors for text highlighting here not the UI parts outside the editor widget). The colorschemes seem to do the job. Looking at ```highlight.c``` it seems that every style specified in a colorscheme is loaded to the hash ```named_style_hash```. How can a plugin access a style by its key name? I only found this API call for querying a style but it does not look like it is allowing individual styles: ``` C const GeanyLexerStyle *highlighting_get_style(gint ft_id, gint style_id); ``` Thanks for all answers in advance. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2331
Re: [Github-comments] [geany/geany-plugins] [pair tag highlighter] keyword "font" in a html document (#432)
Should we close this? The ticket is 3 years old and there is no feedback to our questions and it was maybe fixed in the meantime. Can anybody reproduce this? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/432#issuecomment-537172421
[Github-comments] [geany/geany-plugins] pairtaghighlighter: do not stop scanning on linebreaks (#914)
Before this change the plugin stopped scanning for a tag on the start or the end of a line. Therefore tags which were split over multiple lines were not recognized. With this change the plugin scans forward or backward up to a certain limit and does not stop on a linebreak. The default limit is 1024 bytes but it can be changed by configuration if required. Fixes #775. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/914 -- Commit Summary -- * pairtaghighlighter: do not stop scanning on linebreaks -- File Changes -- M pairtaghighlighter/src/pair_tag_highlighter.c (163) -- Patch Links -- https://github.com/geany/geany-plugins/pull/914.patch https://github.com/geany/geany-plugins/pull/914.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/914
Re: [Github-comments] [geany/geany-plugins] No debugger in Geany 1.36 (#913)
You are welcome. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/913#issuecomment-536686905
Re: [Github-comments] [geany/geany-plugins] No debugger in Geany 1.36 (#913)
Closed #913. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/913#event-2674298026
Re: [Github-comments] [geany/geany-plugins] No debugger in Geany 1.36 (#913)
Hmmm...you could try to build ```libvte``` from source. But I have never done it, so I do not know how simple or difficult it is. Maybe you can ask somewhere in the Arch community if they know how to get it or build it on Arch. But without ```libvte``` you cannot build the debugger plugin or the scope plugin. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/913#issuecomment-536675518
Re: [Github-comments] [geany/geany-plugins] No debugger in Geany 1.36 (#913)
First, let me inform you that there are two debugger plugins in the Geany-Plugins package you can choose from: - the debugger plugin - the scope plugin If the configure script tells you that the debugger plugin is not enabled than a requirement to build the debugger plugin is missing. It could be that the VTE package is missing on your system. Please follow one of the steps below, depending on your GTK version: - if you are building for GTK2 please try ```sudo apt-get install libvte-dev``` - if you are building for GTK3 please try ```sudo apt-get install libvte-2.91-dev``` After that please run ```./configure``` again. Does it say ```yes``` now? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/913#issuecomment-536662437
Re: [Github-comments] [geany/geany-plugins] autoclose: remove pairing quotes (#896)
@scriptum: ping. @frlan: maybe we should merge this if there is no reaction and so others can test and use it in master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/896#issuecomment-536318141
Re: [Github-comments] [geany/geany-plugins] debugger (#758)
Closed #758. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/758#event-2670587632
Re: [Github-comments] [geany/geany-plugins] debugger (#758)
I close this now as the debugger plugin with GTK2 & 3 support was just released in Geany-Plugins 1.36. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/758#issuecomment-536193931
[Github-comments] [geany/geany-plugins] NEWS: removed 'Fix misplaced '#define SCOPE_MAX_EVALUATE_EXPR_LENGTH (PR #885)' (#911)
This issue was only a temporary problem during 1.36 development. The issue that was fixed did not exist in 1.35 so this bugfix shouldnt be mentioned in NEWS. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/911 -- Commit Summary -- * NEWS: removed Fix misplaced #define SCOPE_MAX_EVALUATE_EXPR_LENGTH (PR #885) -- File Changes -- M NEWS (1) -- Patch Links -- https://github.com/geany/geany-plugins/pull/911.patch https://github.com/geany/geany-plugins/pull/911.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/911
Re: [Github-comments] [geany/geany] Enhancement - Vertical Editing Sequential Numbering (#2317)
@intact: ooops, of course. Did totally oversee that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2317#issuecomment-534697093
Re: [Github-comments] [geany/geany] Enhancement - Vertical Editing Sequential Numbering (#2317)
As an alternative to the possible feature name _"Increment selection"_ I suggest _"Enumerate selection"_. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2317#issuecomment-534663769
Re: [Github-comments] [geany/geany] Enhancement - Vertical Editing Sequential Numbering (#2317)
@AdamDanischewski: thanks, I think we have enough information :smile: IMHO this can be implemented in a new plugin or maybe better as an extension of the Line-Operations plugin. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2317#issuecomment-534599209
Re: [Github-comments] [geany/geany] Too Many Filetypes in Open Dropdown! How can I shorten list? (#2296)
@RufusVS: the open dialog is created in the function ```create_open_file_dialog()```. It calls the function ```filetypes_create_file_filter()``` to create the filter and that function is filling the filter with all filetypes from the list ```filetypes_by_title```. This is filled on startup of Geany in the function ```filetypes_init()``` which calls ```filetypes_init_types()```. Then first built-in filetypes are set in function ```init_builtin_filetypes()```. And then filetypes are added from the application data directory and the config directory. On my Ubuntu machine these are ```/usr/local/share/geany/filedefs``` and ```/home/username/.config/geany/filedefs```. So, if I understood it right you would have to remove some files from the directory as you did **AND** shorten the list in ```init_builtin_filetypes()```and re-build Geany. Also notice that if you remove some files in the directories it will only have an effect after re-starting Geany. But as the others wrote the list should be scrollable and it seems to be some kind of Gtk issue. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2296#issuecomment-533971546
Re: [Github-comments] [geany/geany] Geany adds a new line in the end even when the option is disabled (#2310)
I noticed that there is no new line at the end of the file if the option ```Ensure new line at file end``` is disabled and the file is closed. I checked that with a different editor (not with Geany). Only on re-opening the file in Geany the new line appears in the editor window - but it's not in the file. Not sure if that helps. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2310#issuecomment-533827646
Re: [Github-comments] [geany/geany] Ability to text-edit .geany files (#2303)
It works if I select it from the file browser inside of Geany or if I use _"File / Open"_ from the menu. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2303#issuecomment-531591143
Re: [Github-comments] [geany/geany] build menu: images missing? (#2302)
Closed #2302. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2302#event-2634767742
Re: [Github-comments] [geany/geany] build menu: images missing? (#2302)
You are right! Executing the command
```
gsettings set org.gnome.settings-daemon.plugins.xsettings overrides
"{'Gtk/ButtonImages': <1>, 'Gtk/MenuImages': <1>}"
```
and a reboot fixed the problem. Thanks.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2302#issuecomment-531582429
Re: [Github-comments] [geany/geany] build menu: images missing? (#2302)
@codebrainz: Thanks. I use Ubuntu 18.04.3, Gnome desktop. What OS do you use? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2302#issuecomment-531578180
[Github-comments] [geany/geany] build menu: images missing? (#2302)
On looking at the build code I noticed the following table:
``` C
static struct BuildMenuItemSpec {
const gchar *stock_id;
const gint key_binding;
const guint build_grp;
const guint build_cmd;
const gchar *fix_label;
Callback *cb;
} build_menu_specs[] = {
{GTK_STOCK_CONVERT, GEANY_KEYS_BUILD_COMPILE,
GBO_TO_GBG(GEANY_GBO_COMPILE),
GBO_TO_CMD(GEANY_GBO_COMPILE), NULL, on_build_menu_item},
{GEANY_STOCK_BUILD, GEANY_KEYS_BUILD_LINK, GBO_TO_GBG(GEANY_GBO_BUILD),
GBO_TO_CMD(GEANY_GBO_BUILD), NULL, on_build_menu_item},
{NULL, -1, MENU_FT_REST,
GBO_TO_CMD(GEANY_GBO_BUILD) + 1, NULL, on_build_menu_item},
/*...more entries... */
```
As I understand the code images are loaded from the stock IDs (e.g.
```GTK_STOCK_CONVERT```). But on my system I do not see any images in the build
menu (tested on GTK2 and 3). My question: do other people see any images in the
build menu? Might this be a desktop issue?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2302
Re: [Github-comments] [geany/geany] filetypesprivate.h: Don't include build.h (#2299)
@b4n > @LarsGit223 at least projfilecmds is being accessed outside build.c, in > project.c, so it's not actually completely private to build.c. If it was, > build.h should have had the forward declaration, and build.c the complete one. Maybe I was not precise enough. The ```GeanyBuildCommand``` pointers are used outside of ```build.c``` but only for: - address comparison - calls to g_free - calls to SETPTR So the struct items are only used privately in ```build.c```. Therefore a forward declaration seems to be enough, including ```build.h``` is not required (at the moment). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2299#issuecomment-531469012
Re: [Github-comments] [geany/geany] filetypesprivate.h: Don't include build.h (#2299)
@elextr: I did a code search in Geany of these pointers: ``` /* TODO: move to structure in build.h and only put a pointer here */ GeanyBuildCommand *filecmds; GeanyBuildCommand *ftdefcmds; GeanyBuildCommand *execcmds; GeanyBuildCommand *homefilecmds; GeanyBuildCommand *homeexeccmds; GeanyBuildCommand *projfilecmds; GeanyBuildCommand *projexeccmds; ``` They are all used only with ```g_free```, ```SETPTR``` or direct address comparison. No one of that is passed to any function declared in ```build.h``` outside of ```build.c```. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2299#issuecomment-531466998
Re: [Github-comments] [geany/geany] filetypesprivate.h: Don't include build.h (#2299)
> Yes, but then they shouldn't be in ```filetypesprivate.h``` Why? Even if the struct items are not accessed then you still need the pointers to the memory for the filetype specific build commands. So I agree we might need to include ```build.h``` for the function declarations but I like the forward declaration to keep the header file as small as possible. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2299#issuecomment-531466556
Re: [Github-comments] [geany/geany] filetypesprivate.h: Don't include build.h (#2299)
> This doesn't make any sense, the point of including headers is so that > definitions are available to compilers for checking and optimisations. By > making them opaque pointers that is defeated. I disagree. If items inside ```struct GeanyBuildCommand``` are private and shall only be used inside ```build.c``` then it is practicable to use a forward declaration and hide the struct items. No code outside ```build.c``` can then use the struct in a wrong way. Of course this requires functions to access/use all aspects of ```struct GeanyBuildCommand```. As the ```struct GeanyFiletypePrivate``` only uses pointers to ```struct GeanyBuildCommand``` the compiler has all information it needs and can still do type checks etc. (it is still a ```struct GeanyBuildCommand *``` not a ```void *```). If something was missing then there would be a compiler error. But I would prefer a forward declaration with typedef. As long as the items of ```struct GeanyBuildCommand``` shall only be used in ```build.c``` and if it shall stay like that in the future then I actually consider this good style. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2299#issuecomment-531463173
